<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi Bekket,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">  I don't see any use case in the codebase adding clEnumValEnd at the end of list (for example, [1]), I also don't see there is</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">clEnumValEnd. Do I miss something here?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[1] <a href="http://llvm.org/doxygen/DwarfDebug_8cpp_source.html">http://llvm.org/doxygen/DwarfDebug_8cpp_source.html</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">chenwj</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-06-06 9:53 GMT+08:00 Bekket McClane via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<div><br></div><div>Can anyone help reviewing the code?</div><div>I think this revision is pretty important regarding that the command line library is also used in many non-LLVM projects.</div><div>It’s nice to provide a correct guideline to whom use the library for the first time.</div><div><br></div><div>B.R</div><div>McClane<br><div><blockquote type="cite"><div>Bekket McClane <<a href="mailto:bekket.mcclane@gmail.com" target="_blank">bekket.mcclane@gmail.com</a>> 於 2017年6月3日 下午9:00 寫道：</div><br class="m_-966080896849615807Apple-interchange-newline"><div><div style="word-wrap:break-word">Hi,<div><br></div><div>The argument list for cl::values in command line library should be end with null or clEnumValEnd. But the tutorial page(<a href="http://llvm.org/docs/CommandLine.html" target="_blank">http://llvm.org/docs/<wbr>CommandLine.html</a>) doesn’t follow the rule, which would cause program crash during runtime.</div><div><br></div><div>I’d send a code review: <a href="https://reviews.llvm.org/D33861" target="_blank">https://reviews.llvm.<wbr>org/D33861</a></div><div>Please cc other folks related to this part.</div><div><br></div><div>Best Regards,</div><div>Bekket McClane</div></div></div></blockquote></div><br></div></div><br>______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Wei-Ren Chen (陳韋任)<br>Homepage: <a href="https://people.cs.nctu.edu.tw/~chenwj" target="_blank">https://people.cs.nctu.edu.tw/~chenwj</a></div></div></div>
</div>