<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 1, 2017, at 2:18 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jun 1, 2017 at 2:15 PM Pete Cooper via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On May 31, 2017, at 9:09 PM, Adrian Prantl <<a href="mailto:aprantl@apple.com" target="_blank" class="">aprantl@apple.com</a>> wrote:</div><br class="m_-1836408722246266205Apple-interchange-newline"><div class=""><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><div class=""><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""> Dwarf should be in libDebugInfoDWARF.</div></div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">I think the reason why it isn't there is because lib/DebugInfo is for *consuming* debug info, but these definitions are useful for both reading and writing DWARF. That is not to say that they couldn't be moved somewhere else of course (but probably not lib/DebugInfo in its current form).</div></div></div></div></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class="">Ah, didn’t know that. I’m sure a bunch of the others I mentioned also have similar reasons for being where they are.</div><div class=""><br class=""></div><div class="">Ultimately its a judgement call, but i’d say that libDebugInfoDWARF is a less bad place for this file than libSupport. Not a great reason to move it, but if someone wants to I still wouldn’t personally object.</div></div></blockquote><div class=""><br class="">That would seem to have a concrete disadvantage, though - that'd make many things dependent on libDebugInfo that aren't currently - so there'd be real changes in build time, etc building all the DWARF parsing/dumping/etc API code for users who only generate DWARF but don't parse it.<br class=""></div></div></div></div></blockquote>Thats a fair point. And ultimately something we could check for before moving it (see who is using Dwarf.o but not libDebugInfoDwarf).</div><div><br class=""></div><div>The other place for this particular case (and i'm not really trying that hard to move this one file, just discussing merits), would be libCodeGen or even libMC. For better or worse, everyone who emits dwarf today does it with the MC layer, even dsymutil unfortunately.</div><div><br class=""></div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""><br class="">If it were moved, it'd probably want to be a separate library that both DWARF reading libraries and DWARF writing libraries could be dependent on. (unless the reading/writing could be tightened up to the point where it was mostly a common library used for both sides)<br class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete<br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><br class=""></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">-- adrian</div></div></div></div></blockquote></div><br class=""></div>_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>