<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 1, 2017 at 2:15 PM Pete Cooper via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div>On May 31, 2017, at 9:09 PM, Adrian Prantl <<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>> wrote:</div><br class="m_-1836408722246266205Apple-interchange-newline"><div><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"> Dwarf should be in libDebugInfoDWARF.</div></div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">I think the reason why it isn't there is because lib/DebugInfo is for *consuming* debug info, but these definitions are useful for both reading and writing DWARF. That is not to say that they couldn't be moved somewhere else of course (but probably not lib/DebugInfo in its current form).</div></div></div></div></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>Ah, didn’t know that.  I’m sure a bunch of the others I mentioned also have similar reasons for being where they are.</div><div><br></div><div>Ultimately its a judgement call, but i’d say that libDebugInfoDWARF is a less bad place for this file than libSupport.  Not a great reason to move it, but if someone wants to I still wouldn’t personally object.</div></div></blockquote><div><br>That would seem to have a concrete disadvantage, though - that'd make many things dependent on libDebugInfo that aren't currently - so there'd be real changes in build time, etc building all the DWARF parsing/dumping/etc API code for users who only generate DWARF but don't parse it.<br><br>If it were moved, it'd probably want to be a separate library that both DWARF reading libraries and DWARF writing libraries could be dependent on. (unless the reading/writing could be tightened up to the point where it was mostly a common library used for both sides)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div>Cheers,</div><div>Pete<br><blockquote type="cite"><div><div style="word-wrap:break-word;line-break:after-white-space"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">-- adrian</div></div></div></div></blockquote></div><br></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>