<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Diana,<div class=""><br class=""></div><div class="">Thanks for the summary.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 11, 2017, at 4:01 AM, Diana Picus <<a href="mailto:diana.picus@linaro.org" class="">diana.picus@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi all,<br class=""><br class="">I'm still running some validation on this, I'll send an email when<br class="">it's done. If that goes well I don't have anything against making the<br class="">switch.<br class=""><br class="">For the record, here's a summary of issues that were deferred for<br class="">later on (some of which are optimization-ish and we might decide to<br class="">never do at -O0 at all):<br class="">* Crash in RegBankSelect for half fp types:<br class=""><a href="https://bugs.llvm.org/show_bug.cgi?id=32560" class="">https://bugs.llvm.org/show_bug.cgi?id=32560</a><br class=""></div></div></blockquote><div><br class=""></div><div>I’ll have a look.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="">* Improving constant placement: <a href="http://bugs.llvm.org/show_bug.cgi?id=32561" class="">http://bugs.llvm.org/show_bug.cgi?id=32561</a><br class=""></div></div></blockquote><div><br class=""></div><div>I’ve commented in the PR to mention the localizer technic I was playing with, if someone wants to give it a try.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="">* Fancy switch lowering<br class="">* Transforming division-by-constant-power-of-2 into right shift</div></div></blockquote><blockquote type="cite" class=""><div class=""><div class=""><br class="">AFAICT all the other issues that were brought up were fixed (yay!).<br class=""><br class="">Cheers,<br class="">Diana<br class=""></div></div></blockquote><div><br class=""></div>Cheers,</div><div>-Quentin<br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class=""><br class="">On 11 May 2017 at 08:44, Kristof Beyls via llvm-dev<br class=""><<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">On 10 May 2017, at 17:36, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:<br class=""><br class=""><br class="">MultiSource/Benchmarks/mediabench/mpeg2/mpeg2dec/mpeg2decode (46%): Function<br class="">Reference_IDCT: Probably due to creating all constants in the entry BB +<br class="">spilling floating point data through an X register:<br class=""><br class="">FastISel:<br class="">fadd d0, d1, d0<br class="">str d0, [sp,#528]<br class="">GlobalISel:<br class="">fadd d0, d1, d0<br class="">fmov x9, d0<br class="">stur x9, [x29,#-48]<br class=""><br class=""><br class="">Good finding, I forgot to do stores in my previous fix. I’ll do them<br class="">shortly.<br class=""><br class=""><br class="">Should be fixed by r302679<br class=""><br class=""><br class="">Thanks Quentin,<br class=""><br class="">That reduces the slow-down when enabling globalisel at -O0 from 13% (on<br class="">r302453) to 9.5% (on r302679) in my experiments.<br class="">The code size increase also reduces from just over 3% to 2.8%.<br class=""><br class="">Kristof<br class=""><br class=""><br class="">_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""><br class=""></blockquote></div></div></blockquote></div><br class=""></div></body></html>