<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Great Quentin :).
<div class=""><br class="">
</div>
<div class="">I've rerun the benchmarks comparing "-O0 -g" with "-O0 -g -mllvm -global-isel -mllvm -global-isel-abort=2" on r302453, on AArch64 Cortex-A57.</div>
<div class="">I indeed see almost no moves between GPR and FPR registers anymore (see details below for where I still see some).</div>
<div class="">On geomean, I see 13% slow down (down from 17% on my previous run).</div>
<div class="">On geomean, code size increase is about 3% (down from 11% on my previous run).</div>
<div class="">I also checked debug info quality with the DIVA tool on the test-suite; and asked one of our DS-5 validation guys to test debug experience for GlobalISel in combination with the <a href="https://developer.arm.com/products/software-development-tools/ds-5-development-studio" class="">ARM
DS-5 Development Studio</a> debugger. Both of us didn't find any issues with the debug info produced at -O0 -g with GlobalISel.</div>
<div class="">I didn't check compile time, nor do I intend to check that as I don't have a good infrastructure set up for that.</div>
<div class=""><br class="">
</div>
<div class="">Overall, my impression is that GlobalISel is ready to be enabled by default for AArch64 at -O0, if others also believe it's ready.</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">Thanks,</div>
<div class=""><br class="">
</div>
<div class="">Kristof</div>
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Detailed observations:</div>
<div class=""><br class="">
</div>
<div class="">
<ol class="MailOutline">
<li class="">Debug info analysis with <a href="https://github.com/SNSystems/DIVA/blob/master/linux/doc/DIVA_user_guide.pdf" class="">DIVA</a>:<br class="">
I used DIVA options "-a --show-generated --show-level --show-location" to dump and diff debug info differences for the test-suite for "-O0 -g" comparing GlobalISel with non-GlobalISel.<br class="">
The only difference I found was on MultiSource/Benchmarks/tramp3d-v4:<br class="">
<font face="Menlo" class=""> 001 37577 {Function} "operator*<double>" -> "Zero<double>"</font><br class="">
<font face="Menlo" class=""> - No declaration</font><br class="">
<font face="Menlo" class=""> - Template</font><br class="">
<font face="Menlo" class=""> 002 {TemplateParameter} "T" <- "double"</font><br class="">
<font face="Menlo" class="">- 002 37577 {Parameter} <- "Zero<double>"</font><br class="">
<font face="Menlo" class=""> 002 37577 {Parameter} <- "const double &"</font><br class="">
Which indicates that for non-GlobalISel, the Zero<double> parameter isn't present in the debug info for the instantiation of the below template function with T=double:<br class="">
<font face="Menlo" class="">template<class T></font><br class="">
<font face="Menlo" class=""> inline Zero<T> operator*(Zero<T>, const T&) { return Zero<T>(); }</font><br class="">
In other words, the debug info looks ever so slightly better with GlobalISel.</li><li class="">Quick analysis of reasons for slow down for the 10 programs that regress the most when enabling GlobalISel at -O0:
<ul class="">
<li class="">SingleSource/Benchmarks/BenchmarkGame/nsieve-bits (114% slowdown): no conversion of divide by power-of-2 to shift right. I think this is an improvement for -O0: no such optimization should be done when not requesting optimizations.</li><li class="">MultiSource/Benchmarks/MallocBench/gs/gs (88%): "interp" function: switch statement lowered as cascaded-sequence-of-conditional-branches.<br class="">
Same issue causes MultiSource/Applications/sqlite3/sqlite3 (71%).<br class="">
Same issue causes MultiSource/Applications/lua/lua (46%).</li><li class="">SingleSource/Benchmarks/Misc/flops-2 (75%): Poor lowering of fneg:
<ul class="">
<li class="">FastISel:<br class="">
<font face="Menlo" class="">ldur d0, [x29,#-16]<br class="">
fneg d0, d0<br class="">
stur d0, [x29,#-16]</font></li><li class="">GlobalISel:<br class="">
<font face="Menlo" class="">ldur d0, [x29,#-64]<br class="">
orr x8, xzr, #0x8000000000000000<br class="">
fmov d1, x8<br class="">
fsub d0, d1, d0<br class="">
fmov x8, d0<br class="">
stur x8, [x29,#-64]</font></li></ul>
</li><li class="">MultiSource/Benchmarks/Prolangs-C++/city/city (74%): a call to memcpy for copying 4 bytes is present with GlobalISel that isn't present with FastISel, in function vehicle::select_move().<br class="">
Same issue causes SingleSource/Benchmarks/Shootout-C++/Shootout-C++-moments (58.5%)</li><li class="">MultiSource/Applications/siod/siod (72%): Seems to be mainly due to loading constants in the entry BB, but I'm not sure that indeed is the biggest cause. (<a href="https://bugs.llvm.org//show_bug.cgi?id=32561" class="">https://bugs.llvm.org//show_bug.cgi?id=32561</a>)</li><li class="">MultiSource/Benchmarks/MiBench/consumer-typeset/consumer-typeset (48%): Due to creating all constants in the entry BB, see function CopyObject. (<a href="https://bugs.llvm.org//show_bug.cgi?id=32561" class="">https://bugs.llvm.org//show_bug.cgi?id=32561</a>)</li><li class="">MultiSource/Benchmarks/mediabench/mpeg2/mpeg2dec/mpeg2decode (46%): Function Reference_IDCT: Probably due to creating all constants in the entry BB + spilling floating point data through an X register:
<ul class="">
<li class="">FastISel:<br class="">
<font face="Menlo" class="">fadd d0, d1, d0<br class="">
str d0, [sp,#528]</font></li><li class="">GlobalISel:<br class="">
<font face="Menlo" class="">fadd d0, d1, d0<br class="">
fmov x9, d0<br class="">
stur x9, [x29,#-48]</font></li></ul>
</li></ul>
</li><li class="">Other overall impression when comparing code generation: The code size increase is probably mainly due to creating constants always in the entry BB of the function. For functions with many constants, this leads to lots and lots of constant creation
and then immediately spilling it to the stack. (<a href="https://bugs.llvm.org//show_bug.cgi?id=32561" class="">https://bugs.llvm.org//show_bug.cgi?id=32561</a>)</li></ol>
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 8 May 2017, at 20:38, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Hi Kristof,
<div class=""><br class="">
</div>
<div class="">I made a fix for PR32550, that is much less involved in<span style="font-size: inherit; white-space: pre-wrap;" class=""> r302453.</span>
<div class=""><br class="">
</div>
<div class="">In particular, it does not rely on the greedy mode of the regbankselect pass, thus there is no compile time implication.</div>
<div class=""><br class="">
</div>
<div class="">Could you try it and check where we stand?</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">-Quentin</div>
<div class="">
<blockquote type="cite" class="">
<div class="">On Apr 27, 2017, at 10:40 AM, Quentin Colombet via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Hi
Kristof,</span>
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Apr 27, 2017, at 9:47 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Hi
Quentin,</span>
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On 27 Apr 2017, at 00:48, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
Hi Kristof,
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Apr 6, 2017, at 6:53 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
I've been digging a little bit deeper into the biggest performance regressions I've observed.
<div class=""><br class="">
</div>
<div class="">What I've observed so far is:</div>
<div class="">* A lot of the biggest regressions are caused by unnecessarily moving floating point values through general purpose registers. I've raised <a href="http://bugs.llvm.org/show_bug.cgi?id=32550" class="">http://bugs.llvm.org/show_bug.cgi?id=32550</a> for
this. I think this one definitely needs fixing before enabling GlobalISel by default at -O0.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I commented in the PR. This is a known problem and we have a solution. Given this is an optimization in the sense that it does not affect the correctness of the program, we didn’t push for fixing it now.</div>
<div class=""><br class="">
</div>
<div class="">For O0 we wanted to focus ourselves on generating correct code. Unless the regressions you are seeing are preventing debugging/running of the program, I wouldn’t block the flip of the switch on that.</div>
<div class=""><br class="">
</div>
<div class="">What do you think? </div>
</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">For O0, I think most users care about fast compile time and an excellent debug experience.</div>
<div class="">Next to that, I am told that some users also use -O0 to have a straightforward, simple, mapping between source code and the generated assembly.</div>
<div class=""><br class="">
</div>
<div class="">Out of the issues I've seen so far, I think this is the single "optimization" issue that I feel gives a negative first impression of GlobalISel.</div>
<div class="">If users look at the generated assembly for floating point code it looks more like active de-optimization rather than "no optimization".</div>
<div class="">My guess is also that this may be the biggest reason for the about 20% performance slow-down and 11% code size increase I measured earlier.</div>
<div class="">OTOH, I clearly agree this is an optimization issue, not a correctness issue.</div>
<div class="">Combining the above, I think it would be best if this issue got fixed before we turn on GlobalISel by default at -O0, or we may end up hearing quite a few (non-critical) complaints about this from users.</div>
<div class="">Basically I think this is a tradeoff between giving a better first impression of GlobalISel vs getting more people to use and test it earlier.</div>
<div class=""><br class="">
</div>
<div class="">Thanks for the write-up on the PR, that is very useful.</div>
<div class="">Do you have any rough idea how much effort would be involved in getting this fixed?</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I’d say 2-3 weeks. Could actually be shorter if we don’t do all the refactoring I have in mind to make the table for the alternative mappings smaller, but I don’t think it is worth taking any shortcut here.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class="">
<div class="">I got the impression Daniel is making good progress on the tablegen generation, which is key to getting this issue fixed?</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">To be accurate, Daniel’s work on table gen is for the select phase, not regbankselect. In other words, right now, all the table for mappings for regbankselect are hand written and Daniel’s work is not changing that. The (weak) rationale is that
it is not on the critical path :).</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class="">
<div class="">I think that no matter whether we decide to switch the default before or after fixing this issue, this is one of the most urgent issues to fix as far as I can see.</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Agree. This is one of the top items of my todo list.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class="">
<div class=""><br class="">
</div>
<div class="">If there is some way I can help contribute to fixing PR32550, I would like to help; but with the dependency on tablegen generation, I'm not sure what the best way is to help make that PR get fixed faster?</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Thanks for offering to help. I agree that with the dependency on the tabelgen generation in the way, this is probably not a good use of your time. Depending when I can spare some time on this, I’ll either do it or explain the refactoring in the
google doc.</div>
<div class=""><br class="">
</div>
<div class="">In the meantime, I’d suggest to focus on validating the debug info on your side.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class="">
<div class=""><br class="">
</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">* FastISel seems to transform division-by-constant-power-of-2 into right shift (see <a href="https://github.com/llvm-mirror/llvm/blob/master/lib/CodeGen/SelectionDAG/FastISel.cpp#L456-L468" class="">https://github.com/llvm-mirror/llvm/blob/master/lib/CodeGen/SelectionDAG/FastISel.cpp#L456-L468</a>).
GlobalISel does not. It seems to me that at -O0 there may be reasons not perform this transformation, but maybe there is a good reason why FastISel does this?</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I think FastISel tries to generate the best code it can no matter what. For GISel O0 however, not doing this optimization sounds sensible to me.</div>
<div class="">Now, I would say that the same remark as the previous bullet point apply: we shouldn’t do it unless it gets in the way of running/debugging the program.</div>
</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I agree that these optimizations should not be done at -O0. I think not doing them is actually an improvement: you give the user what they asked, i.e. "no optimization", and an as-straigthforward-as-possible mapping from source to assembly.</div>
<div class=""><br class="">
</div>
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">* FastISel doesn’t\ seem to handle functions with switch statements, so it falls back to DAGISel. DAGISel produces code that's a lot better than GlobalISel for switch statement at -O0. I'm not sure if we need to do something here before enabling
GlobalISel by default. I'm thinking we may need to add a smarter way to lower switch statements rather than just a cascaded sequence of conditional branches.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Sounds optimization-ish to me. Same remark.</div>
</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Agreed, optimization-ish. In comparison to the above point on FastISel "peepholes", I think that lowering switch statements to something else than a cascaded sequence of conditional branches doesn't make the generated code harder to map to the
source. So, in comparison to the above point on FastISel "peepholes", I'm not actively against being smarter about lowering switch statements at -O0.</div>
<div class="">But I agree, this shouldn't hold up turning on GlobalISel by default at -O0.</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Other than the above remarks, before turning on GlobalISel by default, we'd better test/verify that debug info quality remains good.</div>
<div class="">I haven't looked into that at all, but am hoping to start looking into that soon, with the help of the DIVA tool (<a href="https://github.com/SNSystems/DIVA" class="">https://github.com/SNSystems/DIVA</a>) presented at last EuroLLVM (<a href="http://llvm.org/devmtg/2017-03//assets/slides/diva_debug_information_visual_analyzer.pdf" class="">http://llvm.org/devmtg/2017-03//assets/slides/diva_debug_information_visual_analyzer.pdf</a>).
I don't recall anyone so far making any statements about the quality of the debug info they've measured or experienced with GlobalISel enabled?</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">We ran the lldb test suite with GISel. IIRC, Tim has the details, GISel was on part with SDISel.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class="">
<div class=""><br class="">
</div>
<div class="">Other than the all of the above, I just wanted to mention that Oliver recently started running csmith on AArch64 GlobalISel and found one issue so far that already got fixed (<a href="https://bugs.llvm.org//show_bug.cgi?id=32733" class="">https://bugs.llvm.org//show_bug.cgi?id=32733</a>).</div>
<div class="">If he finds other correctness issues, I'm sure he'll keep on reporting them.</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
Great!</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">-Quentin<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="">I'll try to add the above content to the document Diana created at <font color="#1155cc" face="arial, sans-serif" class=""><span class="" style="font-size: 12.8px; orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><a href="https://goo.gl/IS2Bdw" class="">https://goo.gl/IS2Bdw</a></span></font> too.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class=""><br class="">
</div>
<div class="">Kristof</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On 3 Apr 2017, at 17:10, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" class="">Kristof.Beyls@arm.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
I've kicked off a run to compare "-O0 -g" versus "-O0 -g -mllvm -global-isel -mllvm -global-isel-abort=2".
<div class="">I've selected the test-suite (albeit a version which is a couple of months old now) and a few short-running proprietary benchmarks to get data back quickly for an initial feel of where things are.</div>
<div class="">This was running on Cortex-A57 AArch64 Linux.</div>
<div class=""><br class="">
</div>
<div class="">I saw one assertion failure in GlobalISel, see <a href="http://bugs.llvm.org/show_bug.cgi?id=32471" class="">http://bugs.llvm.org/show_bug.cgi?id=32471</a>. This is in a program compiled at -O2 (my out-dated test-suite still overrides -O0 and
instead uses -O for that program). The root cause of the failure seems to be due to LowLevelType not supporting vectors of pointers. I think this demonstrates that for correctness, we should be trying to test more than -O0, or even more than just LLVM-IR produced
by clang, as other front-ends could run into this even at -O0.</div>
<div class=""><br class="">
</div>
<div class="">Due to this assertion failure and the infrastructure I used, the numbers below do not include test-suite/MultiSource/Benchmarks results.</div>
<div class=""><br class="">
</div>
<div class="">On the non-correctness aspects, LNT tells me that:</div>
<div class="">- The programs that report execution time, on geomean are about 17% slower.</div>
<div class="">- The programs that report scores, on geomean are about 21% slower.</div>
<div class="">- Code size is up on geomean about 11%.</div>
<div class="">I'm afraid I don't have compile time numbers, nor any feel for debug info quality.</div>
<div class=""><br class="">
</div>
<div class="">I'll need quite a bit more time to dig into the details to come up with something actionable, although the fact that LowLevelType doesn't support vectors of pointers is already actionable.</div>
<div class="">Nevertheless, I thought to share what I see as is, to see if others see similar results so far.</div>
<div class=""><br class="">
</div>
<div class="">I thought Diana was going to look into fallback rate on the test-suite on AArch64 linux?</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class=""><br class="">
</div>
<div class="">Kristof</div>
<div class=""><br class="">
</div>
<div class="">
<blockquote type="cite" class="">
<div class="">On 30 Mar 2017, at 10:54, Renato Golin <<a href="mailto:renato.golin@linaro.org" class="">renato.golin@linaro.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">On 30 March 2017 at 00:27, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:<br class="">
<blockquote type="cite" class="">On iOS we are at 100% pass rate in 00 g for the LLVM test suite, standard<br class="">
benchmarks and unit tests. In about 5% of all functions GlobalIsel falls<br class="">
back to SDIsel.<br class="">
(Kristof Beyls would have the linux numbers.)<br class="">
The self host compiler correctly builds and runs the LLVM test suite in O0.<br class="">
</blockquote>
<br class="">
Having done no tests at all on my side, I think we need to have<br class="">
similar numbers on Linux to be able to flip across the board.<br class="">
<br class="">
I don't want to flip it only for Darwin and not Linux, as that will<br class="">
fragment the effort too much.<br class="">
<br class="">
I'll check with Diana and Kristof to know what's the best way forward,<br class="">
but it should be reasonably quick.<br class="">
<br class="">
cheers,<br class="">
--renato</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">LLVM
Developers mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<a href="mailto:llvm-dev@lists.llvm.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">llvm-dev@lists.llvm.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>