<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks. I forced a clean build in <a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1353" class="">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1353</a> and it's now green.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 21 Apr 2017, at 18:56, Galina Kistanova <<a href="mailto:gkistanova@gmail.com" class="">gkistanova@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hello Daniel,<div class=""><br class=""></div><div class="">> <span style="font-size:12.8px" class="">Is forcing a clean build something I can do from the </span><span class="gmail-m_5863905461653084051gmail-m_7438003506431646163gmail-il" style="background-color:rgb(255,255,255);font-size:12.8px">buildbot</span><span style="font-size:12.8px" class=""> interface? I've got a few patches to commit that are likely to trigger this problem.</span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">There are 2 possible ways to do so:</span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">1. You can force a clean build from the buildbot WebUI by specifying a property 'clean' with the value 'True' (<a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win" target="_blank" class="">http://lab.llvm.org:8011/buil<wbr class="">ders/llvm-clang-x86_64-expensi<wbr class="">ve-checks-win</a>, "Property 1 Name:" filed is 'clean' and the corresponding </span><span style="font-size:12.8px" class=""> "Value:" field is 'True', then click the "Force Build" button.)</span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">2. If you know in advance that your commit requires a clean build, you may add something like "Requires a clean build." </span><span style="font-size:12.8px" class=""><span style="font-size:12.8px" class=""> somewhere in the commit message</span>. That would trigger clean builds.<br class=""></span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">Not all builders support this, though. The llvm-clang-x86_64-expensiv<wbr class="">e-checks-win buildbot does. I'm in the middle of expanding these features to the rest of the builders.<br class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">As of the original issue, it seems those inc files are missing dependencies. I'll look into this.<br class=""></span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">Thanks<br class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class="">Galina<br class=""></span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class=""></span></div><div class=""><br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Apr 21, 2017 at 8:52 AM, Daniel Sanders via llvm-dev <span dir="ltr" class=""><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><br class=""><div class=""><span class="gmail-"><blockquote type="cite" class=""><div class="">On 21 Apr 2017, at 16:45, Yaron Keren <<a href="mailto:yaron.keren@gmail.com" target="_blank" class="">yaron.keren@gmail.com</a>> wrote:</div><br class="gmail-m_5399101082540227086Apple-interchange-newline"><div class=""><div dir="rtl" class=""><div dir="ltr" class="">clean buld forced the regeneration of X86GenGlobalISel.inc & AArch64GenGlobalISel.inc, which may have not happened otherwise.</div></div></div></blockquote><div class=""><br class=""></div></span>Thanks, I think that's the problem. I can see the tablegen commands in #1341 but they aren't in #1331 or #1340.<br class=""><br class="">I'll re-land this commit and we'll see if a clean build makes it work properly.<span class="gmail-"><br class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="rtl" class="">בתאריך יום ו׳, 21 באפר׳ 2017 ב-18:29 מאת Simon Pilgrim via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>>:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">For reasons I’m not sure about it needs a clean build every so often - I’ve forced a build at <a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1341" target="_blank" class="">http://lab.llvm.org:8011/<wbr class="">builders/llvm-clang-x86_64-<wbr class="">expensive-checks-win/builds/<wbr class="">1341</a> and its gone green again. </div></blockquote></div></div></blockquote><div class=""><br class=""></div></span>Thanks. My revert landed in <a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1340" target="_blank" class="">http://lab.llvm.org:8011/<wbr class="">builders/llvm-clang-x86_64-<wbr class="">expensive-checks-win/builds/<wbr class="">1340</a> but it continued to fail so I was very confused.</div><div class=""><br class=""></div><div class="">Is forcing a clean build something I can do from the buildbot interface? I've got a few patches to commit that are likely to trigger this problem.<span class="gmail-"><br class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><blockquote type="cite" class=""><div class="">On 21 Apr 2017, at 15:17, Daniel Sanders via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="gmail-m_5399101082540227086m_7490499738675966735Apple-interchange-newline"><div class=""><div style="overflow-wrap: break-word;" class=""><div class="">Hi,</div><div class=""><br class=""></div><div class="">One of my commits earlier today (r300964) is causing llvm-clang-x86_64-expensive-<wbr class="">checks-win to fail with a compilation error (<a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1331" target="_blank" class="">http://lab.llvm.org:8011/<wbr class="">builders/llvm-clang-x86_64-<wbr class="">expensive-checks-win/builds/<wbr class="">1331</a>) and I'm having trouble figuring out why. I had seen something similar before on MSVC so I tried fixing it in r300966 but with no luck. I then managed to reproduce it using an online MSVC compiler and fixed that issue in r300970 but still no luck. I'm going to revert the commit to make the bot green while I figure it out but I don't have a MSVC environment at the moment so I was wondering if anyone who does can reproduce the problem and tell me what it is that MSVC doesn't like.</div><div class=""><br class=""></div><div class="">Thanks</div></div>______________________________<wbr class="">_________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-dev</a><br class=""></div></blockquote></div><br class="">
<br class=""></div></div>______________________________<wbr class="">_________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
</div></blockquote></span></div><br class=""></div><br class="">______________________________<wbr class="">_________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-dev</a><br class="">
<br class=""></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></div></body></html>