<div dir="ltr">+1<br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 12, 2017 at 2:46 PM Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
    <p class="gmail_msg">Yep. Makes sense to me. There's nothing to simplify or
      constant-fold about an alloca.<br class="gmail_msg">
    </p>
    <p class="gmail_msg"> -Hal<br class="gmail_msg">
    </p></div><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
    <div class="m_6339425954552732618moz-cite-prefix gmail_msg">On 04/12/2017 04:23 PM, Craig Topper
      wrote:<br class="gmail_msg">
    </div>
    <blockquote type="cite" class="gmail_msg">
      
      <div dir="ltr" class="gmail_msg">Ping</div>
      <div class="gmail_extra gmail_msg"><br clear="all" class="gmail_msg">
        <div class="gmail_msg">
          <div class="m_6339425954552732618gmail_signature gmail_msg" data-smartmail="gmail_signature">~Craig</div>
        </div>
        <br class="gmail_msg">
        <div class="gmail_quote gmail_msg">On Fri, Apr 7, 2017 at 1:25 PM, Craig
          Topper <span dir="ltr" class="gmail_msg"><<a href="mailto:craig.topper@gmail.com" class="gmail_msg" target="_blank">craig.topper@gmail.com</a>></span>
          wrote:<br class="gmail_msg">
          <blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr" class="gmail_msg">
              <div class="gmail_msg">I notice that GetUnderlyingObject has a few checks,
                but alloca isn't one of them. Then it fall backs to
                SimplifyInstruction which doesn't know about alloca so
                falls back to just trying to constant fold it. This
                seems a little silly since I assume alloca can't be
                constant folded. Should we just detect this early in
                GetUnderlyingObject and stop?</div>
              <span class="m_6339425954552732618HOEnZb gmail_msg"><font color="#888888" class="gmail_msg">
                  <div class="gmail_msg"><br class="gmail_msg">
                  </div>
                  <div class="gmail_msg">
                    <div class="m_6339425954552732618m_6179612886951310766gmail_signature gmail_msg" data-smartmail="gmail_signature">~Craig</div>
                  </div>
                </font></span></div>
          </blockquote>
        </div>
        <br class="gmail_msg">
      </div>
    </blockquote>
    <br class="gmail_msg">
    </div><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"><pre class="m_6339425954552732618moz-signature gmail_msg" cols="72">-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
  </div></blockquote></div>