<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 03/07/2017 09:16 PM, Frederich Munch
via llvm-dev wrote:<br>
</div>
<blockquote
cite="mid:BN6PR17MB1444BC8AC20B75A6FD102BA9C92E0@BN6PR17MB1444.namprd17.prod.outlook.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;"
dir="ltr">
<p style="font-family: Calibri, Arial, Helvetica, sans-serif;"><span
style="font-size: 12pt;">Ughs, I'm not dying to wait
months...b</span><span style="font-size: 12pt;">ut i</span><span
style="font-size: 12pt;">f it thats the </span><span
style="font-size: 12pt;">way it is, then </span><span
style="font-size: 12pt;">it</span><span style="font-size:
12pt;">s the way it is.</span></p>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif;"><span
style="font-size: 12pt;">Tends to be </span><span
style="font-size: 12pt;">so many commits in a day it seemed
it was being lost in the noise/clique.</span><br>
</p>
</div>
</blockquote>
<br>
In general, we try not to have it take months. Sometimes people go
on vacation or just get really busy for a week or two. Development
is active, but for some components, the number of people really
familiar with them is small.<br>
<br>
In my experience, just keep pinging, and either the person reviewing
will get back to you, or we can find someone else to pick it up.
Finding the code owner, if there is one, is also a good bet. The job
of a code owner is to be reviewer of last resort (or to find
someone) - see the CODE_OWNERS.TXT file.<br>
<br>
<blockquote
cite="mid:BN6PR17MB1444BC8AC20B75A6FD102BA9C92E0@BN6PR17MB1444.namprd17.prod.outlook.com"
type="cite">
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;"
dir="ltr">
<p style="font-family: Calibri, Arial, Helvetica, sans-serif;">
</p>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif;">
<p><br>
</p>
</div>
<p><span style="font-family: Calibri, Arial, Helvetica,
sans-serif;">I did try to add some notes to the bug tracker,
but new logins are disabled, and the </span></p>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif;">email
to get one never replied...but I guess that's another topic!<br>
</div>
</div>
</blockquote>
<br>
I'll follow-up for you.<br>
<br>
-Hal<br>
<br>
<blockquote
cite="mid:BN6PR17MB1444BC8AC20B75A6FD102BA9C92E0@BN6PR17MB1444.namprd17.prod.outlook.com"
type="cite">
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;"
dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif;">
<br>
Thanks again, definitely alleviated some frustrations.</div>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font
style="font-size:11pt" color="#000000" face="Calibri,
sans-serif"><b>From:</b> Robinson, Paul
<a class="moz-txt-link-rfc2396E" href="mailto:paul.robinson@sony.com"><paul.robinson@sony.com></a><br>
<b>Sent:</b> Wednesday, March 8, 2017 2:05 AM<br>
<b>To:</b> Frederich Munch<br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<b>Subject:</b> RE: Restarting a stalled patch</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText"><br>
> Thanks. I have gone that route and there was no
response.<br>
<br>
Well, I see you pinged D30107 and there were some
comments yesterday.<br>
I don't see a ping on D29923 until today. Even with a
ping, it can<br>
take a while. Not to discourage you, but I have known
patches to<br>
sit for months waiting for review.<br>
<br>
> What constitutes 'particularly urgent'?<br>
<br>
I'd say, something that is blocking your other work
until it is <br>
resolved, or otherwise has a serious impact on you or
your users<br>
(if you are providing something to others).<br>
<br>
> In regards to D30107 it some fairly obvious
defect(s) and there are a<br>
> few bugs open in your database about the issue,<br>
<br>
If there are open bugs that you are fixing, it's
generally a good idea<br>
to mention which ones in the summary. You could also
post a reply to<br>
the bug pointing to the relevant review(s), which will
notify the<br>
people who filed the bug or cc'd themselves to it. This
is not to say<br>
that they will necessarily want to review it, but it's
worth doing.<br>
<br>
> but it seems an area that doesn't get
much interest (related to<br>
> DynamicLibrary class).<br>
<br>
I sympathize; it can be very hard to get reviews for
changes to the<br>
more obscure (or less interesting) parts of the code
base. <br>
<br>
> Thanks again.<br>
<br>
You're welcome. I promise you I have been where you
are!<br>
--paulr<br>
<br>
</div>
</span></font></div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>