<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Thanks for confirmation. Will fix and post review to phab.<br>
</p>
<br>
<div class="moz-cite-prefix">On 02/27/2017 09:15 PM, David Blaikie
wrote:<br>
</div>
<blockquote
cite="mid:CAENS6Eu01w=XQi_mugqq+sv91zkVV=rmYBJB6dGR=AFB6HCf8w@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">Sure enough sounds like a bug to me.</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Sat, Feb 25, 2017 at 7:42 AM Victor Leschuk
via llvm-dev <<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hello all,
it looks like we have a bug here but I am not sure. Currently<br
class="gmail_msg">
if we have two similar types with implicit_const attributes
and<br class="gmail_msg">
different values we end up with only one abbrev in
.debug_abbrev<br class="gmail_msg">
section. For example consider two structures: S1 with
implicit_const<br class="gmail_msg">
attribute ATTR and value VAL1 and S2 with implicit_const ATTR
and value<br class="gmail_msg">
VAL2. The .debug_abbrev section will contain only 1 related
record:<br class="gmail_msg">
<br class="gmail_msg">
[N] DW_TAG_structure_type DW_CHILDREN_yes<br
class="gmail_msg">
DW_AT_ATTR DW_FORM_implicit_const VAL1<br
class="gmail_msg">
// ....<br class="gmail_msg">
<br class="gmail_msg">
However it looks like we need to have two different
abbreviations here:<br class="gmail_msg">
<br class="gmail_msg">
[N] DW_TAG_structure_type DW_CHILDREN_yes<br
class="gmail_msg">
DW_AT_ATTR DW_FORM_implicit_const VAL1<br
class="gmail_msg">
// ....<br class="gmail_msg">
<br class="gmail_msg">
[M] DW_TAG_structure_type DW_CHILDREN_yes<br
class="gmail_msg">
DW_AT_ATTR DW_FORM_implicit_const VAL2<br
class="gmail_msg">
// ....<br class="gmail_msg">
<br class="gmail_msg">
What do you think? If it is a bug I will fix it (as I was the
one who<br class="gmail_msg">
added support for DW_FORM_implicit_const).<br
class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
Best Regards,<br class="gmail_msg">
Victor<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br
class="gmail_msg">
LLVM Developers mailing list<br class="gmail_msg">
<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg"
target="_blank">llvm-dev@lists.llvm.org</a><br
class="gmail_msg">
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br
class="gmail_msg">
</blockquote>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Best Regards,
Victor</pre>
</body>
</html>