<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 17 Feb 2017, at 00:45, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
First off, I just want to say wow and thank you. This kind of data is amazing. =D<br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
Thanks :)</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote">
<div class=""> </div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div class="gmail_msg" style="word-wrap: break-word;">
<div class="gmail_msg">
<div class="gmail_msg">For fourinarow, there seemed to be a lot more spill/fill code, so probably due to non-optimality of register allocation.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">This is something we should probably look at. If you have the output lying around, maybe file a PR about it?</div>
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>I'll have another, closer look to be more sure about what the root cause is, and file a PR if it looks like a good case to help improve the register allocator.</div>
<div><br class="">
</div>
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote">
<div class=""><br class="">
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div class="gmail_msg" style="word-wrap: break-word;">
<div class="gmail_msg">
<div class="gmail_msg">The third chart below just zooms in on the above chart to the -5% to 5% performance improvement range:<br class="">
</div>
<div class="gmail_msg"><span id="cid:15a4855865b9015c7b73"><unroll_codesize_vs_performance_zoom.png></span></div>
<div class="gmail_msg"><br class="gmail_msg">
</div>
<div class="gmail_msg"><br class="gmail_msg">
</div>
<div class="gmail_msg">Whether to enable the increase in unroll threshold only at O3 or also at O2: I don't have a strong opinion based on the above data.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">FWIW, this data seems to clearly indicate that we don't get performance wins with any consistency when the code size goes up (and thus the change has impact). As a consequence, I pretty strongly suspect that this should be *just* used at O3 at
least for now.</div>
<div class=""><br class="">
</div>
<div class="">I see two further directions for Dehao that make sense here (at least to me):</div>
<div class="">1) I suspect we should investigate *why* the size increases are happening without helping speed. I can imagine some reasons that this would of course happen (cold loops getting unrolled), but especially in light of the oddities you point out above,
I suspect there may be issues where more unrolling is uncovering other problems and if we fix those other problems the shape of things will be different. We should at least address the issues you uncovered above.</div>
<div class=""><br class="">
</div>
<div class="">2) If this turns out to be architecture specific (it seems that way at least initially, but hard to tell for sure with different benchmark sets) we might make AArch64 and x86 use different thresholds here. I'm skeptical about this though. I suspect
we should do #1, and we'll either get a different shape, or just decide that O3 is more appropriate.</div>
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>Agreed. FWIW, I haven't spotted any results that suggested to me that the unrolling threshold should be different between different architectures.</div>
<div>From a basic principles perspective, I'd assume that micro-architectural features such as the size of the instruction cache should mostly define the unrolling thresholds, rather than instruction set architecture. Which implies different thresholds per
subtarget, rather than per target. Anyway, let's not try to come up with different thresholds per target/subtarget without clear data.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote">
<div class=""> </div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div class="gmail_msg" style="word-wrap: break-word;">
<div class="gmail_msg">
<div class="gmail_msg">Maybe the compile time impact is what should be driving that discussion the most? I'm afraid I don't have compile time numbers.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">FWIW, I strongly suspect that for *this* change, compile time and code size will be pretty precisely correlated. Dehao's data shows that to be true in several cases certainly.</div>
<div class=""> </div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div class="gmail_msg" style="word-wrap: break-word;">
<div class="gmail_msg">
<div class="gmail_msg">Ultimately, I guess this boils down to what exactly the difference is in intent between O2 and O3, which seems like a never-ending discussion...</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">The definitions I am working from are here:</div>
<div class=""><a href="https://github.com/llvm-project/llvm-project/blob/master/llvm/include/llvm/Passes/PassBuilder.h#L81-L90" class="">https://github.com/llvm-project/llvm-project/blob/master/llvm/include/llvm/Passes/PassBuilder.h#L81-L90</a><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">I've highlighted the part that makes me think O3 is better here: the code size increases (and thus compile time increases) don't seem to correspond to runtime improvements.</div>
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>Agreed, only enabling this for O3 seems to be most in line with the definition you pointed at.</div>
<br class="">
</div>
<div>Thanks,</div>
<div><br class="">
</div>
<div>Kristof</div>
<br class="">
</body>
</html>