<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 24, 2017, at 8:55 AM, Sanjay Patel <<a href="mailto:spatel@rotateright.com" class="">spatel@rotateright.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Tue, Jan 24, 2017 at 9:24 AM, Mehdi Amini<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Jan 24, 2017, at 7:18 AM, Sanjay Patel <<a href="mailto:spatel@rotateright.com" target="_blank" class="">spatel@rotateright.com</a>> wrote:</div><br class="m_-1289848491661567520Apple-interchange-newline"><div class=""><br class="m_-1289848491661567520Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;">On Mon, Jan 23, 2017 at 10:53 PM, Mehdi Amini<span class="m_-1289848491661567520Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span><span class="m_-1289848491661567520Apple-converted-space"> </span><wbr class="">wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><br class=""><div class=""><span class="m_-1289848491661567520gmail-"><blockquote type="cite" class=""><div class="">On Jan 23, 2017, at 3:48 PM, Sanjay Patel via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="m_-1289848491661567520gmail-m_-7725396102183704639Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class="">All targets are likely affected in some way by the icmp+shl fold introduced with r292492. It's a basic pattern that occurs in lots of code. Did you see any perf wins on your targets with this commit?<br class=""><br class=""></div>Sadly, it is also likely that many (all?) targets are negatively impacted on the particular test (SingleSource/Benchmarks/Shoot<wbr class="">out/sieve) that you have pointed out here because the IR is now decidedly worse.<br class=""><br class="">IMO, we should not revert the commit because it exposed shortcomings in the optimizer. It's an "obvious" fold/canonicalization, and the related 'nuw' variant of this fold has existed in trunk since:<br class=""><a href="https://reviews.llvm.org/rL285729" target="_blank" class="">https://reviews.llvm.org/rL285<wbr class="">729</a><br class=""><br class=""></div>We need to dissect what analysis/folds are missing to restore the IR to the better form that existed before, but this is probably going to be a long process because we treat min/max like an optimization fence.<span class="m_-1289848491661567520Apple-converted-space"> </span><br class=""></div></div></blockquote><div class=""><br class=""></div></span><div class="">If this is gonna be a long process to recover, this looks like something to be reverted in the 4.0 branch (unless I missed that there is a correctness fix involved?).</div><div class=""><br class=""></div></div></div></blockquote><div class=""><br class=""></div><div class="">Nope - this is just about perf, not correctness. Of course, the intent was that this transform should only improve perf, so I wonder if we can pin any other perf changes from this commit.<br class=""><br class="">I'm new to using the LNT site, but this should be the full set of results for the A53 machine in question with a baseline (r292491) before this patch and current (r292522) :<br class=""><a href="http://llvm.org/perf/db_default/v4/nts/107364" target="_blank" class="">http://llvm.org/perf/db_<wbr class="">default/v4/nts/107364</a><br class=""><br class="">If these are reliable results, we have 2 perf wins (puzzle, gramschmidt) on the A53 machine. How do we determine the importance of the sieve benchmark vs. the rest of the suite?<br class=""><br class=""></div><div class="">An x86 machine doesn't show any regressions from this change:<br class=""><a href="http://llvm.org/perf/db_default/v4/nts/107353" target="_blank" class="">http://llvm.org/perf/db_<wbr class="">default/v4/nts/107353</a><br class=""></div><div class=""><br class="">Are there target-scope-based guidelines for when something is bad enough to revert?<br class=""></div></div></div></blockquote><div class=""><br class=""></div></span><div class="">I don’t think we have any guidelines.</div><div class=""><br class=""></div><div class="">I think my suggestion was more about other regression that we would discover after the release, it was more of a “maturity” call: if we just notice a problem with the commit right before the release, it may not have been in tree long enough to get enough scrutiny.</div></div></div></blockquote><div class=""><br class=""></div><div class="">That makes sense. I have no stake in any particular branch, so I have no objection to revert from the release branch if that's what people would like to do. </div></div></div></blockquote><div><br class=""></div><div>+Hans for advising on what to on clang-4.0.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">My preference is to keep it in trunk though because it should be a win in theory and reverting there would make it harder to find and debug problems like this one.<br class=""></div></div></div></blockquote><div><br class=""></div>Right, trunk seems fine to me at this point.</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""><div><br class=""></div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""><br class=""><br class=""><br class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><div class=""><div class=""><br class=""></div><div class="">(Also I thought this thread included a compile time regression, which on re-read it doesn’t).</div><div class=""><br class=""></div><div class="">— </div><span class="HOEnZb"><font color="#888888" class=""><div class="">Mehdi</div></font></span><div class=""><div class="h5"><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><div class=""><br class="">Also, we've absolutely destroyed perf (-48%) on the sieve benchmark on that A53 target since the baseline (r256803). There are multiple things to fix before we can truly recover?<br class=""><br class="">Regardless of whether we revert or not, I am looking at how to clawback the IR from the r292492 regression. Here's one step towards that:<br class=""><a href="https://reviews.llvm.org/D29053" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D29053</a><br class=""></div><div class=""><br class=""></div><div class="">If we get lucky, we may be able to sidestep the min/max problem by folding harder before we reach that point in the optimization pipeline.<br class=""></div><div class=""><br class=""><br class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><div class=""><div class=""></div><div class="">— </div><span class="m_-1289848491661567520gmail-HOEnZb"><font color="#888888" class=""><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""></div><br class=""></font></span><blockquote type="cite" class=""><div class=""><div class=""><div class="m_-1289848491661567520gmail-h5"><div dir="ltr" class=""><br class=""><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Jan 23, 2017 at 11:13 AM, Evgeny Astigeevich<span class="m_-1289848491661567520Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank" class="">Evgeny.<wbr class="">Astigeevich@arm.com</a>></span><span class="m_-1289848491661567520Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div lang="EN-US" class=""><div class="m_-1289848491661567520gmail-m_-7725396102183704639m_5791940775744498920WordSection1"><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Confirm there is no change in IR if the hack is disabled in the sources.<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">David wrote that these instructions are created by SCEV.<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Are other targets affected by the changes, e.g. X86?<u class=""></u><u class=""></u></span></p><span class=""><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Kind regards,<br class="">Evgeny Astigeevich<br class="">Senior Compiler Engineer<br class="">Compilation Tools<br class="">ARM</span><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><u class=""></u> <u class=""></u></span></p></span><div style="border-width: medium medium medium 1.5pt; border-style: none none none solid; padding: 0cm 0cm 0cm 4pt;" class=""><div class=""><div style="border-width: 1pt medium medium; border-style: solid none none; padding: 3pt 0cm 0cm;" class=""><p class="MsoNormal"><b class=""><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class=""><span class="m_-1289848491661567520Apple-converted-space"> </span>Sanjay Patel [mailto:<a href="mailto:spatel@rotateright.com" target="_blank" class="">spatel@rotateright.com</a><wbr class="">]<span class="m_-1289848491661567520Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Sunday, January 22, 2017 10:45 PM</span></p><div class=""><div class="m_-1289848491661567520gmail-m_-7725396102183704639h5"><br class=""><b class="">To:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Evgeny Astigeevich<br class=""><b class="">Cc:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>llvm-dev; nd<br class=""><b class="">Subject:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Re: [InstCombine] rL292492 affected LoopVectorizer and caused 17.30%/11.37% perf regressions on Cortex-A53/Cortex-A15 LNT machines<u class=""></u><u class=""></u></div></div><div class=""><br class="m_-1289848491661567520gmail-m_-7725396102183704639webkit-block-placeholder"></div></div></div><div class=""><div class="m_-1289848491661567520gmail-m_-7725396102183704639h5"><p class="MsoNormal"><u class=""></u> <u class=""></u></p><div class=""><p class="MsoNormal">I tried an experiment to remove the integer min/max bailouts from InstCombine, and it doesn't appear to change the IR in the attachment, so I doubt there's going to be any improvement.<br class=""><br class="">If I haven't messed up this example, this is amazing:<br class=""><a href="https://godbolt.org/g/yzoxeY" target="_blank" class="">https://godbolt.org/g/yzoxeY</a><u class=""></u><u class=""></u></p></div><div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p><div class=""><p class="MsoNormal">On Sun, Jan 22, 2017 at 1:06 PM, Evgeny Astigeevich <<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank" class="">Evgeny.Astigeevich@arm.com</a>> wrote:<u class=""></u><u class=""></u></p><div class=""><div class=""><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Thank you for information.</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">I’ll build clang without the hack and re-run the benchmark tomorrow.</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">-Evgeny</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><div style="border-width: medium medium medium 1.5pt; border-style: none none none solid; padding: 0cm 0cm 0cm 4pt;" class=""><div class=""><div style="border-width: 1pt medium medium; border-style: solid none none; padding: 3pt 0cm 0cm;" class=""><p class="MsoNormal"><b class=""><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class=""><span class="m_-1289848491661567520Apple-converted-space"> </span>Sanjay Patel [mailto:<a href="mailto:spatel@rotateright.com" target="_blank" class="">spatel@rotateright.com</a><wbr class="">]<span class="m_-1289848491661567520Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Sunday, January 22, 2017 8:00 PM<br class=""><b class="">To:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Evgeny Astigeevich<br class=""><b class="">Cc:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>llvm-dev; nd</span><u class=""></u><u class=""></u></p><div class=""><div class=""><p class="MsoNormal"><br class=""><b class="">Subject:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Re: [InstCombine] rL292492 affected LoopVectorizer and caused 17.30%/11.37% perf regressions on Cortex-A53/Cortex-A15 LNT machines<u class=""></u><u class=""></u></p></div></div></div></div><div class=""><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p><div class=""><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">> Do you mean to remove the hack in InstCombiner::visitICmpInst()?</span><u class=""></u><u class=""></u></p><p class="MsoNormal"> <u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Yes. Although (this just came up in D28625 too) we might need to remove multiple versions of that in order to unlock optimization:</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCompares.cpp#L4338" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstCombineComp<wbr class="">ares.cpp#L4338</a></span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCasts.cpp#L470" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstCombineCast<wbr class="">s.cpp#L470</a></span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstructionCombining.cpp#L803" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstructionComb<wbr class="">ining.cpp#L803</a></span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp#L409" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstCombineSimp<wbr class="">lifyDemanded.cpp#L409</a></span><u class=""></u><u class=""></u></p><div class=""><p class="MsoNormal" style="margin-bottom: 12pt;"><br class="">Similar for FP:<br class=""><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCompares.cpp#L4780" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstCombineComp<wbr class="">ares.cpp#L4780</a></span><br class=""><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCasts.cpp#L1376" target="_blank" class="">https://github.com/llvm-mirror<wbr class="">/llvm/blob/master/lib/Transfor<wbr class="">ms/InstCombine/InstCombineCast<wbr class="">s.cpp#L1376</a></span><u class=""></u><u class=""></u></p></div><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p><div class=""><p class="MsoNormal">On Sun, Jan 22, 2017 at 12:40 PM, Evgeny Astigeevich <<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank" class="">Evgeny.Astigeevich@arm.com</a>> wrote:<u class=""></u><u class=""></u></p><div class=""><div class=""><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Hi Sanjay,</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">The benchmark source file:<span class="m_-1289848491661567520Apple-converted-space"> </span><a href="http://www.llvm.org/viewvc/llvm-project/test-suite/trunk/SingleSource/Benchmarks/Shootout/sieve.c?view=markup" target="_blank" class="">http://www.llvm.org/<wbr class="">viewvc/llvm-project/test-<wbr class="">suite/trunk/SingleSource/<wbr class="">Benchmarks/Shootout/sieve.c?<wbr class="">view=markup</a></span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Clang options used to produce the initial IR: clang -DNDEBUG -O3 -DNDEBUG -mcpu=cortex-a53 -fomit-frame-pointer -O3 -DNDEBUG -w -Werror=date-time -c sieve.c -S -emit-llvm -mllvm -disable-llvm-optzns --target=aarch64-arm-linux</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Opt options: opt -O3 -o /dev/null -print-before-all -print-after-all sieve.ll >& sieve.log</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">I used the IR (in attached sieve.zip) created with the r292487 version.</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">The attached sieve contains the output of ‘-print-before-all -print-after-all’ for r292487 and rL292492.</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">><span class="m_-1289848491661567520Apple-converted-space"> </span></span>If it's possible, can you remove that check locally, rebuild,<u class=""></u><u class=""></u></p><p class="MsoNormal">> and try the benchmark again on your system? I'd love to know<u class=""></u><u class=""></u></p><p class="MsoNormal">> if that change alone would solve the problem.<u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Do you mean to remove the hack in InstCombiner::visitICmpInst()?</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><p class="MsoNormal" style="margin-bottom: 12pt;"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class="">Kind regards,<br class="">Evgeny Astigeevich<br class="">Senior Compiler Engineer<br class="">Compilation Tools<br class="">ARM</span><u class=""></u><u class=""></u></p><p class="MsoNormal"><span style="font-size: 11pt; font-family: calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><u class=""></u><u class=""></u></p><div style="border-width: medium medium medium 1.5pt; border-style: none none none solid; padding: 0cm 0cm 0cm 4pt;" class=""><div class=""><div style="border-width: 1pt medium medium; border-style: solid none none; padding: 3pt 0cm 0cm;" class=""><p class="MsoNormal"><b class=""><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: tahoma, sans-serif;" class=""><span class="m_-1289848491661567520Apple-converted-space"> </span>Sanjay Patel [mailto:<a href="mailto:spatel@rotateright.com" target="_blank" class="">spatel@rotateright.com</a><wbr class="">]<span class="m_-1289848491661567520Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Friday, January 20, 2017 6:16 PM<br class=""><b class="">To:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Evgeny Astigeevich<br class=""><b class="">Cc:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>llvm-dev; Renato Golin;<span class="m_-1289848491661567520Apple-converted-space"> </span><a href="mailto:t.p.northover@gmail.com" target="_blank" class="">t.p.northover@gmail.com</a><wbr class="">;<span class="m_-1289848491661567520Apple-converted-space"> </span><a href="mailto:hfinkel@anl.gov" target="_blank" class="">hfinkel@anl.gov</a><br class=""><b class="">Subject:</b><span class="m_-1289848491661567520Apple-converted-space"> </span>Re: [InstCombine] rL292492 affected LoopVectorizer and caused 17.30%/11.37% perf regressions on Cortex-A53/Cortex-A15 LNT machines</span><u class=""></u><u class=""></u></p></div></div><div class=""><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><p class="MsoNormal">Thanks for letting me know about this problem!<br class=""><br class="">There's no 'shl nsw' visible in the earlier (r292487) code, so it would be better to see exactly what the IR looks like before that added transform fires.<u class=""></u><u class=""></u></p></div><p class="MsoNormal" style="margin-bottom: 12pt;"><br class="">But I see a red flag:<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%smax = select i1 %11, i64 %10, i64 8193<u class=""></u><u class=""></u></p></div><p class="MsoNormal" style="margin-bottom: 12pt;">The new icmp transform allowed us to create an smax, but we have this hack in InstCombiner::visitICmpInst():<br class=""><br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// Test if the ICmpInst instruction is used exclusively by a select as<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// part of a minimum or maximum operation. If so, refrain from doing<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// any other folding. This helps out other analyses which understand<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// non-obfuscated minimum and maximum idioms, such as ScalarEvolution<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// and CodeGen. And in this case, at least one of the comparison<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// operands has at least one user besides the compare (the select),<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>// which would often largely negate the benefit of folding anyway.<u class=""></u><u class=""></u></p></div><p class="MsoNormal" style="margin-bottom: 12pt;">...so that prevented folding the icmp into the earlier math.<u class=""></u><u class=""></u></p></div><p class="MsoNormal">I am actively working on trying to get rid of that bail-out by improving min/max value tracking and icmp/select folding. In fact, we might be able to remove it right now, but I don't know the history of that code or what cases it was supposed to help.<u class=""></u><u class=""></u></p></div></div></div><div class=""><div class=""><div class=""><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p></div><div class=""><p class="MsoNormal">If it's possible, can you remove that check locally, rebuild, and try the benchmark again on your system? I'd love to know if that change alone would solve the problem.<u class=""></u><u class=""></u></p></div><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p><div class=""><div class=""><div class=""><div class=""><div class=""><p class="MsoNormal"> <u class=""></u><u class=""></u></p><div class=""><p class="MsoNormal">On Fri, Jan 20, 2017 at 10:11 AM, Evgeny Astigeevich <<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank" class="">Evgeny.Astigeevich@arm.com</a>> wrote:<u class=""></u><u class=""></u></p><p class="MsoNormal" style="margin-bottom: 12pt;">Hi,<br class=""><br class="">We found that today's 17.30%/11.37% performance regressions in LNT SingleSource/Benchmarks/Shooto<wbr class="">ut/sieve on LNT-AArch64-A53-O3__clang_DEV_<wbr class="">_aarch64 and LNT-Thumb2v7-A15-O3__clang_DEV<wbr class="">__thumbv7 (<a href="http://llvm.org/perf/db_default/v4/nts/daily_report/2017/1/20?filter-machine-regex=aarch64%7Carm%7Cthumb%7Cgreen" target="_blank" class="">http://llvm.org/perf/db_defau<wbr class="">lt/v4/nts/daily_report/2017/1/<wbr class="">20?filter-machine-regex=aarch6<wbr class="">4%7Carm%7Cthumb%7Cgreen</a>) are caused by changes [rL292492] in InstCombine:<br class=""><br class=""><a href="https://reviews.llvm.org/D28406" target="_blank" class="">https://reviews.llvm.org/D2840<wbr class="">6</a><span class="m_-1289848491661567520Apple-converted-space"> </span>"[InstCombine] icmp sgt (shl nsw X, C1), C0 --> icmp sgt X, C0 >> C1"<br class=""><br class="">The Loop Vectorizer generates code with more instructions:<br class=""><br class="">==== Loop Vectorizer from rL292492 ====<br class="">for.body5: ; preds = %for.inc16.for.body5_crit_edge<wbr class="">, %for.cond.preheader<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%indvar = phi i64 [ %indvar.next, %for.inc16.for.body5_crit_edge ], [ 0, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%1 = phi i8 [ %.pre, %for.inc16.for.body5_crit_edge ], [ 1, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%count.122 = phi i32 [ %count.2, %for.inc16.for.body5_crit_edge ], [ 0, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%i.119 = phi i64 [ %inc17, %for.inc16.for.body5_crit_edge ], [ 2, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%2 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%3 = shl i64 %indvar, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%4 = add i64 %3, 4<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%5 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%6 = shl i64 %indvar, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%7 = add i64 %6, 4<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%8 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%9 = mul i64 %indvar, 3<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%10 = add i64 %9, 6<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%11 = icmp sgt i64 %10, 8193<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%smax = select i1 %11, i64 %10, i64 8193<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%12 = mul i64 %indvar, -2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%13 = add i64 %12, -5<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%14 = add i64 %smax, %13<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%15 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%16 = udiv i64 %14, %15<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%17 = add i64 %16, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%tobool7 = icmp eq i8 %1, 0<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>br i1 %tobool7, label %for.inc16, label %if.then<br class="">==============================<wbr class="">==<br class=""><br class="">The code generated by the Loop Vectorizer before the changes:<br class=""><br class="">==== Loop Vectorizer from rL292487 ====<br class="">for.body5: ; preds = %for.inc16.for.body5_crit_edge<wbr class="">, %for.cond.preheader<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%indvar = phi i64 [ %indvar.next, %for.inc16.for.body5_crit_edge ], [ 0, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%1 = phi i8 [ %.pre, %for.inc16.for.body5_crit_edge ], [ 1, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%count.122 = phi i32 [ %count.2, %for.inc16.for.body5_crit_edge ], [ 0, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%i.119 = phi i64 [ %inc17, %for.inc16.for.body5_crit_edge ], [ 2, %for.cond.preheader ]<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%2 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%3 = shl i64 %indvar, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%4 = add i64 %3, 4<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%5 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%6 = shl i64 %indvar, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%7 = add i64 %6, 4<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%8 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%9 = mul i64 %indvar, -2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%10 = add i64 %9, 8188<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%11 = add i64 %indvar, 2<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%12 = udiv i64 %10, %11<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%13 = add i64 %12, 1<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>%tobool7 = icmp eq i8 %1, 0<br class=""> <span class="m_-1289848491661567520Apple-converted-space"> </span>br i1 %tobool7, label %for.inc16, label %if.then<br class="">==============================<wbr class="">==<br class=""><br class="">I have not investigated yet why the behaviour of the Vectorizer is changed.<br class=""><br class="">Kind regards,<br class="">Evgeny Astigeevich<br class="">Senior Compiler Engineer<br class="">Compilation Tools<br class="">ARM<u class=""></u><u class=""></u></p></div><p class="MsoNormal"> <u class=""></u><u class=""></u></p></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div><p class="MsoNormal"> <u class=""></u><u class=""></u></p></div></div></div></div></div></div></div></div><p class="MsoNormal"><u class=""></u> <u class=""></u></p></div></div></div></div></div></div></blockquote></div><br class=""></div></div></div><span class="m_-1289848491661567520gmail-">______________________________<wbr class="">_________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-dev</a></span></div></blockquote></div></div></blockquote></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div><br class=""></body></html>