<div dir="ltr">Sure, that's true. I was considering placing thunks from a lot of different origins to the same target. Your example is for different targets. Definitely that's a much harder problem.<div><br></div><div>With 1M offsets this is not going to happen often enough to worry about and perfect optimality is probably not worth trying for.</div><div><br></div><div>It's a different matter if you only have +/-128B offsets! Then it will be extremely common. But at the same time there will be 8000 times fewer possible placements of each thunk, and the range of influence of each decision will be very small, making a dynamic programming approach very fast at finding the optimal solution. A bigger problem is the basic block might be larger than the offset range, in which case you need to modify the BB to put the thunk inline (not actually a thunk any more).</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 7, 2017 at 12:12 AM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Jan 6, 2017 at 12:41 AM, Bruce Hoult via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-7790403900005732185h5">On Fri, Jan 6, 2017 at 6:21 AM, Rui Ueyama via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_-7790403900005732185m_-8474489496312911250gmail-">On Thu, Jan 5, 2017 at 8:15 PM, Peter Smith <span dir="ltr"><<a href="mailto:peter.smith@linaro.org" target="_blank">peter.smith@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hello Rui,<br>
<br>
Thanks for the comments<br>
<br>
- Synthetic sections and rewriting relocations<br>
I think that this would definitely be worth trying. It should remove<br>
the need for thunks to be represented in the core data structures, and<br>
would allow .<br></blockquote><div><br></div></span><div>Creating symbols for thunks would have another benefit: it makes disassembled output easier to read because thunks have names.</div><span class="m_-7790403900005732185m_-8474489496312911250gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
It would also mean that we wouldn't have to associate symbols with<br>
thunks as the relocations would directly target the thunks. ARM<br>
interworking makes reusing thunks more difficult as not every thunk is<br>
compatible with every caller. For example:<br>
ARM B target and Thumb2 B.W target can't reuse the same thunk even if<br>
in range as the branch instruction can't change state.<br>
<br>
I think it is worth an experiment to make the existing implementation<br>
of thunks use synthetic sections and rewriting relocations before<br>
trying to implement range extension thunks.<br>
<br>
- Yes the scan is linear it is essentially:<br>
do<br>
assign addresses to input sections<br>
for each relocation<br>
if (thunk needed)<br>
create thunk or reuse existing one<br>
while (no more thunks added)<br>
<br>
There's quite a lot of complexity that can be added with respect to<br>
the placement of thunks within the output section. For example if<br>
there is a caller with a low address and a caller with a high address,<br>
both might be able to reuse a thunk placed in the middle. I think it<br>
is worth starting simple though.</blockquote><div><br></div></span><div>I agree. I believe that computing the best thunk positions is NP-hard, but the best layout and a layout produced by a naive algorithm wouldn't be that different.</div></div></div></div></blockquote><div><br></div></div></div><div style="font-size:12.8px">Correct conclusion, but there's no way the problem is NP.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Reordering functions (or even individual basic blocks) to minimize the needed thunks is a complex problem.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">But you're not doing that. Once an ordering is selected a simple greedy algorithm is optimal.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">There is no cost difference between a thunk that is right next to the short jump and a thunk that is only juuust within range. So you can find the lowest address jump needing a thunk to a particular target and put the thunk the maximum possible distance after it (after the end of a function, or even after any unconditional branch). Find everything else within range of that thunk and fix it up. Repeat.</div></div></div></div></blockquote><div><br></div></div></div><div>I don't think this analysis is correct. Assume a 1M branch displacement for short jumps. Consider:</div><div><br></div><div>secA: 512K (contains a jump "jumpA" at offset 0 that needs a thunk (it doesn't matter where it needs to jump to, just that it definitely needs a thunk))</div><div>secB: 512K</div><div>secC: 512K (contains a jump "jumpC" at offset 0 that jumps to offset 0 in secA (i.e., just barely in range of a short jump))</div><div><br></div><div>If the thunk for jumpA is placed between secB and secC (as it would be based on your description) it will push the branch at the beginning of secC out of range, forcing another thunk to be needed. In this small example, the thunk for jumpA must be placed before secA in order to avoid needing a thunk for jumpC. In other words, placing thunks can cause you to need even more thunks.</div><div><br></div><div>-- Sean Silva</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Other algorithms will give smaller average displacements to the thunks, but there is no advantage in that. No other algorithm will generate fewer thunks.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">That's assuming all short branches have the same code size and displacement distance.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">If there are multiple branch distances and code sizes (and you have a choice between them at given call sites) then it's still just a simple dynamic programming problem, solvable in linear [1] time by trying each branch size at the first available call site, with a cache of the minimum cost assuming the first 0, 1, 2 .. N call sites have already been covered.</div><div style="font-size:12.8px"><br></div><div><span style="font-size:12.8px">[1] or at least nCallSites * nBranchSizes</span></div><div> </div></div></div></div>
<br></span><span class="">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
<br></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br></font></span></div></div><span class="HOEnZb"><font color="#888888">
<br>--
<br>This message has been scanned for viruses and
<br>dangerous content by
<a href="http://www.mailscanner.info/" target="_blank"><b>MailScanner</b></a>, and is
<br>believed to be clean.
</font></span></blockquote></div><br></div>