<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 12/21/2016 04:40 PM, Mehdi Amini
wrote:<br>
</div>
<blockquote
cite="mid:B053C680-7029-4CEB-AEE9-DB49EF4A3168@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Dec 21, 2016, at 1:57 PM, Hal Finkel via
llvm-dev <<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="moz-cite-prefix" style="font-family: Helvetica;
font-size: 12px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255);"><br
class="Apple-interchange-newline">
On 12/21/2016 03:36 PM, Sanjay Patel via llvm-dev wrote:<br
class="">
</div>
<blockquote
cite="mid:CA+wODiuPt4KSNXZ-6Go8y8QLNti+irhFYf7ySdVbKLH1DO+OeA@mail.gmail.com"
type="cite" style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);" class="">
<div class="">I would have replied to this thread sooner,
but I was busy adding more instcombines. :)</div>
<div class=""><br class="">
</div>
<div class="">The motivation for r289855 is in the commit
msg (I'm out of the office and can't look things up
conveniently). Feel free to revert that and the follow
ups, however, if that patch caused a noticeable
slowdown, then it suggests we have a bigger
problem?...that's a simple matcher (no value tracking
required).</div>
</blockquote>
<br style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class="">I'd recommend against reverting this
until we understand more about the problem. </span></div>
</blockquote>
<div><br class="">
</div>
<div>I tend to agree, but I’d also like that we get better
understanding before 4.0 branches.</div>
<br class="">
<blockquote type="cite" class="">
<div class=""><span style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class="">This is not a critical compile-time
regression, </span></div>
</blockquote>
<div><br class="">
</div>
<div>I didn’t see in this thread a mention about how much alone
this is causing? The regression mentioned by Davide (20%)
seems critical to me.</div>
</div>
</blockquote>
Maybe I misread this. I thought it was much smaller. We should
double-check the data too. If this one commit is responsible for a
20% compile-time regression, that is indeed serious.<br>
<br>
-Hal<br>
<br>
<blockquote
cite="mid:B053C680-7029-4CEB-AEE9-DB49EF4A3168@apple.com"
type="cite">
<div>
<div><br class="">
</div>
<div>— </div>
<div>Mehdi</div>
<div><br class="">
</div>
<br class="">
<blockquote type="cite" class="">
<div class=""><span style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class="">and we don't yet know the cause (it
might just be enabling more down-stream transformations),
or whether there have been any corresponding benefits to
code side, performance, etc. It definitely looks like a
pattern that we should catch.</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<br style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class=""> -Hal</span><br style="font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);" class="">
<br style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<blockquote
cite="mid:CA+wODiuPt4KSNXZ-6Go8y8QLNti+irhFYf7ySdVbKLH1DO+OeA@mail.gmail.com"
type="cite" style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);" class="">
<div class=""><br class="">
<div class="gmail_quote">
<div class="">On Wed, Dec 21, 2016 at 12:12 PM Sean
Silva <<a moz-do-not-send="true"
href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>>
wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px
0px 0.8ex; border-left-width: 1px;
border-left-color: rgb(204, 204, 204);
border-left-style: solid; padding-left: 1ex;">
<div class="gmail_msg">
<div class="gmail_extra gmail_msg">
<div class="gmail_quote gmail_msg">On Wed, Dec
21, 2016 at 8:07 AM, Davide Italiano via
llvm-dev<span class="Apple-converted-space"> </span><span
class="gmail_msg"><<a
moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org"
class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>></span><span
class="Apple-converted-space"> </span>wrote:<br
class="gmail_msg">
<blockquote class="gmail_quote gmail_msg"
style="margin: 0px 0px 0px 0.8ex;
border-left-width: 1px; border-left-style:
solid; border-left-color: rgb(204, 204,
204); padding-left: 1ex;"><span
class="gmail_msg
m_3457995834792049705gmail-">On Mon, Dec
19, 2016 at 4:24 PM, Mikhail Zolotukhin<br
class="gmail_msg">
<br class="">
<br class="">
<<a moz-do-not-send="true"
href="mailto:mzolotukhin@apple.com"
class="gmail_msg" target="_blank">mzolotukhin@apple.com</a>>
wrote:<br class="gmail_msg">
<br class="">
<br class="">
> Hi Davide,<br class="gmail_msg">
<br class="">
<br class="">
><br class="gmail_msg">
<br class="">
<br class="">
> Thanks for the analysis, it's really
interesting! And I'm really glad that we
now put more and more attention at the
compile time!<br class="gmail_msg">
<br class="">
<br class="">
><br class="gmail_msg">
<br class="">
<br class="">
> Just recently I've been looking into
historical compile time data as well, and
have had similar conclusions. The
regressions you've found are probably
caused by:<br class="gmail_msg">
<br class="">
<br class="">
> 1) r289813 and r289855 - new matchers
in InstCombine<br class="gmail_msg">
<br class="">
<br class="">
> 2) r286814 and r288024 - changes in
Inlining cost model<br class="gmail_msg">
<br class="">
<br class="">
><br class="gmail_msg">
<br class="">
<br class="">
<br class="gmail_msg">
<br class="">
<br class="">
</span>Haven't looked at 2) yet, but I can
confirm for 1). Sanjay/Ehsan, can<br
class="gmail_msg">
<br class="">
<br class="">
you please explain what's the motivation
behind the new<br class="gmail_msg">
<br class="">
<br class="">
transformations you introduced? I'm tempted
to ask a revert, but I'd<br
class="gmail_msg">
<br class="">
<br class="">
like to understand the motivations first.<br
class="gmail_msg">
</blockquote>
<div class="gmail_msg"><br class="gmail_msg">
</div>
<div class="gmail_msg"><br class="gmail_msg">
</div>
</div>
</div>
</div>
<div class="gmail_msg">
<div class="gmail_extra gmail_msg">
<div class="gmail_quote gmail_msg">
<div class="gmail_msg">Both r289813
and r289855 add a very small amount of
matching (it seems?) compared to the rest of
the size of instcombine. How is it that
these checks are causing such a
disproportionate slowdown compared to the
rest of instcombine? (by "I can confirm for
1)" I assume you mean these two patches have
a pretty significant impact on compile time;
not "0.1%" each)</div>
</div>
</div>
</div>
<div class="gmail_msg">
<div class="gmail_extra gmail_msg">
<div class="gmail_quote gmail_msg">
<div class="gmail_msg"><br class="gmail_msg">
</div>
<div class="gmail_msg">-- Sean Silva</div>
<div class="gmail_msg"> </div>
</div>
</div>
</div>
<div class="gmail_msg">
<div class="gmail_extra gmail_msg">
<div class="gmail_quote gmail_msg">
<blockquote class="gmail_quote gmail_msg"
style="margin: 0px 0px 0px 0.8ex;
border-left-width: 1px; border-left-style:
solid; border-left-color: rgb(204, 204,
204); padding-left: 1ex;">
<div class=" gmail_msg
m_3457995834792049705gmail-HOEnZb
">
<div class=" gmail_msg
m_3457995834792049705gmail-h5
"><br class="gmail_msg">
<br class="">
<br class="">
--<br class="gmail_msg">
<br class="">
<br class="">
Davide<br class="gmail_msg">
<br class="">
<br class="">
<br class="gmail_msg">
<br class="">
<br class="">
"There are no solved problems; there are
only problems that are more<br
class="gmail_msg">
<br class="">
<br class="">
or less solved" -- Henri Poincare<br
class="gmail_msg">
</div>
</div>
</blockquote>
</div>
</div>
</div>
<div class="gmail_msg">
<div class="gmail_extra gmail_msg">
<div class="gmail_quote gmail_msg">
<blockquote class="gmail_quote gmail_msg"
style="margin: 0px 0px 0px 0.8ex;
border-left-width: 1px; border-left-style:
solid; border-left-color: rgb(204, 204,
204); padding-left: 1ex;">
<div class=" gmail_msg
m_3457995834792049705gmail-HOEnZb
">
<div class=" gmail_msg
m_3457995834792049705gmail-h5
"><br class="">
<br class="">
_______________________________________________<br class="gmail_msg">
<br class="">
<br class="">
LLVM Developers mailing list<br
class="gmail_msg">
<br class="">
<br class="">
<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org"
class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br
class="gmail_msg">
<br class="">
<br class="">
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" class="gmail_msg"
target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br
class="gmail_msg">
<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre class="" wrap="">_______________________________________________
LLVM Developers mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<pre class="moz-signature" cols="72" style="font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class="">_______________________________________________</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255); float: none; display: inline
!important;" class="">LLVM Developers mailing list</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org" style="font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255);" class="">llvm-dev@lists.llvm.org</a><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>