<div dir="ltr">I guess adding section "Debugging" at the bottom of programmers manual would sounds like a good plan to me.<div><br></div><div>Piotr</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-12-20 6:03 GMT+01:00 David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Good point - any ideas on where in the programmer's manual would suit best? Looking around I sort of feel like it belongs in the "Picking the right data structure" section - but I fear someone merely examining existing data structures might not think to look there for help in their task (if they have no need to 'pick' a data structure for a new use, etc).<br></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 19, 2016 at 2:47 AM Piotr Padlewski <<a href="mailto:piotr.padlewski@gmail.com" target="_blank">piotr.padlewski@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_-3495430350676290975gmail_msg">Excellent. I think it would make sense to add small section somewhere in documentation (e.g. <span class="m_-3495430350676290975m_-831224463331190621gmail-doc m_-3495430350676290975gmail_msg" style="color:rgb(202,121,0);text-decoration:none;font-family:"lucida grande","lucida sans unicode",geneva,verdana,sans-serif;font-size:14px"><a class="m_-3495430350676290975m_-831224463331190621gmail-reference m_-3495430350676290975m_-831224463331190621gmail-internal m_-3495430350676290975gmail_msg" href="http://llvm.org/docs/ProgrammersManual.html" style="color:rgb(202,121,0);text-decoration:none;font-family:"lucida grande","lucida sans unicode",geneva,verdana,sans-serif;font-size:14px" target="_blank">LLVM Programmer’s Manual</a></span>) about it, so it won't be lost somewhere in the mailing list.<div class="m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975gmail_msg"></div><div class="m_-3495430350676290975gmail_msg">Piotr</div></div><div class="gmail_extra m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975gmail_msg"><div class="gmail_quote m_-3495430350676290975gmail_msg"></div></div><div class="gmail_extra m_-3495430350676290975gmail_msg"><div class="gmail_quote m_-3495430350676290975gmail_msg">2016-12-17 1:04 GMT+01:00 David Blaikie via llvm-dev <span dir="ltr" class="m_-3495430350676290975gmail_msg"><<a href="mailto:llvm-dev@lists.llvm.org" class="m_-3495430350676290975gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>></span>:<br class="m_-3495430350676290975gmail_msg"></div></div><div class="gmail_extra m_-3495430350676290975gmail_msg"><div class="gmail_quote m_-3495430350676290975gmail_msg"><blockquote class="gmail_quote m_-3495430350676290975gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_-3495430350676290975gmail_msg">Added some basic DenseMap support in r290011</div><div class="m_-3495430350676290975m_-831224463331190621HOEnZb m_-3495430350676290975gmail_msg"><div class="m_-3495430350676290975m_-831224463331190621h5 m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975gmail_msg"><div class="gmail_quote m_-3495430350676290975gmail_msg"><div dir="ltr" class="m_-3495430350676290975gmail_msg">On Fri, Dec 16, 2016 at 2:05 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" class="m_-3495430350676290975gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:<br class="m_-3495430350676290975gmail_msg"></div><blockquote class="gmail_quote m_-3495430350676290975gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">I've added a few LLVM GDB pretty printers a while back (& just added llvm::Optional earlier today) & thought people might be interested in how to use them, etc.<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">I use them by adding the following to my .gdbinit:<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> source /path/to/llvm/src/utils/gdb-<wbr>scripts/prettyprinters.py</font><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">Also, I can suggest adding:<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> set print pretty on</font><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">there too, it helps a lot when printing complex nested data structures.<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">Once you have that, you can get pretty output like this:<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">(gdb) p Abbrev->AbbrDeclSets</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">$1 = std::map with 1 elements = {</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> [0] = {</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Offset = 0,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> FirstAbbrCode = 1,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Decls = std::vector of length 1, capacity 1 = {{</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Code = 1,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Tag = llvm::dwarf::Tag::DW_TAG_<wbr>compile_unit,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> CodeByteSize = 1 '\001',</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> HasChildren = false,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> AttributeSpecs = llvm::SmallVector of length 8, capacity 8 = {{</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Attr = llvm::dwarf::Attribute::DW_AT_<wbr>low_pc,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Form = llvm::dwarf::Form::DW_FORM_<wbr>addr,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> ByteSize = llvm::Optional is not initialized</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> }, {</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Attr = llvm::dwarf::Attribute::DW_AT_<wbr>high_pc,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> Form = llvm::dwarf::Form::DW_FORM_<wbr>data8,</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> ByteSize = llvm::Optional is initialized = {</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> value = 8 '\b'</font></div><div class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><font face="monospace" class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"> }</font><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">Here you can see the pretty printers for SmallVector and Optional, but there's also support for StringRef, SmallString, and ArrayRef.<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">I've tried doing a DenseMap pretty printer, but haven't quite figured it out yet (having trouble calling member functions to do some of teh more complicated parts of DenseMap iteration - may end up printing it with the tombstone/empty values present, but not sure how easy that'll be to read, etc). Happy to take requests or talk people through adding more pretty printers anyone wants to add :)<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg"><br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">Enjoy!<br class="m_-3495430350676290975m_-831224463331190621m_-6775797877069835748gmail_msg m_-3495430350676290975gmail_msg">- Dave</div></div></blockquote></div>
</div></div><br class="m_-3495430350676290975gmail_msg"></blockquote></div></div><div class="gmail_extra m_-3495430350676290975gmail_msg"><div class="gmail_quote m_-3495430350676290975gmail_msg"><blockquote class="gmail_quote m_-3495430350676290975gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">______________________________<wbr>_________________<br class="m_-3495430350676290975gmail_msg">
LLVM Developers mailing list<br class="m_-3495430350676290975gmail_msg">
<a href="mailto:llvm-dev@lists.llvm.org" class="m_-3495430350676290975gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="m_-3495430350676290975gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="m_-3495430350676290975gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br class="m_-3495430350676290975gmail_msg">
<br class="m_-3495430350676290975gmail_msg"></blockquote></div><br class="m_-3495430350676290975gmail_msg"></div>
</blockquote></div>
</div></div></blockquote></div><br></div>