<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 15, 2016 at 4:20 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Thu, Dec 15, 2016 at 4:17 PM Teresa Johnson <<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg">On Thu, Dec 15, 2016 at 2:08 PM, David Blaikie <span dir="ltr" class="m_8964137858405424454gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="m_8964137858405424454gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="m_8964137858405424454gmail_msg"><blockquote class="gmail_quote m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279h5 m_8964137858405424454gmail_msg"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">On Thu, Dec 15, 2016 at 1:30 PM Teresa Johnson <<a href="mailto:tejohnson@google.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">tejohnson@google.com</a>> wrote:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">On Thu, Dec 15, 2016 at 11:38 AM, David Blaikie <span dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><span class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">On Thu, Dec 15, 2016 at 11:26 AM Teresa Johnson <<a href="mailto:tejohnson@google.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">tejohnson@google.com</a>> wrote:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Trying to wrap my brain around this, so a few questions below. =)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></blockquote></span><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Sure thing - sorry, did assume a bit too much arcane context here.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954h5 m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">On Thu, Dec 15, 2016 at 10:54 AM, David Blaikie <span dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Branching off from a discussion of improvements to DIGlobalVariable representations that Adrian's working on - got me thinking about related changes that have already been made to DISubprogram.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">To reduce duplicate debug info when things like linkonce_odr functions were deduplicated in LTO linking, the relationship between a CU and DISubprogram was inverted (instead of a CU maintaining a list of subprograms, subprograms specify which CU they come from - and the llvm::Function references the DISubprogram, so if the llvm::Function goes away, so does the associated DISubprogram)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">I'm not sure if this caused a regression, but at least seems to miss a possible improvement:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">During IR linking (for LTO, ThinLTO, etc) these distinct DISubprogram definitions (& their CU link, even if they weren't marked 'distinct', the CU link would cause them to effectively be so) remain separate - this means that inlined versions in one CU don't refer to an existing subprogram definition in another CU.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">To demonstrate:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">inl.h:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">void f1();</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">inline __attribute__((always_inline)) void f2() {</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> f1();</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">}<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">inl1.cpp:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">#include "inl.h"</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">void c1() {</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> f2();</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">}<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">inl2.cpp:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">#include "inl.h"</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">void c2() {</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> f2();</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">}<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Compile to IR, llvm-link the result. The DWARF you get is basically the same as the DWARF you'd get without linking:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">DW_TAG_compile_unit<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "inl1.cpp"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram #0<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "f2"</div></div></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "c1"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_inlined_subroutine<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_abstract_origin #0 "f2"<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">DW_TAG_compile_unit<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "inl2.cpp"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram #1<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "f2"</div></div></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "c2"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_inlined_subroutine<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_abstract_origin #1 "f2"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Instead of something more like this:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">DW_TAG_compile_unit<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "inl1.cpp"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram #0<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "f2"</div></div></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "c1"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_inlined_subroutine<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_abstract_origin #0 "f2"<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">DW_TAG_compile_unit<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "inl2.cpp"</div></div></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_subprogram<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_AT_name "c2"<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_inlined_subroutine<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> DW_TAG_abstract_origin #0 "f2"</div></div></div><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479m_-3681109979486123769m_-6809783484898340448inbox-inbox-Apple-interchange-newline m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div>(note that only one abstract definition of f2 is produced here)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">I think I understand what you are saying. Essentially, having the SP->CU link allows the SP to be deduplicated when multiple *outline* copies of the corresponding function are deduplicated. But not when the multiple copies are inlined, as it looks like we need all the copies, right?</div></div></div></div></blockquote></div></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Not quite - having the SP->CU link (well,h onestly, marking the SP as "distinct" does this, but even if we didn't do that, the SP->CU link would still do it) causes SPs /not/ to be deduplicated on IR linking.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Each SP is distinct/not considered duplicate with any other. (if we didn't mark it 'distinct', the fact that each SP refers to its corresponding CU would produce the same effect - they wouldn't be deduplicated because they aren't identical - they refer to different CUs)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">For non-inlined cases, this is fine.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Before we inverted the SP<>CU link, what would happen is that all copies of the llvm::Function would be dropped, but their SPs would be left around. So two CUs that both used the same linkonce_odr function (let's say no inlining actually occurred though) would both have a SP description in the DWARF - but one would actual have a proper definition (with a high/low PC, etc) the other would be missing those features, as though the function had been optimized away (which it sort of had)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">So by reversing the link, we got rid of those extra SP descriptions in the DWARF (and the extra SP descriptions in the metadata - I think they were duplicate back then because they still had a scope chain leading back to their CU (maybe we had gotten rid of that chain - if we had, then adding it back in may've actually caused more metadata, but less DWARF))<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">I almost followed all of this, until I got to this last bit. I understood from above that with the SP->CU link (and distinct SPs), prevented deduplication. But this last bit sounds like we are in fact removing the duplicates in the DWARF and possibly also in the metadata. </div></div></div></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Ah, right - I can see how it reads that way, sorry.<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Old old way:<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">first.ll:<br class="m_8964137858405424454gmail_msg"> CU1 -> {fn1_SP -> @fn1, inl_SP -> @inl, ... }</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @fn1 ...<br class="m_8964137858405424454gmail_msg"> @inl ...<br class="m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU1</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> subprogram fn1<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> <br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">second.ll:<br class="m_8964137858405424454gmail_msg"> CU2 -> {inl_SP2 -> @inl, SP2 -> @fn2, ... }</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @inl ...<br class="m_8964137858405424454gmail_msg"> @fn2 ...<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU2</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram fn2<br class="m_8964137858405424454gmail_msg"> high/low pc, etc</div><br class="m_8964137858405424454gmail_msg">link first.ll + second.ll:<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> CU1 -> {fn1_SP -> @fn1, inl_SP -> @inl, ... }</div> CU2 -> {inl_SP2 -> null, SP2 -> @fn2, ... }<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @fn1 ...<br class="m_8964137858405424454gmail_msg"> @inl ...<br class="m_8964137858405424454gmail_msg"> @fn2 ...<br class="m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU1<br class="m_8964137858405424454gmail_msg"> subprogram fn1<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> compile_unit CU2<br class="m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> name, but no high/low pc - this is unnecessary<br class="m_8964137858405424454gmail_msg"> subprogram fn2<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> </div>New way:<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> CU1</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @fn1 -> fn1_SP -> CU1<br class="m_8964137858405424454gmail_msg"> @inl -> inl_SP -> CU1<br class="m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU1</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> subprogram fn1<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> <br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">second.ll:<br class="m_8964137858405424454gmail_msg"> CU2</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @inl -> inl_SP -> CU2<br class="m_8964137858405424454gmail_msg"> @fn2 -> fn2_SP -> CU2<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU2</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram fn2<br class="m_8964137858405424454gmail_msg"> high/low pc, etc</div><br class="m_8964137858405424454gmail_msg">link first.ll + second.ll (we pick @inl from first.ll in this example):<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> CU1</div> CU2<div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> @fn1 -> fn1_SP -> CU1<br class="m_8964137858405424454gmail_msg"> @inl -> inl_SP -> CU1<br class="m_8964137858405424454gmail_msg"> @fn2 -> fn2_SP -> CU2<br class="m_8964137858405424454gmail_msg"> Resulting DWARF:<br class="m_8964137858405424454gmail_msg"> compile_unit CU1<br class="m_8964137858405424454gmail_msg"> subprogram fn1<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> subprogram inl<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"> compile_unit CU2<br class="m_8964137858405424454gmail_msg"> subprogram fn2<br class="m_8964137858405424454gmail_msg"> high/low pc, etc<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">So inverting the links causes us to completely drop the redundant description of 'inl' that appeared in C2 when the function was not inlined.<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">But if the function /is/ inlined, then the inlined location descriptions that remain in @fn2 (assuming there was a call to @inl in @fn1 and @fn2) still point to that original (CU2) version of @inl - causing it to to be emitted into CU2.<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">Whereas for type descriptions we don't do this - the type has no CU link, so they all get deduplicated and even if @fn2 has a parameter of the same type as @fn1 - we emit the type into CU1 when we first encounter it (when emitting @fn1) and then reference it whenever we need it, even when emitting @fn2 in the other CU.</div></div></div></div></div></div></blockquote><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg">Ok, great, thanks for the detailed explanation! I was missing the distinction between the location descriptions and the type descriptions.</div></div></div></div><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div><blockquote class="gmail_quote m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454gmail_msg"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><span class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><span class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Any thoughts? I imagine this is probably worth a reasonable amount of savings in an optimized build. Not huge, but not nothing. (probably not the top of anyone's list though, I realize)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Should we remove the CU link from a non-internal linkage subprogram (& this may have an effect on the GV representation issue originally being discussed) and just emit it into whichever CU happens to need it first?<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">I can see how this would be done in LTO where the compiler has full visibility. For ThinLTO presumably we would need to do some index-based marking? Can we at least do something when we import an inlined SP and drop it since we know it is defined elsewhere?</div></div></div></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></span><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Complete visibility isn't required to benefit here - and unfortunately there's nothing fancier (that I know of) that we can do to avoid emitting one definition of each used inline function in each thinlto object file we produce (we can't say "oh, the name of the function, its mangled name, the names and types of its parameters are over in that other object file/somewhere else" - but we can avoid emitting those descriptions in each /CU/ that uses the inlined function within a single ThinLTO object)<br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">I can provide some more thorough examples if that'd be helpful :)</div></div></div></blockquote><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Ok, I think I understand. This is only emitting once per object file, which with ThinLTO can contain multiple CUs due to importing. But then with full LTO it sounds like we would be in even better shape, since it has a single module with all the CUs?</div></div></div></div></blockquote><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div></span><div class="m_8964137858405424454gmail_msg">Right - currently we emit once per CU, but with a change in format we could emit once per object file - which hurts ThinLTO over non-LTO (because ThinLTO produces more CUs (due to imports) per object file) and is neutral for full LTO (since it produces the same number of CUs, just in one object file).<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">Improving this representation to produce once per object would help get ThinLTO back what it's currently paying - and improve full LTO further than its current position in this regard.<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">But the gains might not be major/significant - I've done nothing to assess that, just observing that it is suboptimal.<br class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">Thanks for asking/helping me explain it further, hopefully this is more descriptive.<br class="m_8964137858405424454gmail_msg"></div></div></div></div></blockquote><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div></div></div></div><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg">Great, thanks for pointing out this opportunity! When I get a chance probably tomorrow I will give your prototype patch a try and see how much difference it makes for Chromium.</div></div></div></div></blockquote><div><br></div></div></div><div>Ah - the patch fixes the backend/LLVM to cope with this representational change (at least for the one tiny example) but doesn't fix Clang to produce the new representation (I just hand hacked the IR in a simple example to see if it worked). I could work with you/work up a change that might do that too, if that's handy/worth testing.<br></div></div></div></blockquote><div><br></div><div>Oh, right. Maybe I can get an idea of how much this would save. Is there a decent heuristic to measure the redundancy?</div><div>Teresa</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br>- Dave</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div><div class="m_8964137858405424454gmail_msg">Teresa</div></div></div></div><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454gmail_msg"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg">- Dave</div><span class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Teresa</div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><span class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> </div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Thanks,</div><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Teresa</div></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> <br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div><blockquote class="gmail_quote m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">This might be slightly sub-optimal, due to, say, the namespace being foreign to that CU. But it's how we do types currently, I think? So at least it'd be consistent and probably cheap enough/better.</div>
</blockquote></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br clear="all" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div>-- <br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479m_-3681109979486123769gmail_signature m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><table cellspacing="0" cellpadding="0" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><tbody class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> <a href="mailto:tejohnson@google.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> <a href="tel:(408)%20460-2413" value="+14084602413" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954m_6355813536556678479gmail_msg m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</div></div></blockquote></span></div></div>
</blockquote></div></div></div><div dir="ltr" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br clear="all" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"></div>-- <br class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332m_4534768799203844959m_4882500400511852954gmail_signature m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><table cellspacing="0" cellpadding="0" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><tbody class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> <a href="mailto:tejohnson@google.com" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg"> <a href="tel:(408)%20460-2413" value="+14084602413" class="m_8964137858405424454m_-6537548415675867279m_-1913449416215716332gmail_msg m_8964137858405424454gmail_msg" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</div></div></blockquote></span></div></div></div>
</blockquote></div></div></div><div dir="ltr" class="m_8964137858405424454gmail_msg"><div class="gmail_extra m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"><br clear="all" class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454gmail_msg"><br class="m_8964137858405424454gmail_msg"></div>-- <br class="m_8964137858405424454gmail_msg"><div class="m_8964137858405424454m_-6537548415675867279gmail_signature m_8964137858405424454gmail_msg" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium" class="m_8964137858405424454gmail_msg"><table cellspacing="0" cellpadding="0" class="m_8964137858405424454gmail_msg"><tbody class="m_8964137858405424454gmail_msg"><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small" class="m_8964137858405424454gmail_msg"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px" class="m_8964137858405424454gmail_msg">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px" class="m_8964137858405424454gmail_msg"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px" class="m_8964137858405424454gmail_msg"> <a href="mailto:tejohnson@google.com" class="m_8964137858405424454gmail_msg" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px" class="m_8964137858405424454gmail_msg"> <a href="tel:(408)%20460-2413" value="+14084602413" class="m_8964137858405424454gmail_msg" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</div></div></blockquote></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>