<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 8, 2016 at 10:37 AM, Robinson, Paul <span dir="ltr"><<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_7598168187548853749WordSection1"><span class="">
<p class="MsoNormal" style="margin-left:.5in">If the sanitizers already rely on the debug info line table, which<br>
already has a file table, why can't frame layout descriptions use<br>
that as well?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">the frame layout descriptions contain names of the local variables, which are not part of line tables.<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><a name="m_7598168187548853749__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Sorry, I was not clear, but I was actually responding to this statement:<u></u><u></u></span></a></p><span class="">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal">> Frame layout<br>
> descriptions encode line numbers for local variable declarations. They<br>
> don't include file names to keep object size under control, and we<br>
> can't really afford to add more duplicate debug info.<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This suggests that omitting file info from frame layout descriptions is a problem. But surely whoever is reading the descriptions can get file info from the
line table, so there is no need to duplicate that info—in short, why is this a problem in frame layouts?</span></p></div></div></blockquote><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_7598168187548853749WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I assume you build your own frame layout descriptions because you want to work with –gmlt info instead of requiring full –g info? If you have full –g then
the variable info is in the .debug_info section already.</span></p></div></div></blockquote><div><br></div><div>Yes. Most of the *big* asan users can't use -g due to enormous code size and thus fall back to -gmlt. </div><div>So, asan should work well with gmlt</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_7598168187548853749WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Kostya Serebryany [mailto:<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>]
<br>
<b>Sent:</b> Thursday, December 08, 2016 9:35 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> Evgenii Stepanov; <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><span class=""><br>
<b>Subject:</b> Re: [llvm-dev] Debug Locations for Optimized Code<u></u><u></u></span></span></p>
</div>
</div><span class="">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, Dec 7, 2016 at 5:49 PM, Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal"><br>
<br>
> -----Original Message-----<br>
> From: Evgenii Stepanov [mailto:<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.<wbr>com</a>]<br>
> Sent: Wednesday, December 07, 2016 4:51 PM<br>
> To: Kostya Serebryany<br>
> Cc: Robinson, Paul; <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> Subject: Re: [llvm-dev] Debug Locations for Optimized Code<br>
><br>
> In fact, we are already using "parallel" debug info. Frame layout<br>
> descriptions encode line numbers for local variable declarations. They<br>
> don't include file names to keep object size under control, and we<br>
> can't really afford to add more duplicate debug info.<br>
><br>
> On Wed, Dec 7, 2016 at 1:44 PM, Kostya Serebryany via llvm-dev<br>
> <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
> > my 2c.<br>
> ><br>
> > the sanitizers rely on debug info to produce human-readable error<br>
> messages,<br>
<br>
If the sanitizers already rely on the debug info line table, which<br>
already has a file table, why can't frame layout descriptions use<br>
that as well?<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">the frame layout descriptions contain names of the local variables, which are not part of line tables.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">--paulr<u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</span></div>
</div>
</div>
</blockquote></div><br></div></div>