<div dir="ltr">Awesome. Thanks so much for doing this.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 11, 2016 at 2:40 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">For the record, this feature is implemented in r286496 (<span style="color:rgb(0,0,0)"><a href="https://reviews.llvm.org/D26487" target="_blank">https://reviews.llvm.org/D264<wbr>87</a>)</span>. Now the LLD version string is embedded to output's .comment section. You can use objdump to see it.<br><div><br></div><div><font face="monospace, monospace"> $ objdump -s -j .comment foo<br></font></div><div><div><font face="monospace, monospace"><br></font></div><div><font face="monospace, monospace"> foo: file format elf64-x86-64</font></div><div><font face="monospace, monospace"><br></font></div><div><font face="monospace, monospace"> Contents of section .comment:</font></div><div><font face="monospace, monospace"> 0000 00474343 3a202855 62756e74 7520342e .GCC: (Ubuntu 4.</font></div><div><font face="monospace, monospace"> 0010 382e342d 32756275 6e747531 7e31342e 8.4-2ubuntu1~14.</font></div><div><font face="monospace, monospace"> ...</font></div><div><font face="monospace, monospace"> 00c0 766d2f74 72756e6b 20323835 38343629 vm/trunk 285846)</font></div><div><font face="monospace, monospace"> 00d0 004c696e 6b65723a 204c4c44 20342e30 .Linker: LLD 4.0</font></div><div><font face="monospace, monospace"> 00e0 2e302028 7472756e 6b203238 36343036 .0 (trunk 286406</font></div><div><font face="monospace, monospace"> 00f0 2900 ).</font></div></div><div><div class="h5"><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 29, 2016 at 12:50 AM, Sean Silva via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 26, 2016 at 4:16 AM, Joerg Sonnenberger via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Tue, Oct 25, 2016 at 06:07:09PM -0400, Rafael Espíndola via llvm-dev wrote:<br>
> I am ok with both ".note.linker-version" and adding an entry to .comment.<br>
<br>
</span>There is one important different between the two -- strip normally has<br>
to preserve the former, but not the latter. As such, I'd quite a bit<br>
prefer using .comment.<br></blockquote><div><br></div></span><div>+1 for .comment; we should be consistent with how clang handles .ident, since this is conceptually the same information.</div><div><br></div><div>In fact, during LTO, LLD should probably add an ident entry to any module that it codegens to indicate that it was codegenerated through LLD; but that's a separate discussion.</div><div><br></div><div>-- Sean Silva</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Joerg<br>
<div class="m_8112446728765781691m_4205001339587004105m_463353987744858255HOEnZb"><div class="m_8112446728765781691m_4205001339587004105m_463353987744858255h5">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
</div></div></blockquote></span></div><br></div></div>
<br>______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>