<div dir="ltr">Patch sent: <a href="https://reviews.llvm.org/D26219">https://reviews.llvm.org/D26219</a><div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 1:18 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Awesome!<br>
<br>
Thanks,<br>
Rafael<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On 28 October 2016 at 13:14, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>> wrote:<br>
> And on a separate thread [0] Derek indicated he'd be fine with removing it.<br>
> I'll leave this thread open until end of Monday to receive any other<br>
> opinions, then proceed to remove it.<br>
><br>
> Peter<br>
><br>
> [0]<br>
> <a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20161024/400754.html" rel="noreferrer" target="_blank">http://lists.llvm.org/<wbr>pipermail/llvm-commits/Week-<wbr>of-Mon-20161024/400754.html</a><br>
><br>
> On Fri, Oct 28, 2016 at 10:08 AM, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>><br>
> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> BitstreamReader is the only in-tree client of the DataStreamer and<br>
>> MemoryObject interfaces. In practice when using user-facing LLVM tools, the<br>
>> bitcode will normally either be in memory or in a file, so the best way to<br>
>> access it is through memory, either directly or memory mapped.<br>
>><br>
>> As part of some refactorings I am making to BitstreamReader, I would like<br>
>> to simplify it by changing it to use a memory buffer directly and then<br>
>> removing the DataStreamer and MemoryObject interfaces.<br>
>><br>
>> My understanding that the only significant user of that interface as<br>
>> designed (for network streaming) is PNaCl, however it looks like removing<br>
>> this interface would not impose a significant burden on that project; they<br>
>> are already maintaining a couple of forks of BitstreamReader [1] so it would<br>
>> appear that the only change necessary on their side would be to also fork<br>
>> the interfaces.<br>
>><br>
>> If you are aware of any other significant users, please speak up!<br>
>><br>
>> Thanks,<br>
>> --<br>
>> --<br>
>> Peter<br>
>><br>
>> [1]<br>
>> <a href="https://chromium.googlesource.com/native_client/pnacl-llvm/+/master/include/llvm/Bitcode/NaCl/NaClBitstreamReader.h" rel="noreferrer" target="_blank">https://chromium.googlesource.<wbr>com/native_client/pnacl-llvm/+<wbr>/master/include/llvm/Bitcode/<wbr>NaCl/NaClBitstreamReader.h</a><br>
>> <a href="https://chromium.googlesource.com/native_client/pnacl-subzero/+/master/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitstreamReader.h" rel="noreferrer" target="_blank">https://chromium.googlesource.<wbr>com/native_client/pnacl-<wbr>subzero/+/master/pnacl-llvm/<wbr>include/llvm/Bitcode/NaCl/<wbr>NaClBitstreamReader.h</a><br>
><br>
><br>
><br>
><br>
> --<br>
> --<br>
> Peter<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>