<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: arial,helvetica,sans-serif; font-size: 10pt; color: #000000'><br><hr id="zwchr"><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Ziv via llvm-dev Izhar" <llvm-dev@lists.llvm.org><br><b>To: </b>llvm-dev@lists.llvm.org<br><b>Cc: </b>"Michael Zuckerman" <michael.zuckerman@intel.com><br><b>Sent: </b>Monday, October 31, 2016 3:53:40 AM<br><b>Subject: </b>[llvm-dev] COMPILER-RT build break<br><br>
<style><!--
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
<div class="WordSection1">
<p class="MsoNormal">Hello,</p>
<p class="MsoNormal">There is a problem in the compiler-rt project regarding a new change I need to make.</p>
<p class="MsoNormal">The change is that in extended gcc syntax, when the same register is in the input/output list and in the clobber list, there is a conflict and llvm should produce an error.</p>
<p class="MsoNormal">Until now, it didn’t produce an error.</p>
<p class="MsoNormal">In compiler-rt’s tests, there’s a test which shouldn’t generate an error but after the patch it does. Therefore, we need to correct the test (which is not correct according to extended gcc).</p>
<p class="MsoNormal">The review regarding the new error message is : <a href="https://reviews.llvm.org/D15075" target="_blank">
https://reviews.llvm.org/D15075</a></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span id="DWT954" style="color: rgb(0, 112, 192); background: none repeat scroll 0% 0% yellow;">What is the process in compiler-rt in order to accept and commit that change?</span></p></div></blockquote>We use the same review process for compiler-rt as we use for LLVM itself. I recommend that you upload the patch to reviews.llvm.org, and make sure that you add llvm-commits as a subscriber (along with any other compiler-rt developers that seem relevant).<br><br>Thanks again,<br>Hal<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div class="WordSection1"><p class="MsoNormal"><span style="color: rgb(0, 112, 192); background: none repeat scroll 0% 0% yellow;"></span><span style="color: rgb(0, 112, 192);"></span></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">The change which needed to be made is:</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Index: lib/asan/tests/asan_asm_test.cc
</p>
<p class="MsoNormal">===================================================================
</p>
<p class="MsoNormal">--- lib/asan/tests/asan_asm_test.cc (revision 285517)
</p>
<p class="MsoNormal">+++ lib/asan/tests/asan_asm_test.cc (working copy)
</p>
<p class="MsoNormal">@@ -62,7 +62,7 @@
</p>
<p class="MsoNormal"> __asm__("rep " Movs " \n\t" \</p>
<p class="MsoNormal"> : \</p>
<p class="MsoNormal"> : "D"(dst), "S"(src), "c"(size) \</p>
<p class="MsoNormal">- : "rsi", "rdi", "rcx", "memory"); \</p>
<p class="MsoNormal">+ : "memory"); \</p>
<p class="MsoNormal"> }
</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> DECLARE_ASM_WRITE(U8, "8", "movq", "r"); </p>
<p class="MsoNormal">@@ -104,7 +104,7 @@
</p>
<p class="MsoNormal"> __asm__("rep " Movs " \n\t" \</p>
<p class="MsoNormal"> : \</p>
<p class="MsoNormal"> : "D"(dst), "S"(src), "c"(size) \</p>
<p class="MsoNormal">- : "esi", "edi", "ecx", "memory"); \</p>
<p class="MsoNormal">+ : "memory"); \</p>
<p class="MsoNormal"> }
</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> } // End of anonymous namespace </p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="color: red;">The error before this change:</span></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">Current problem with the build after patch:
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">[100%] Generating ASAN_NOINST_TEST_OBJECTS.asan_noinst_test.cc.x86_64-with-calls.o
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:70:1: error: asm-specifier for input or output
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> variable conflicts with asm clobber list </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">DECLARE_ASM_REP_MOVS(U8, "movsq");
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">^ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> 'DECLARE_ASM_REP_MOVS' </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> : "rsi", "rdi", "rcx", "memory"); \
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> ^ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:129:1: error: asm-specifier for input or output
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> variable conflicts with asm clobber list
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">DECLARE_ASM_REP_MOVS(U1, "movsb");
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">^ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> 'DECLARE_ASM_REP_MOVS'
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> : "rsi", "rdi", "rcx", "memory"); \
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> ^
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:130:1: error: asm-specifier for input or output
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> variable conflicts with asm clobber list
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">DECLARE_ASM_REP_MOVS(U2, "movsw"); </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">^
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> 'DECLARE_ASM_REP_MOVS'
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> : "rsi", "rdi", "rcx", "memory"); \ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> ^
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:131:1: error: asm-specifier for input or output
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> variable conflicts with asm clobber list </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">DECLARE_ASM_REP_MOVS(U4, "movsl");
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">^ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> 'DECLARE_ASM_REP_MOVS' </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> : "rsi", "rdi", "rcx", "memory"); \
</span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;"> ^ </span></p>
<p class="MsoNormal"><span style="background: none repeat scroll 0% 0% silver;">4 errors generated.</span></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> </p>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p><br>_______________________________________________<br>LLVM Developers mailing list<br>llvm-dev@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br></blockquote><br><br><br>-- <br><div><span name="x"></span>Hal Finkel<br>Lead, Compiler Technology and Programming Languages<br>Leadership Computing Facility<br>Argonne National Laboratory<span name="x"></span><br></div></div></body></html>