<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal">There is a problem in the compiler-rt project regarding a new change I need to make.<o:p></o:p></p>
<p class="MsoNormal">The change is that in extended gcc syntax, when the same register is in the input/output list and in the clobber list, there is a conflict and llvm should produce an error.<o:p></o:p></p>
<p class="MsoNormal">Until now, it didn’t produce an error.<o:p></o:p></p>
<p class="MsoNormal">In compiler-rt’s tests, there’s a test which shouldn’t generate an error but after the patch it does. Therefore, we need to correct the test (which is not correct according to extended gcc).<o:p></o:p></p>
<p class="MsoNormal">The review regarding the new error message is : <a href="https://reviews.llvm.org/D15075">
https://reviews.llvm.org/D15075</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#0070C0;background:yellow;mso-highlight:yellow">What is the process in compiler-rt in order to accept and commit that change?</span><span style="color:#0070C0"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The change which needed to be made is:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Index: lib/asan/tests/asan_asm_test.cc
<o:p></o:p></p>
<p class="MsoNormal">===================================================================
<o:p></o:p></p>
<p class="MsoNormal">--- lib/asan/tests/asan_asm_test.cc (revision 285517)
<o:p></o:p></p>
<p class="MsoNormal">+++ lib/asan/tests/asan_asm_test.cc (working copy)
<o:p></o:p></p>
<p class="MsoNormal">@@ -62,7 +62,7 @@
<o:p></o:p></p>
<p class="MsoNormal"> __asm__("rep " Movs " \n\t" \<o:p></o:p></p>
<p class="MsoNormal"> : \<o:p></o:p></p>
<p class="MsoNormal"> : "D"(dst), "S"(src), "c"(size) \<o:p></o:p></p>
<p class="MsoNormal">- : "rsi", "rdi", "rcx", "memory"); \<o:p></o:p></p>
<p class="MsoNormal">+ : "memory"); \<o:p></o:p></p>
<p class="MsoNormal"> }
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> DECLARE_ASM_WRITE(U8, "8", "movq", "r"); <o:p></o:p></p>
<p class="MsoNormal">@@ -104,7 +104,7 @@
<o:p></o:p></p>
<p class="MsoNormal"> __asm__("rep " Movs " \n\t" \<o:p></o:p></p>
<p class="MsoNormal"> : \<o:p></o:p></p>
<p class="MsoNormal"> : "D"(dst), "S"(src), "c"(size) \<o:p></o:p></p>
<p class="MsoNormal">- : "esi", "edi", "ecx", "memory"); \<o:p></o:p></p>
<p class="MsoNormal">+ : "memory"); \<o:p></o:p></p>
<p class="MsoNormal"> }
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> } // End of anonymous namespace <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:red">The error before this change:<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">Current problem with the build after patch:
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">[100%] Generating ASAN_NOINST_TEST_OBJECTS.asan_noinst_test.cc.x86_64-with-calls.o
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:70:1: error: asm-specifier for input or output
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> variable conflicts with asm clobber list <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">DECLARE_ASM_REP_MOVS(U8, "movsq");
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">^ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> 'DECLARE_ASM_REP_MOVS' <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> : "rsi", "rdi", "rcx", "memory"); \
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> ^ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:129:1: error: asm-specifier for input or output
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> variable conflicts with asm clobber list
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">DECLARE_ASM_REP_MOVS(U1, "movsb");
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">^ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> 'DECLARE_ASM_REP_MOVS'
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> : "rsi", "rdi", "rcx", "memory"); \
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> ^
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:130:1: error: asm-specifier for input or output
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> variable conflicts with asm clobber list
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">DECLARE_ASM_REP_MOVS(U2, "movsw"); <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">^
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> 'DECLARE_ASM_REP_MOVS'
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> : "rsi", "rdi", "rcx", "memory"); \ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> ^
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:131:1: error: asm-specifier for input or output
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> variable conflicts with asm clobber list <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">DECLARE_ASM_REP_MOVS(U4, "movsl");
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">^ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">/home/mzuckerm/llvm23/llvm/projects/compiler-rt/lib/asan/tests/asan_asm_test.cc:65:15: note: expanded from macro
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> 'DECLARE_ASM_REP_MOVS' <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> : "rsi", "rdi", "rcx", "memory"); \
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver"> ^ <o:p></o:p></span></p>
<p class="MsoNormal"><span style="background:silver;mso-highlight:silver">4 errors generated.</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>