<div dir="ltr">Hi Peter,<div><br></div><div>Thanks for sending this and sorry for the slow response. Some questions below.</div><div><br></div><div>Teresa</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 25, 2016 at 5:27 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div>As promised, here is a brain dump on how I see CFI for vcalls working under ThinLTO. Most of this has been prototyped, so the design does appear to be sound. For context on how CFI currently works under regular LTO, please read:</div><div><br></div><div><a href="http://llvm.org/docs/TypeMetadata.html" target="_blank">http://llvm.org/docs/<wbr>TypeMetadata.html</a><br></div><div><a href="http://clang.llvm.org/docs/ControlFlowIntegrityDesign.html" target="_blank">http://clang.llvm.org/docs/<wbr>ControlFlowIntegrityDesign.<wbr>html</a></div><div><a href="http://clang.llvm.org/docs/LTOVisibility.html" target="_blank">http://clang.llvm.org/docs/<wbr>LTOVisibility.html</a></div><div><br></div><div>==== Summary extensions ====</div><div><br></div><div>The combined summary index would be extended to include a mapping from type identifiers to "resolutions". The resolution would control what type of code we generate to create a CFI check for that type identifier. Here are the resolutions that we would support:</div><div><br></div><div>Inline32, Inline64, SingleBit: these would cause us to generate code as described in "Short Inline Bit Vectors" in the design document: <a href="http://clang.llvm.org/docs/ControlFlowIntegrityDesign.html#short-inline-bit-vectors" target="_blank">http://clang.llvm.<wbr>org/docs/<wbr>ControlFlowIntegrityDesign.<wbr>html#short-inline-bit-vectors</a><br></div><div>AllOnes: this would cause us to generate code as described in "Eliminating Bit Vector Checks for All-Ones Bit Vectors" in the design document: <a href="http://clang.llvm.org/docs/ControlFlowIntegrityDesign.html#eliminating-bit-vector-checks-for-all-ones-bit-vectors" target="_blank">http://clang.llvm.<wbr>org/docs/<wbr>ControlFlowIntegrityDesign.<wbr>html#eliminating-bit-vector-<wbr>checks-for-all-ones-bit-<wbr>vectors</a></div><div><div>Unsat: no vtable is a member of that type identifier, so we can simply replace type checks for that type identifier with "false"</div><div>ByteArray: we emit the general form of the type check, similar to the one shown at the end of <a href="http://clang.llvm.org/docs/ControlFlowIntegrityDesign.html#forward-edge-cfi-for-virtual-calls" target="_blank">http://clang.llvm.org/docs/<wbr>ControlFlowIntegrityDesign.<wbr>html#forward-edge-cfi-for-<wbr>virtual-calls</a> just before "Optimizations"</div><div><br></div><div>Armed with that information, we have a general idea of what the code to implement the type check would look like. In fact, given one of these values, the code will be identical to any other check that uses that resolution, modulo the constant values embedded in the code.</div><div><br></div><div>To expand on what I mean by "constant values", let's look at a typical CFI check in the ByteArray case. Consider this module (based on test/Transforms/<wbr>LowerTypeTests/simple.ll):</div><div><br></div><div><div>@a = constant i32 1, !type !0, !type !2</div><div>@b = constant [63 x i32] zeroinitializer, !type !0, !type !1</div><div>@c = constant i32 3, !type !1, !type !2</div><div>@d = constant [2 x i32] [i32 4, i32 5], !type !3</div></div><div><div><br></div><div>!0 = !{i32 0, !"typeid1"}</div><div>!3 = !{i32 4, !"typeid1"}</div><div>!1 = !{i32 0, !"typeid2"}<br></div><div>!2 = !{i32 0, !"typeid3"}<br></div></div><div><br></div><div><div>define i1 @baz(i32* %p) {</div></div><div> %x = call i1 @llvm.type.test(i8* %pi8, metadata !"typeid3")<br></div><div> ret i1 %x</div><div>}</div><div><br></div><div>Here is the IR after the LowerTypeTests pass has run. I've marked the places where we use a constant value:</div><div><br></div><div><div>define i1 @baz(i32* %p) {</div><div> %pi8 = bitcast i32* %p to i8*</div><div> %1 = ptrtoint i8* %pi8 to i32</div><div> %2 = sub i32 %1, ptrtoint ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* @0 to i32)</div><div> %3 = lshr i32 %2, 2 ; CONSTANT: rotate count</div><div> %4 = shl i32 %2, 30 ; CONSTANT: 32-rotate count</div><div> %5 = or i32 %3, %4</div><div> %6 = icmp ult i32 %5, 66 ; CONSTANT: size of byte array</div><div> br i1 %6, label %7, label %12</div><div><br></div><div>; <label>:7: ; preds = %0</div><div> %8 = getelementptr i8, i8* @bits_use, i32 %5</div><div> %9 = load i8, i8* %8</div><div> %10 = and i8 %9, 2 ; CONSTANT: bit mask</div><div> %11 = icmp ne i8 %10, 0</div><div> br label %12</div><div><br></div><div>; <label>:12: ; preds = %0, %7</div><div> %13 = phi i1 [ false, %0 ], [ %11, %7 ]</div><div> ret i1 %13</div><div>}</div></div><div><br></div><div>Here is what the asm for the above looks like:</div><div><br></div><div><div>baz:</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>leaq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>.L__unnamed_1(%rip), %rax<br></div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>subl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%eax, %edi</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>roll<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$30, %edi ; CONSTANT: 32-rotate count</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>cmpl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$65, %edi ; CONSTANT: size of byte array</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>ja<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>.LBB2_1</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"><br></span></div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>movslq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%edi, %rax</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>leaq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>.Lbits_use(%rip), %rcx</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>movb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>(%rax,%rcx), %al</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>andb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$2, %al ; CONSTANT: bit mask</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>shrb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%al</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>retq</div><div>.LBB2_1:</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>xorl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%eax, %eax</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>retq</div></div><div><br></div><div>A naive summary encoding would map a type identifier to a tuple of (resolution, rotate count, size of byte array, bit mask), and pull the latter three out of the summary as constants. However, the disadvantage of hard coding the constants in the IR like this is that any change to one of the constants will invalidate any cache entry that depends on a constant value. For example, if I add a class to a hierarchy, that would most likely increase the size of the byte array, which may invalidate every cache entry containing a check for a class in that hierarchy. To avoid this, we only include resolutions in the summary and obtain the constants using absolute symbol references. Here is what the asm code may look like:</div><div><br></div><div><div>baz:</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>leaq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>__typeid_typeid3_global_addr(%<wbr>rip), %rax</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>subl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%eax, %edi</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>rorl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$__typeid_typeid3_rotate_<wbr>count, %edi</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>cmpl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$__typeid_typeid3_size, %edi</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>ja<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>.LBB2_1</div><div><br></div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>movslq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%edi, %rax</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>leaq<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>__typeid_typeid3_byte_array(%<wbr>rip), %rcx</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>movb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>(%rax,%rcx), %al</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>andb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>$__typeid_typeid3_bitmask, %al</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>shrb<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%al</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>retq</div><div>.LBB2_1:</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>xorl<span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>%eax, %eax</div><div><span class="gmail-m_2356618423114885555gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>retq</div></div><div><br></div><div>The appropriate representation for this at the IR level is the subject of the RFC entitled 'Absolute or "fixed address" symbols as immediate operands'. We can imagine, though, that it could look something like this:</div><div><br></div><div>@__typeid_typeid3_rotate_count = external globalconst i8</div><div>@__typeid_typeid3_size = external globalconst i32</div><div>@__typeid_typeid3_bit_mask = external globalconst i8</div><div>@__typeid_typeid3_byte_array = external global i8</div><div><div>@__typeid_typeid3_global_addr = external global i8</div></div></div></div></blockquote><div><br></div><div>Naive question: These will be defined in the object file containing the definition of the key method and therefore the vtable definition, right? So only that object would need to be recompiled on a change like the one you mentioned earlier when talking about caching (adding a class to a hierarchy), right?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div><div>define i1 @baz(i32* %p) {</div><div> %pi8 = bitcast i32* %p to i8*</div><div> %1 = ptrtoint i8* %pi8 to i32</div><div> %2 = sub i32 %1, ptrtoint (i8* @__typeid_typeid3_global_addr to i32)</div><div> %3 = lshr i32 %2, i8 @__typeid_typeid3_rotate_count</div><div> %4 = shl i32 %2, sub i8 (i8 32, i8 @__typeid_typeid3_rotate_<wbr>count)</div><div> %5 = or i32 %3, %4 </div><div> %6 = icmp ult i32 %5, i32 @__typeid_typeid3_size</div><div> br i1 %6, label %7, label %12</div><div><br></div><div>; <label>:7: ; preds = %0</div><div> %8 = getelementptr i8, i8* @__typeid_typeid3_byte_array, i32 %5</div><div> %9 = load i8, i8* %8</div><div> %10 = and i8 %9, @__typeid_typeid3_bitmask</div><div> %11 = icmp ne i8 %10, 0</div><div> br label %12</div><div><br></div><div>; <label>:12: ; preds = %0, %7</div><div> %13 = phi i1 [ false, %0 ], [ %11, %7 ]</div><div> ret i1 %13</div><div>}</div></div><div><br></div><div>==== Getting resolutions into the summary ====</div><div><br></div><div>Now that we've looked at how code is generated for the individual modules, let's look at how the resolutions are computed and put into the summary.</div><div><br></div><div>The first step happens when we compile the translation unit with clang. I propose to change the bitcode format for any module that defines virtual tables with hidden LTO visibility. The bitcode would contain two modules: one to be compiled with regular LTO and the other to be compiled with ThinLTO. The regular LTO module would contain only the following:</div><div><ul><li>the definitions of those virtual tables that have hidden LTO visibility<br></li></ul></div></div></div></blockquote><div><br></div><div>Another naive question: What happens in the non-hidden case and why is it different here? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><ul><li>the !type metadata for those virtual tables<br></li><li>a list of type tests required by the corresponding ThinLTO module, in a GlobalMDNode named "llvm.export.type.tests"</li></ul></div><div>The ThinLTO module would contain the rest of the original module.</div></div></div></blockquote><div><br></div><div>The two modules would presumably be distinguished because the regular LTO module would not have a summary block, because the summary for it would be generated on the fly during LTO processing of the merged regular LTO modules, right? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div>For example, here is what the regular LTO module for our example above would look like:</div><div><br></div><div><div>@a = constant i32 1, !type !0, !type !2</div><div>@b = constant [63 x i32] zeroinitializer, !type !0, !type !1</div><div>@c = constant i32 3, !type !1, !type !2</div><div>@d = constant [2 x i32] [i32 4, i32 5], !type !3</div><div><br></div><div>!0 = !{i32 0, !"typeid1"}</div><div>!3 = !{i32 4, !"typeid1"}</div><div>!1 = !{i32 0, !"typeid2"}</div><div>!2 = !{i32 0, !"typeid3"}</div><div><br></div></div><div>!8 = !{!"typeid3"}<br></div><div>!llvm.export.type.tests = !{!8}</div><div><br></div><div>and here is the ThinLTO module:</div><div><br></div><div><div>define i1 @baz(i32* %p) {</div><div> %x = call i1 @llvm.type.test(i8* %pi8, metadata !"typeid3")</div><div> ret i1 %x</div><div>}</div></div><div><br></div><div>The regular LTO modules are merged and compiled in the usual way, so we would end up merging the type definitions together with the list of required data.</div><div><br></div><div>When the LowerTypeTests pass is given a module with the "llvm.export.type.tests" global MDNode, it "exports" each of the type identifiers mentioned in the MDNode by storing a resolution in the combined summary, and by creating </div></div></div></blockquote><div><br></div><div>Assuming I understand this correctly, that means that there would be some kind of type table section in the combined summary index bitcode file, that would look something like the following for the above case:</div><div><br></div><div><div><TYPEID_SUMMARY_BLOCK ...></div><div> <TYPE abbrevid=... resolutionid, "typeid3"></div></div><div></TYPEID_SUMMARY_BLOCK><br></div><div><br></div><div>and included in the on-disk summary as a StringMap, right?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>definitions of each of the symbols that shall be required to satisfy the link time dependencies in the individual ThinLTO modules. Here is an example of what the combined module would look like:</div><div><br></div><div>@0 = [...] ; combined global for a, b, c and d</div><div>@bits = [...] ; combined global byte array</div><div><br></div><div><div>@__typeid_typeid3_global_addr = hidden alias i8, bitcast ({...}* @0 to i8*)</div><div>@__typeid_typeid3_rotate_count = hidden globalconst i8 2</div><div><div>@__typeid_typeid3_size = hidden globalconst i32 65</div></div><div>@__typeid_typeid3_byte_array = hidden alias i8, i8* @bits</div><div>@__typeid_typeid3_bit_mask = hidden globalconst i8 2</div></div><div><br></div><div>The ThinLTO backend processes would run after regular LTO, so they would have access to the resolutions in the summary. If the module summary is present, LowerTypeTests will "import" the appropriate type identifier by generating code containing external references to these symbols, as described previously.</div></div></div></blockquote><div><br></div><div>So in the above case where the summary says "typeid3" -> ByteArray, ThinLTO would on the ThinLTO module would see the @llvm.type.test of typeid3 in the IR, consult the type resolution table in the combined summary, and know to generate decls for those @__typeid_typeid3_* variables and the associated code, right?</div><div><br></div><div>One thing that needs some thought is for the distributed case, where the thin link serializes out individual index files for each ThinLTO module. Presumably that step would first create the merged regular LTO module and emit a regular object file for it during the thin link - we'll just need to anticipate that under the appropriate options. But the bigger issue that needs thought now is how to know which subset of the type resolution summary table to emit into each individual index file. That needs to be known when processing the ThinLTO modules through the WriteIndexesThinBackend - won't the ThinLTO summaries need to include info about which typeids are referenced from that module? Otherwise you'd have to conservatively emit the entire type resolution summary table in each individual index file - doable but presumably a fair amount of overhead.</div><div><br></div><div>Thanks,</div><div>Teresa</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div>Thanks,</div><span class="gmail-HOEnZb"><font color="#888888">-- <br><div class="gmail-m_2356618423114885555gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><span style="font-family:times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td><td nowrap style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td><td nowrap style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top:2px solid rgb(238,178,17)"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>