<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<blockquote
cite="mid:EF75BAA0-3302-4400-9B6C-ADA3682D7CCA@apple.com"
type="cite">
<div>
<div><br class="">
</div>
<div>Does COFF perhaps need the alignment?</div>
</div>
</blockquote>
I don't think it does, "git grep" says it has nothing to do with
alignment. And according to autotests it doesn't need it.<br>
<blockquote
cite="mid:EF75BAA0-3302-4400-9B6C-ADA3682D7CCA@apple.com"
type="cite">
<div><br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote">
<div class="">2) It'd be nice not to print the zero, to
keep the textual representation simple/less noisy (as
we do with many other metadata fields)<br class="">
</div>
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
I'm fine with not printing zero (Victor: ideally, this be a
separate commit). </div>
</blockquote>
That's already done before me, so no need for additional changes.<br>
<blockquote
cite="mid:EF75BAA0-3302-4400-9B6C-ADA3682D7CCA@apple.com"
type="cite">
<div>I'm not so comfortable with not not printing any other values
(such as 8).</div>
</blockquote>
That's the dilemma here: LLVM code doesn't know whether alignment
was forced by programmer or it is default one (clang does know). The
first approach I tried was to print all alignment values (old
behavior) and mark forced alignment with special flag (in DIFlags).
After that we decided that adding new flag is overkill here and we
can use alignment value instead: if it set means it was forced,
otherwise it is default (current behavior). I think we should stick
with the latter one as it keeps code simpler.<br>
<blockquote
cite="mid:EF75BAA0-3302-4400-9B6C-ADA3682D7CCA@apple.com"
type="cite">
<div><br class="">
</div>
<div>thanks for the explanation,</div>
<div>adrian<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote">
<div class=""><br class="">
But it's not a big deal if someone else feels
strongly.<br class="">
<br class="">
- Dave</div>
<div class=""> </div>
<blockquote class="gmail_quote" style="margin: 0px 0px
0px 0.8ex; border-left-width: 1px; border-left-color:
rgb(204, 204, 204); border-left-style: solid;
padding-left: 1ex;"><br class="gmail_msg">
-- adrian<br class="gmail_msg">
_______________________________________________<br
class="gmail_msg">
LLVM Developers mailing list<br class="gmail_msg">
<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org"
class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br
class="gmail_msg">
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Best Regards,
Victor</pre>
</body>
</html>