<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">I think it best to just drop -j totally. I don’t know if we can easily convince OptionParser to make passing both an error condition.</div> <br> <div id="bloop_sign_1474504170560721920" class="bloop_sign"></div> <br><p class="airmail_on">On September 21, 2016 at 4:16:32 PM, Renato Golin via llvm-dev (<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>
<title></title>
<p dir="ltr">Right, so the bots now pass threads directly, so the
worst part is over.</p>
<p dir="ltr">Now, being the same thing, I wonder if we just
deprecate -j and emit an error, or a warning of which got chosen,
or silently prefer - - threads over - j if both are emitted. I
don't think the current behaviour of - j silently overriding - -
threads is a good model, though.</p>
<p dir="ltr">Cheers,<br>
Renato</p>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 21 Sep 2016 8:57 p.m., "Chris Matthews"
<<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>>
wrote:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
-j and —threads are the same flag. The problem is passing it twice
with two different values. I am sort of surprised
OptionParser let that past.</div>
<div class="quoted-text"><br>
<br>
<p>On September 21, 2016 at 2:33:48 AM, Renato Golin via llvm-dev
(<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>) wrote:</p>
</div>
<blockquote type="cite">
<div>
<div>
<div class="quoted-text"><span>On 21 September 2016 at 01:33, Chris
Matthews <<a href="mailto:chris.matthews@apple.com" target="_blank">chris.matthews@apple.com</a>> wrote:<br></span></div>
<div class="quoted-text"><span>> I think every job should define
those or use the LNT default of 1,1. The<br>
> validity of compile time and exec time metrics is in question
if the job is<br>
> loaded incorrectly, so it makes sense to me to not allow that
-j to get<br>
> passed through.<br>
<br></span></div>
<div class="quoted-text"><span>The job's default *is* -j1. But we
pass -jN to the other steps<br>
(compiling Clang, for instance).<br>
<br>
We also pass -jN to LNT, because that means both build and execute
in one go.<br>
<br>
I'll change the buildbots to pass both explicitly in nt_flags,
and<br>
will also change the builder to not pass -j in any case.<br>
<br>
But if users should not be passing -jN, but instead --threads
and<br>
--build-threads directly, than I think we should make it into an
error<br>
in LNT, no?<br>
<br></span></div>
<div class="quoted-text"><span>cheers,<br>
--renato<br>
______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
</span></div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
<br></div>
_______________________________________________<br>LLVM Developers mailing list<br>llvm-dev@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br></div></div></span></blockquote></body></html>