<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hi Manuel,</div><div class=""><br class=""></div><div class="">I believe you're maintaining Phabricator at <a href="http://reviews.llvm.org" class="">reviews.llvm.org</a>. Duncan likes to send his patch comments via email, like in the example below. Do you know why don't his replies get imported into the web interface? The reply was sent to "<a href="mailto:reviews+D24569+public+a5763c0a090df06f@reviews.llvm.org" class="">reviews+D24569+public+a5763c0a090df06f@reviews.llvm.org</a>", and I bet that the purpose of this weird address is to match the revision this reply belongs to. I never saw any email reply actually appear in the web interface, and that sounds like a server misconfiguration.</div><div class=""><br class=""></div><div class="">Or is that something that Phabricator just doesn't support?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Kuba</div><div><br class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">"Duncan P. N. Exon Smith" <<a href="mailto:dexonsmith@apple.com" class="">dexonsmith@apple.com</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Re: [PATCH] D24569: [libcxx] Allow sanitizing libcxx with ASan+UBSan simultaneously</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">14 September 2016 at 19:01:29 GMT+2<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:reviews+D24569+public+a5763c0a090df06f@reviews.llvm.org" class="">reviews+D24569+public+a5763c0a090df06f@reviews.llvm.org</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Cc: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:kuba.brecka@gmail.com" class="">kuba.brecka@gmail.com</a>, <a href="mailto:eric@efcs.ca" class="">eric@efcs.ca</a>, <a href="mailto:compnerd@compnerd.org" class="">compnerd@compnerd.org</a>, <a href="mailto:filcab+llvm.phabricator@gmail.com" class="">filcab+llvm.phabricator@gmail.com</a>, <a href="mailto:beanz@apple.com" class="">beanz@apple.com</a>, <a href="mailto:zaks.anna@gmail.com" class="">zaks.anna@gmail.com</a>, <a href="mailto:mgorny@gentoo.org" class="">mgorny@gentoo.org</a><br class=""></span></div><br class=""><div class=""><div class=""><br class=""><blockquote type="cite" class="">On 2016-Sep-14, at 09:39, Kuba Brecka <<a href="mailto:kuba.brecka@gmail.com" class="">kuba.brecka@gmail.com</a>> wrote:<br class=""><br class="">kubabrecka added inline comments.<br class=""><br class="">================<br class="">Comment at: test/libcxx/test/config.py:628<br class="">@@ +627,3 @@<br class="">+ self.cxx.flags += ['-fsanitize=undefined',<br class=""></blockquote><br class="">Shouldn't this be '-fsanitize="undefined;address"'?<br class=""><br class=""><blockquote type="cite" class="">+ '-fno-sanitize=vptr,function,float-divide-by-zero',<br class="">+ '-fno-sanitize-recover=all']<br class=""></blockquote><br class="">Can this be refactored to avoid code duplication with the UBSan changes?<br class=""></div></div></blockquote></div><br class=""></body></html>