<div dir="ltr">I can't say I'm excited to support MSVC 2013 for another month, but I'm more concerned about the burden on other developers. People I talked to at the SF bay area social last Thursday were really excited to drop 2013 support. I guess I'll leave my buildbots on another month and see how it goes.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 8, 2016 at 7:03 AM, Robinson, Paul via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_-3509413521963013427WordSection1"><span class="">
<p class="MsoNormal">As this is an ABI-incompatible upgrade, and it's changing the informal policy on upgrades, could we please have some more grace time? Ideally another month, so the 15th October. If we haven't sorted it by then, it's our problem.<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I had originally proposed 15 September mostly because nobody had proposed a specific date, and it has been kind of dragging on for a while. The primary cost
of deferring to 15 October seems to be that the community (Hi Reid!) will have to keep fixing VS2013 related problems for another month, which isn't ideal but hopefully we can tolerate it.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">(In fact at Sony we're only throwing the internal switch today, and we'll have to see what happens.)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_-3509413521963013427__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@<wbr>lists.llvm.org</a>]
<b>On Behalf Of </b>Craig, Ben via llvm-dev<br>
<b>Sent:</b> Wednesday, September 07, 2016 2:42 PM<br>
<b>To:</b> Zachary Turner; James Molloy; <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><span class=""><br>
<b>Subject:</b> Re: [llvm-dev] [cfe-dev] Revisiting our informal policy to support two versions of MSVC<u></u><u></u></span></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p>I'll need to dig up the references for that... but I'm pretty sure the universal CRT that debuted in MSVC 2015 only covers the C parts, and not the C++ parts.<u></u><u></u></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 9/7/2016 4:28 PM, Zachary Turner wrote:<u></u><u></u></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">It's worth pointing out that from 2015 and on, they claim to support full forwards compatibility of the standard libraries, so this should (in theory) never be an issue again.<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Sep 7, 2016 at 1:12 PM James Molloy via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi,<br>
<br>
As I understand it the specific issue we're seeing is related to what Martin described. But due to numerous bugs found when mixing objects compiled with different versions of MSVC in the past, we now are shy of doing it even if it seems to work superficially
- that's no guarantee bugs won't be found down the line. We'd much prefer to stay within the realms of what Microsoft support.
<br>
<br>
Cheers,<br>
<br>
James<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, 7 Sep 2016 at 20:53, Craig, Ben via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="m_-3509413521963013427gmailmsg">Note that this is intentional from the MSVC C++ library implementation side of things. For major versions, no attempt is made to preserve library ABI compatibility.<u></u><u></u></p>
<p class="MsoNormal">I am aware of a language ABI break in VC++ 2013. <a href="https://randomascii.wordpress.com/2013/12/01/vc-2013-class-layout-change-and-wasted-space/" target="_blank">
https://randomascii.wordpress.<wbr>com/2013/12/01/vc-2013-class-<wbr>layout-change-and-wasted-<wbr>space/</a><br>
<br>
I'm not currently aware of any on the VC++ 2015 side of things, but that doesn't mean much.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 9/7/2016 2:34 PM, Martin O'Riordan via llvm-dev wrote:<u></u><u></u></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">Apart from the obvious licencing issues, each time I have moved from one version of VC++ to another, the big problem I have had is not specifically the ABI at the
register passing, stack organisation level, but rather the implementation details of the Standard C++ libraries, and in particular the STL containers.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">While the compiler team puts considerable effort into maintaining the ABI, the C++ library implementation usually changes a lot.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">Since this is largely in the form of very complex headers defining templates which in turn cause other helper templates to be used, it is here that I find things go
awry.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">So for C++, a function like:<u></u><u></u></span></p>
</div>
<div>
<div style="margin-left:30.0pt">
<p class="MsoNormal"><span class="m_-3509413521963013427gmailmsg1"><span style="font-family:"Courier New"">std::list<int> foo();</span></span><span style="font-family:"Georgia","serif""><u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Georgia","serif""><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">seems simple enough, but if the caller and the callee are compiled with different versions, it usually won't work because of some artefact of the STL implementation
tuning that occurs between versions. In particular, this impacts things like using C++ interfaces across DLLs and in pre-compiled libraries.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">I think that the ABI maintenance in this case tends to be for C and POD compatability, but not for the higher level C++ compatability which is unfortunate and restricts
how we can use C++.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Georgia","serif"">Is it possible that it is this aspect of the version change that is causing your ABI difficulties?<u></u><u></u></span></p>
</div>
<div style="margin-left:30.0pt">
<p class="MsoNormal"><span style="font-family:"Georgia","serif"">MartinO<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Georgia","serif""><u></u> <u></u></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 7 September 2016 at 20:18, Zachary Turner via llvm-dev <span class="m_-3509413521963013427gmailmsg1">
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<u></u><u></u></p>
<p class="MsoNormal">Can you elaborate on the abi incompatibility? I thought there were no breaks
<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Sep 7, 2016 at 7:59 AM James Molloy via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="MsoNormal">Hi all, <u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Firstly sorry I'm a bit late responding on this one. Internally to ARM we build LLVM for Windows. Our current build cluster has only VS2013 installed and as a result of this thread we've been working on getting VS2015 installed. This involves
a certain amount of IT-wrangling as the cluster we use is company-wide. There have been some hiccups regarding licensing of MSVC professional (we can't use the community edition for the same reasons mentioned by Paul previously) but we hoped to be ready in
time for the 15th September switchover date.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">It's recently been realised that VS2013 and VS2015 are not ABI compatible (something that really surprised me), and this means we have to synchronize moving LLVM's build to VS2015 as well as upgrading a third party library that we receive
from the vendor in compiled library form. This is not something we're capable of doing by September 15th.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">We try really hard at ARM to hide our internal processes because we believe that they're on the whole irrelevant to the community, however in this case we'd be really stuck, unable to get production builds.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">As this is an ABI-incompatible upgrade, and it's changing the informal policy on upgrades, could we please have some more grace time? Ideally another month, so the 15th October. If we haven't sorted it by then, it's our problem.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">James<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, 1 Sep 2016 at 21:06 Mehdi Amini via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
</div>
<div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Sep 1, 2016, at 1:05 PM, Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>> wrote:<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal">On Thu, Sep 1, 2016 at 12:53 PM, Mehdi Amini via cfe-dev <span class="m_-3509413521963013427gmailmsg1">
<<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:
<u></u><u></u></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Isn’t a big (the most) reason for supporting “old” toolchains to allow downstream users to upgrade with some flexibility?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">If I have a large codebase that is using LLVM (let say a few custom backends), and is validated with “MSVC 2013”, I can upgrade to “2015” but I will need some qualification/validation: this is not free and take some time. If you drop aggressively
supports for “old” toolchain it means that I’m either stuck with an “old” LLVM or that I have to update earlier than expected.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Isn’t this usually balanced in upstream LLVM to upgrade when there is a real *benefit* to it? <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I’m mentioning it because it seems to conflict with the "always upgrade to the newest one unless there are serious issues with it” you mentioned above.<u></u><u></u></p>
</div>
</div>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I agree, we should raise the minimum VS version requirement when the benefits to the LLVM community outweigh the costs of switching for major LLVM contributors and users. I think we'll always make that decision in the same way: by raising
it on the mailing lists and discussing the pros and cons. That's basically what David said when he kicked this whole discussion off, anyway:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">"""<span class="m_-3509413521963013427gmailmsg1"><span style="font-size:9.5pt">But if we find ourselves in a situation where asking folks to upgrade to a compiler which has been widely deployed soothes development for the greater LLVM community, we should consider
dropping support for the older versions of that compiler."""</span></span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span class="m_-3509413521963013427gmailmsg1"><span style="font-size:9.5pt">I think everything is working as intended here.</span></span><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Right, to be clear there is no misunderstanding: I was absolutely not suggesting the opposite when answering Zach..<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">— <u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Mehdi<u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span class="m_-3509413521963013427gmailmsg1"><span style="font-size:9.5pt">We raised the VS 2013 upgrade issue, discussed it, determined that it was holding us back, and now we're doing the upgrade. If VS "15" brings major language compatibility improvements,
I imagine we'll be having this same discussion again next year. If it doesn't, and supporting 2015 and "15" at the same time has the same cost, then we won't bother raising the floor for a while.</span></span><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</blockquote>
</div>
<div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal">______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<pre>______________________________<wbr>_________________<u></u><u></u></pre>
<pre>LLVM Developers mailing list<u></u><u></u></pre>
<pre><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><u></u><u></u></pre>
<pre><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></pre>
</blockquote>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<pre>-- <u></u><u></u></pre>
<pre>Employee of Qualcomm Innovation Center, Inc.<u></u><u></u></pre>
<pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<u></u><u></u></pre>
</div>
<p class="MsoNormal">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
</blockquote>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<pre>-- <u></u><u></u></pre>
<pre>Employee of Qualcomm Innovation Center, Inc.<u></u><u></u></pre>
<pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<u></u><u></u></pre>
</div></div></div>
</div>
</div>
<br>______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
<br></blockquote></div><br></div>