<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 18, 2016, at 4:22 AM, Renato Golin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On 18 August 2016 at 08:34, Ed Jones via llvm-dev<br class=""><<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class="">We believe the code base is sufficiently mature that it is appropriate<br class="">for inclusion. Currently, the full source for AAP can be found on Github:<br class=""><a href="https://github.com/embecosm" class="">https://github.com/embecosm</a><br class=""></blockquote><br class="">Hi Ed,<br class=""><br class="">I had a look at the GitHub project and it wasn't clear what is needed<br class="">to move the AAP target in-tree.<br class=""><br class="">First, it seems you're merging our tree into yours, which means the<br class="">merge commit [1,2] show the differences between old and new LLVM<br class="">stuff, not yours vs. upstream. This makes it hard to predict the<br class="">affected changes.<br class=""></div></div></blockquote><div><br class=""></div><div>Github makes it quite easy I think: <a href="https://github.com/embecosm/aap-llvm/compare/3951c48624d73169b5409c490999fadbdafd9fa4...1d767ab10d0de413c341fe69ca228b97e7e1d255" class="">https://github.com/embecosm/aap-llvm/compare/3951c48624d73169b5409c490999fadbdafd9fa4...1d767ab10d0de413c341fe69ca228b97e7e1d255</a></div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">Also, you seem to have a standard-looking lib/Target/AAP [3], which is<br class="">a good step forward, but you also have added the simulator [4] in<br class="">there, which is not the right place. This should probably be a<br class="">different project altogether.<br class=""><br class="">So, from our recent check-list for new targets, I'm assuming a few things:<br class=""><br class="">Code owner: You?<br class="">Community: Embecosm + its users<br class="">License: AFAICS, check.<br class="">Docs / Impl: check<br class=""><br class="">The thing that isn't clear right now is "compatible code and policies".<br class=""><br class="">I don't see why we shouldn't take the AAP target, unless it poses a<br class="">big enough change to IR, the middle end, etc. So, I recommend two<br class="">steps:<br class=""><br class="">1. A quick summary of the target independent changes you had to do to<br class="">make your back-end work. Changes to IR semantics, additional Clang<br class="">checks, base classes overwritten, etc.<br class=""><br class="">2. Propose some patches on Phabricator, showing those differences.<br class="">These patches don't need to be the whole thing, for now, but basic<br class="">support ("hello world" style) should be working and tested.<br class=""><br class="">We can continue from there.<br class=""><br class="">cheers,<br class="">--renato<br class=""><br class=""><br class="">[1] <a href="https://github.com/embecosm/aap-llvm/commit/1d767ab10d0de413c341fe69ca228b97e7e1d255" class="">https://github.com/embecosm/aap-llvm/commit/1d767ab10d0de413c341fe69ca228b97e7e1d255</a><br class="">[2] <a href="https://github.com/embecosm/aap-clang/commit/d1c2e5081a6222f2b4ab8d175fbd68a5e803c6d9" class="">https://github.com/embecosm/aap-clang/commit/d1c2e5081a6222f2b4ab8d175fbd68a5e803c6d9</a><br class="">[3] <a href="https://github.com/embecosm/aap-llvm/tree/aap-master/lib/Target/AAP" class="">https://github.com/embecosm/aap-llvm/tree/aap-master/lib/Target/AAP</a><br class="">[4] <a href="https://github.com/embecosm/aap-llvm/tree/aap-master/lib/Target/AAPSimulator" class="">https://github.com/embecosm/aap-llvm/tree/aap-master/lib/Target/AAPSimulator</a><br class="">_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></div></blockquote></div><br class=""></body></html>