<div dir="ltr"><div>My current status on InstCombine patches: ongoing...no end in sight. If you look at some of my recent commits, you'll see that I'm trying to get general InstCombine transforms to work with vector types too. This is somehow related to the earlier cast patches that I listed, but I've lost track of how many levels below the original problem I've fallen. :)<br><br>But I don't think we can solve the zext equivalent of the sext transform done with <a href="https://reviews.llvm.org/D13757" target="_blank">https://reviews.llvm.org/<wbr>D13757</a> in InstCombine, so something else is needed to handle that case.<br><br></div>As escha notes and Quentin mentioned in D13757, CGP is the likely best place for this sort of thing, but if there are x86-specific (LEA) changes that you're trying to get, then extending D13757 to zexts is probably the least effort.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 10:22 AM, <span dir="ltr"><<a href="mailto:escha@apple.com" target="_blank">escha@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class=""><br><div><blockquote type="cite"><div>On Aug 8, 2016, at 8:22 AM, Artur Pilipenko via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:</div><br><div>
<div style="word-wrap:break-word">
Hi Sanjay,<br>
<div>
<blockquote type="cite">
<div>On 19 Jul 2016, at 18:54, Sanjay Patel <<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">
<div>
<div>
<div>Hi Artur -<br>
<br>
</div>
I don't think there's any reason to limit the transform to sexts only; that's just the case that was apparent in
<a href="https://llvm.org/bugs/show_bug.cgi?id=20134" target="_blank">https://llvm.org/bugs/show_<wbr>bug.cgi?id=20134</a> , so I limited it to that pattern.<br>
<br>
</div>
It's probably worth noting that I'm currently fighting through casts of all kinds in IR (InstCombine) rather than the backend:<br>
</div>
</div>
</div>
</blockquote>
What is the current status of this work? Does it make sense to patch the existing code in X86ISelLowering in order to support looking through zext or the generic solution will be available soon?</div>
</div></div></blockquote><br></div></span><div>As a side thought, this might be something best done in a CodeGenPrepare type position in the pipeline. The DAG is a little bit late because by that point you’ve lost some information (global information) and may not be able to eliminate all zexts/sexts accordingly. But instcombine may be a little bit early because it’ll hurt targets that prefer it the other way around. You could expand addressing mode stuff in CodeGenPrepare using knownbits or SCEV, maybe? We do something vaguely similar out of tree (but with the opposite goal, as our target only supports 32-bit offsets).</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>—escha</div></font></span></div></blockquote></div><br></div>