<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 2016-Aug-01, at 19:14, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Aug 1, 2016 at 5:51 PM Duncan P. N. Exon Smith via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" class="gmail_quote">I just want to note that there's currently a miscompile in C code with lifetime markers:<br class="">
<a href="http://lists.llvm.org/pipermail/cfe-dev/2016-July/050066.html" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/pipermail/cfe-dev/2016-July/050066.html</a><br class="">
<br class="">
Depending on how we fix that, we could end up being more pessimistic about when markers are emitted. I suggest we fix that before benchmarking this change.<br class=""></blockquote><div class=""><br class=""></div><div class="">That shouldn't impact this change.</div><div class=""><br class=""></div><div class="">The inliner will emit *inlining* based lifetime markers all on its own for any static allocas that the frontend doesn't annotate. So we could turn off all lifetime markers in Clang and the merging here should still not be necessary to get the stack savings.</div><div class=""><br class=""></div><div class="">(And I have now verified that yes, the inliner inserts these markers...)</div></div></div>
</div></blockquote></div><br class=""><div class="">Ah, thanks, I'd misunderstood up-thread somehow. In that case I agree that it's independent.</div></body></html>