<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)”<div class="">(and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision)</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""><div class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Jul 18, 2016, at 4:27 AM, James Y Knight <<a href="mailto:jyknight@google.com" class="">jyknight@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually?</p>
<div class="gmail_extra"><br class=""><div class="gmail_quote">On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Please add llvm-commits as a subscriber to all of these reviews<br class="">
> so everyone has a chance to see/comment on them.<br class="">
<br class="">
Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews.<br class="">
If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start.<br class="">
<br class="">
<br class="">
—<br class="">
Mehdi<br class="">
<br class="">
<br class="">
> Thanks,<br class="">
> --paulr<br class="">
><br class="">
>> -----Original Message-----<br class="">
>> From: llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" class="">llvm-dev-bounces@lists.llvm.org</a>] On Behalf Of Elena<br class="">
>> Lepilkina via llvm-dev<br class="">
>> Sent: Friday, July 15, 2016 6:05 AM<br class="">
>> To: llvm-dev<br class="">
>> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements<br class="">
>><br class="">
>> Hi all,<br class="">
>><br class="">
>> Now all discussed enhancements are divided into separate patches.<br class="">
>> Moreover I have found mistake which reduces performance. Now it's fixed.<br class="">
>><br class="">
>> List of patches (for those interested):<br class="">
>> Repeats in regular expressions - <a href="https://reviews.llvm.org/D22342" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22342</a><br class="">
>> Including files - <a href="https://reviews.llvm.org/D22344" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22344</a><br class="">
>> Expressions repeat for CHECK and CHECK-NEXT -<br class="">
>> <a href="https://reviews.llvm.org/D22345" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22345</a><br class="">
>> CHECK-LABEL-DAG - <a href="https://reviews.llvm.org/D22348" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22348</a><br class="">
>> CHECK-WORD - <a href="https://reviews.llvm.org/D22353" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22353</a><br class="">
>> prefixes-regular expressions - <a href="https://reviews.llvm.org/D22401" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22401</a><br class="">
>> pattern templates - <a href="https://reviews.llvm.org/D22403" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D22403</a>.<br class="">
>><br class="">
>> Thanks,<br class="">
>> Elena.<br class="">
>> _______________________________________________<br class="">
>> LLVM Developers mailing list<br class="">
>> <a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
> _______________________________________________<br class="">
> LLVM Developers mailing list<br class="">
> <a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
<br class="">
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></div></div></div></body></html>