<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:56.7pt 42.5pt 56.7pt 85.05pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thank you, James.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Then I’ll update all patches.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> James Y Knight [mailto:jyknight@google.com]
<br>
<b>Sent:</b> Monday, July 18, 2016 2:27 PM<br>
<b>To:</b> Mehdi Amini <mehdi.amini@apple.com><br>
<b>Cc:</b> llvm-dev@lists.llvm.org; Elena Lepilkina <Elena.Lepilkina@synopsys.com>; Robinson, Paul <paul.robinson@sony.com><br>
<b>Subject:</b> Re: [llvm-dev] RFC: FileCheck Enhancements<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p>It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually?<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> Please add llvm-commits as a subscriber to all of these reviews<br>
> so everyone has a chance to see/comment on them.<br>
<br>
Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews.<br>
If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start.<br>
<br>
<br>
—<br>
Mehdi<br>
<br>
<br>
> Thanks,<br>
> --paulr<br>
><br>
>> -----Original Message-----<br>
>> From: llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org">llvm-dev-bounces@lists.llvm.org</a>] On Behalf Of Elena<br>
>> Lepilkina via llvm-dev<br>
>> Sent: Friday, July 15, 2016 6:05 AM<br>
>> To: llvm-dev<br>
>> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements<br>
>><br>
>> Hi all,<br>
>><br>
>> Now all discussed enhancements are divided into separate patches.<br>
>> Moreover I have found mistake which reduces performance. Now it's fixed.<br>
>><br>
>> List of patches (for those interested):<br>
>> Repeats in regular expressions - <a href="https://reviews.llvm.org/D22342" target="_blank">
https://reviews.llvm.org/D22342</a><br>
>> Including files - <a href="https://reviews.llvm.org/D22344" target="_blank">https://reviews.llvm.org/D22344</a><br>
>> Expressions repeat for CHECK and CHECK-NEXT -<br>
>> <a href="https://reviews.llvm.org/D22345" target="_blank">https://reviews.llvm.org/D22345</a><br>
>> CHECK-LABEL-DAG - <a href="https://reviews.llvm.org/D22348" target="_blank">https://reviews.llvm.org/D22348</a><br>
>> CHECK-WORD - <a href="https://reviews.llvm.org/D22353" target="_blank">https://reviews.llvm.org/D22353</a><br>
>> prefixes-regular expressions - <a href="https://reviews.llvm.org/D22401" target="_blank">
https://reviews.llvm.org/D22401</a><br>
>> pattern templates - <a href="https://reviews.llvm.org/D22403" target="_blank">
https://reviews.llvm.org/D22403</a>.<br>
>><br>
>> Thanks,<br>
>> Elena.<br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>