<p dir="ltr">It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually?</p>
<div class="gmail_extra"><br><div class="gmail_quote">On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> Please add llvm-commits as a subscriber to all of these reviews<br>
> so everyone has a chance to see/comment on them.<br>
<br>
Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews.<br>
If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start.<br>
<br>
<br>
—<br>
Mehdi<br>
<br>
<br>
> Thanks,<br>
> --paulr<br>
><br>
>> -----Original Message-----<br>
>> From: llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org">llvm-dev-bounces@lists.llvm.org</a>] On Behalf Of Elena<br>
>> Lepilkina via llvm-dev<br>
>> Sent: Friday, July 15, 2016 6:05 AM<br>
>> To: llvm-dev<br>
>> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements<br>
>><br>
>> Hi all,<br>
>><br>
>> Now all discussed enhancements are divided into separate patches.<br>
>> Moreover I have found mistake which reduces performance. Now it's fixed.<br>
>><br>
>> List of patches (for those interested):<br>
>> Repeats in regular expressions - <a href="https://reviews.llvm.org/D22342" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22342</a><br>
>> Including files - <a href="https://reviews.llvm.org/D22344" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22344</a><br>
>> Expressions repeat for CHECK and CHECK-NEXT -<br>
>> <a href="https://reviews.llvm.org/D22345" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22345</a><br>
>> CHECK-LABEL-DAG - <a href="https://reviews.llvm.org/D22348" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22348</a><br>
>> CHECK-WORD - <a href="https://reviews.llvm.org/D22353" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22353</a><br>
>> prefixes-regular expressions - <a href="https://reviews.llvm.org/D22401" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22401</a><br>
>> pattern templates - <a href="https://reviews.llvm.org/D22403" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22403</a>.<br>
>><br>
>> Thanks,<br>
>> Elena.<br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>