<div dir="ltr"><div><div><div><div><div><div>Hi Elena,<br></div>Sorry if my question is something you've previously addressed. I didn't comment on the reviews themselves as I don't have any expertise with the implementation of FileCheck. However, much like most LLVM developers, I actively use the tool.<br><br></div>A brief look at the patches does not show updates to the documentation. I'm sure that many LLVM developers like myself will gladly use new features if they prove useful, but we just need to know about them. Rather than the source, I personally get information about how to use it from here: <a href="http://llvm.org/docs/CommandGuide/FileCheck.html">http://llvm.org/docs/CommandGuide/FileCheck.html</a>.<br></div><br>So I would say that for most of us, if the feature is not documented there, it is as if it doesn't exist.<br><br></div>Is there a separate patch (or a plan to put one up for review) for the documentation updates?<br><br></div>Thanks,<br></div>Nemanja<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 15, 2016 at 5:58 PM, Robinson, Paul via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please add llvm-commits as a subscriber to all of these reviews<br>
so everyone has a chance to see/comment on them.<br>
Thanks,<br>
--paulr<br>
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org">llvm-dev-bounces@lists.llvm.org</a>] On Behalf Of Elena<br>
> Lepilkina via llvm-dev<br>
> Sent: Friday, July 15, 2016 6:05 AM<br>
> To: llvm-dev<br>
> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements<br>
><br>
> Hi all,<br>
><br>
> Now all discussed enhancements are divided into separate patches.<br>
> Moreover I have found mistake which reduces performance. Now it's fixed.<br>
><br>
> List of patches (for those interested):<br>
> Repeats in regular expressions - <a href="https://reviews.llvm.org/D22342" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22342</a><br>
> Including files - <a href="https://reviews.llvm.org/D22344" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22344</a><br>
> Expressions repeat for CHECK and CHECK-NEXT -<br>
> <a href="https://reviews.llvm.org/D22345" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22345</a><br>
> CHECK-LABEL-DAG - <a href="https://reviews.llvm.org/D22348" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22348</a><br>
> CHECK-WORD - <a href="https://reviews.llvm.org/D22353" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22353</a><br>
> prefixes-regular expressions - <a href="https://reviews.llvm.org/D22401" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22401</a><br>
> pattern templates - <a href="https://reviews.llvm.org/D22403" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22403</a>.<br>
><br>
> Thanks,<br>
> Elena.<br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div></div></blockquote></div><br></div>