<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I just discussed this with vivek on IRC (and I think we agreed on this):</div><div class=""><br class=""></div><div class="">Let me first state the motivation clearly to ease later discussions:</div><div class="">As far as the motivation for this change goes: Changing the calling convention allows us to choose whether a register is saved by the callee or the caller. Usually it is best to have a mix of both as too many caller saved registers leads to unnecessary save/restores when the called function turns out to only touch a fraction of the registers (as is typically for smaller leaf-functions of the call graph). While too many callee saved registers may lead to unnecessary saves/restores of registers even though the calling function didn't have a live value in the register anyway. With IPRA the first problem is mitigated since we propagate the actually clobbered set of registers up the callgraph instead of relying on conventions, so it is best to aim for more caller saved registers (though we should check for code size increases and store/restore code being potentially less good than the tuned sequences generated during FrameLowering).</div><div class=""><br class=""></div><div class="">To the disucssion at hand:</div><div class="">- Introducing a new calling convention at the IR level is the wrong approach: The calling convention is mostly a contract when calling and being called across translation unit boundaries. The details about how this contract is fulfilled are part of CodeGen IMO but do not need to be visible at the IR level.</div><div class="">- The only thing we want to influence here is which registers are saved by the callee. Changing TargetFrameLowering::determineCalleeSaves() is a good place to achieve this without affecting unrelated things like parameter and return value handling which would be part of the calling convention.</div><div class="">- We could experiment with dynamically changing the number of caller saved registers in the future. I could imagine heuristics like functions called from many places using some callee saved registers in order to avoid code size increases because of extra spills/restores at all the call sites. We can hardly create new calling conventions for these combinations of marking registers as callee/caller saved.</div><div class=""><br class=""></div><div class="">- Matthias</div><div class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Jun 20, 2016, at 7:39 AM, vivek pandya via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Dear Community,<div class=""><br class=""></div><div class="">To improve current interprocedural register allocation (IPRA) , we have planned to set callee saved registers to none for local functions, currently I am doing it in following way:</div><div class=""><br class=""></div><div class=""><font face="monospace, monospace" class="">if (F->hasLocalLinkage() <span style="font-size:12.499999046325684px" class=""> </span><span style="font-size:12.499999046325684px" class="">&& !F->hasAddressTaken()</span>) {</font></div><div class=""><font face="monospace, monospace" class=""> DEBUG(dbgs() << "Function has LocalLinkage \n");</font></div><div class=""><font face="monospace, monospace" class="">F->setCallingConv(CallingConv::GHC); </font></div><div class=""><font face="monospace, monospace" class=""> }</font></div><div class=""><br class=""></div><div class="">but we think threre should be clean and properway to do this perhaps like:</div><div class=""><br class=""></div><div class=""><div class=""><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class="">if (F->hasLocalLinkage() && !F->hasAddressTaken()) {</font></div><span class="im" style="font-size:12.499999046325684px"><font face="monospace, monospace" class=""> DEBUG(dbgs() << "Function has LocalLinkage \n");</font></span><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""> F->setCallingConv(CallingConv::NO_Callee_Saved);</font></div><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""> }</font></div><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""><br class=""></font></div><div class=""><font face="arial, helvetica, sans-serif" class=""><span style="font-size:12.499999046325684px" class="">So I would like to know any better suggestions and if it is better to add a new CC for this purpose then what aspects should be considered while defining a new CC. Actually in this case the new CC does not really required to define how parameters should be passed or any special rule for return value etc , it just required to set callee saved registers to be none. So what are the minimal things required to define such a CC?</span></font></div></div></div><div class=""><font face="arial, helvetica, sans-serif" class=""><span style="font-size:12.499999046325684px" class=""><br class=""></span></font></div><div class=""><font face="arial, helvetica, sans-serif" class=""><span style="font-size:12.499999046325684px" class="">Other alternative that I have thought was to add new attribute for function and use it like following in TargetFrameLowering::determineCalleeSaves()</span></font></div><div class=""><font face="arial, helvetica, sans-serif" class=""><span style="font-size:12.499999046325684px" class=""><br class=""></span></font></div><div class=""><div style="font-size:12.499999046325684px" class=""> <font face="monospace, monospace" class="">// In Naked functions we aren't going to save any registers.</font></div><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""> if (MF.getFunction()->hasFnAttribute(Attribute::Naked))</font></div><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""> return;</font></div></div><div style="font-size:12.499999046325684px" class=""><font face="monospace, monospace" class=""><br class=""></font></div><div style="font-size:12.499999046325684px" class=""><font face="arial, helvetica, sans-serif" class="">Any suggestions / thoughts are welcomed !</font></div><div style="font-size:12.499999046325684px" class=""><font face="arial, helvetica, sans-serif" class=""><br class=""></font></div><div style="font-size:12.499999046325684px" class=""><font face="arial, helvetica, sans-serif" class="">Sincerely,</font></div><div style="font-size:12.499999046325684px" class=""><font face="arial, helvetica, sans-serif" class="">Vivek</font></div></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></body></html>