<div dir="ltr"><div>Hi Philip,<br><br></div>I can create the patch. I've never done this before, so I'm just going to follow [1]? Do I also need to create a test for ELF binaries to ensure that the section gets generated correctly?<br><br>[1] <a href="http://llvm.org/docs/DeveloperPolicy.html">http://llvm.org/docs/DeveloperPolicy.html</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 14, 2016 at 10:52 PM, Philip Reames <span dir="ltr"><<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Rob,<br>
<br>
Are you planning on sending a patch for this? If not, I'll get to
it eventually.<span class="HOEnZb"><font color="#888888"><br>
<br>
Philip</font></span><div><div class="h5"><br>
<br>
<div>On 06/14/2016 04:14 PM, Jim Grosbach
via llvm-dev wrote:<br>
</div>
<blockquote type="cite">
<div>This matches my recollection. Things were conditionalized on
what we had use cases for from which we could derive meaningful
test cases. <br>
<br>
Sent from my iPhone</div>
<div><br>
On Jun 13, 2016, at 6:27 PM, Andrew Trick via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank"></a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
Mostly likely, nobody got around to writing ELF tests. The
change to enable stack maps on ELF would be fine if it
includes a test case.
<div>-Andy<br>
<div><br>
<div>
<blockquote type="cite">
<div>On Jun 13, 2016, at 5:38 PM, Lang Hames
via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>
wrote:</div>
<br>
<div>
<div dir="ltr">Hi All,
<div><br>
</div>
<div>I don't recall anything MachO
specific in the AArch64 stack maps code. Digging
through the svn history it looks like the call
to SM.serializeToStackMapSection() used to be
unconditional but was put under the
isOSBinFormateMachO() test in r206610. Tim - was
there a reason for that? If not, I think it
should be safe to just move it back out.</div>
<div>
<div><span style="font-size:13px"><br>
</span></div>
<div><span style="font-size:13px">Cheers,</span></div>
</div>
<div><span style="font-size:13px">Lang.</span></div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jun 13, 2016 at
1:07 PM, Juergen Ributzka via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank"></a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">[+
Lang]
<div>
<div>
<div><br>
<div>
<blockquote type="cite">
<div>On Jun 13, 2016, at
9:58 AM, Philip Reames via
llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank"></a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>
wrote:</div>
<br>
<div>
<div text="#000000" bgcolor="#FFFFFF">
<div>Andy, Juergen,<br>
<br>
I don't know enough about
AArch64 to assess here. Is
the proposed change below
something we should take in
tree? I'm happy to do the
mechanics of posting a patch
(if Rob doesn't), but I
don't know enough to
assess. Would such a patch
be self contained? Or is
there other work needed?<br>
<br>
Philip<br>
<br>
On 05/26/2016 12:28 PM, Rob
Lyerly via llvm-dev wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>I figured
out the issue -- the
AArch64 backend only
emits the stack map
section if
isOSBinFormateMachO()
returns true -- see [1],
lines 123 - 134. Moving
the call to
serializeToStackMapSection()
outside of the
conditional fixes the
problem.<br>
<br>
[1] <a href="http://llvm.org/doxygen/AArch64AsmPrinter_8cpp_source.html" target="_blank"></a><a href="http://llvm.org/doxygen/AArch64AsmPrinter_8cpp_source.html" target="_blank">http://llvm.org/doxygen/AArch64AsmPrinter_8cpp_source.html</a><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
Thu, May 26, 2016 at
2:46 PM, Rob Lyerly <span dir="ltr"><<a href="mailto:rlyerly@vt.edu" target="_blank"></a><a href="mailto:rlyerly@vt.edu" target="_blank">rlyerly@vt.edu</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div dir="ltr">
<div>Hi
everyone,<br>
<br>
</div>
I'm using LLVM's
stack map
intrinsic to
store value
location
information.
I've got a pass
that
automatically
inserts the
"llvm.experimental.stackmap"
intrinsic into
the IR. On
x86-64, an
".llvm_stackmaps"
section is
successfully
emitted (I can
see the section
& its
contents in the
generated
assembly).
However I can't
get the AArch64
backend to
generate this
section. On the
website with
information
about the
intrinsic [1],
it says that
AArch64 is
supported. Is
there a flag I
need to add, or
is there
something I need
to enable when
building LLVM to
get this
support?<br>
<br>
[1] <a href="http://llvm.org/docs/StackMaps.html" target="_blank"></a><a href="http://llvm.org/docs/StackMaps.html" target="_blank">http://llvm.org/docs/StackMaps.html</a><br clear="all">
<br>
-- <br>
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div><span>Rob
Lyerly</span><br>
</div>
<div>Graduate
Research
Assistant,
Systems
Software
Research Group<br>
<br>
</div>
<div><img src="https://upload.wikimedia.org/wikipedia/en/thumb/2/23/Virginiatechseal.svg/200px-Virginiatechseal.svg.png" height="76" width="75">
<img src="http://www.oocities.org/rainforestwind/divider_black_vertical.jpg" height="75" width="8"><img src="http://www.ece.vt.edu/images/inside-top-ecelogo.png" height="55" width="272"></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div><span>Rob
Lyerly</span><br>
</div>
<div>Graduate
Research
Assistant,
Systems
Software
Research Group<br>
<br>
</div>
<div><img src="https://upload.wikimedia.org/wikipedia/en/thumb/2/23/Virginiatechseal.svg/200px-Virginiatechseal.svg.png" height="76" width="75">
<img src="http://www.oocities.org/rainforestwind/divider_black_vertical.jpg" height="75" width="8"><img src="http://www.ece.vt.edu/images/inside-top-ecelogo.png" height="55" width="272"></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>LLVM Developers mailing list</span><br>
<span><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a></span><br>
<span><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></span><br>
</div>
</blockquote>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div><span>Rob Lyerly</span><br></div><div>Graduate Research Assistant, Systems Software Research Group<br><br></div><div><img src="https://upload.wikimedia.org/wikipedia/en/thumb/2/23/Virginiatechseal.svg/200px-Virginiatechseal.svg.png" height="76" width="75"> <img src="http://www.oocities.org/rainforestwind/divider_black_vertical.jpg" height="75" width="8"><img src="http://www.ece.vt.edu/images/inside-top-ecelogo.png" height="55" width="272"></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>