<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 4, 2016, at 9:44 PM, vivek pandya <<a href="mailto:vivekvpandya@gmail.com" class="">vivekvpandya@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, Jun 5, 2016 at 9:15 AM, Mehdi Amini <span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Jun 4, 2016, at 8:32 PM, vivek pandya <<a href="mailto:vivekvpandya@gmail.com" target="_blank" class="">vivekvpandya@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, Jun 5, 2016 at 8:56 AM, Mehdi Amini <span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br class="">
> On Jun 4, 2016, at 7:56 PM, vivek pandya <<a href="mailto:vivekvpandya@gmail.com" target="_blank" class="">vivekvpandya@gmail.com</a>> wrote:<br class="">
><br class="">
> Hello Mehdi Amini,<br class="">
><br class="">
> Sorry for slow progress this week but it was due to interesting mistake of mine. I had build llvm with ipra enable by default and that build files were on my path ! Due to that next time I tried to build llvm it was terribly slow (almost 1 hour for 10% build ). I spend to much time on fixing this by playing around with environment variables, cmake options etc.<br class="">
> But I think this is a serious concern, we need to think verify this time complexity other wise building a large software with IPRA enable would be very time consuming.<br class="">
<br class="">
</span>Did you build your own clang in release mode or debug? That makes a very important difference...<br class=""></blockquote><div class="">oh yes nice point, what I did is Debug mode with IPRA 😬 that is insane. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br class="">
><br class="">
> I studied tets case suggest by you on phabricator, for RegUsageInfo passes I am thinking to print clobbered registers and verify that with FileCheck as expected clobbered register for a particular test-case. Is this approach fine?<br class="">
><br class="">
> I did not find function call to CostModelAnalysis::print() , Is opt -analyze making that call ?<br class="">
<br class="">
</span>Yes.<br class="">
(In general, if you find yourself in a situation where you can find the caller for a function, run in a debugger and set a breakpoint)<br class=""></blockquote><div class="">Ok </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br class="">
> I am not able to find similar option in llc.<br class="">
<br class="">
</span>That's an issue. Looks it may not be feasible to test the analysis in llc with the current infrastructure.<br class="">
<span class=""><br class=""></span></blockquote><div class="">I got the trick, actaully I am trying to do the same thing but let me figure out why it does not work? </div><div class="">./print-machineinstrs.ll:; RUN: llc < %s -O3 -debug-pass=Structure -print-machineinstrs=branch-folder -o /dev/null 2>&1 | FileCheck %s</div><div class="">./print-machineinstrs.ll:; RUN: llc < %s -O3 -debug-pass=Structure -print-machineinstrs -o /dev/null 2>&1 | FileCheck %s</div><div class="">./print-machineinstrs.ll:; RUN: llc < %s -O3 -debug-pass=Structure -print-machineinstrs= -o /dev/null 2>&1 | FileCheck %s </div></div></div></div></div></blockquote><div class=""></div></span></div></div></blockquote><div class="">The above example I found in test directory it feeds the .s file to /dev/null and binds stderr to stdout so that FileCheck will have debug info printed as input to work on. </div></div></div></div></div></blockquote><div><br class=""></div><div>We could indeed add the dump of the analysis results in doFinalization(), behind a cl::opt.</div><div><br class=""></div><div>-- </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><span class=""><div class=""> <br class=""></div></span></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><span class=""><div class=""></div></span><div class="">I'm not sure what you're doing here, but considering that llc does not expose -analyze, I'd just keep it all in a single patch as originally planned.</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">-- </div><div class="">Mehdi</div></font></span><div class=""><div class="h5"><div class=""><br class=""></div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">
> I can't use info printed with dbgs() function as release build do not add -debug-only option to llc executable.<br class="">
><br class="">
> For the testcase sent by you earlier I have modified it as following :<br class="">
> ;;;;; ip-regallco-simple.ll<br class="">
> ; RUN: llc < %s | FileCheck %s -check-prefix=NOIPRA<br class="">
> ; RUN: llc < %s -enable-ipra | FileCheck %s<br class="">
> ; NOIPRA: foo:<br class="">
<br class="">
</span>should be NOIPRA-LABEL:<br class="">
<span class=""><br class="">
> ; NOIPRA: pushq %r10<br class="">
> ; NOIPRA: pushq %r9<br class="">
> ; NOIPRA: pushq %r8<br class="">
</span>> ; NOIPRA: calls bar1<br class="">
<br class="">
If this is an exact sequence you want to match, you may use NOIPRA-NEXT </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br class="">
> ; CHECK: foo:<br class="">
> ; CHECK-NOT: pushq %r10<br class="">
> ; CHECK-NOT: pushq %r9<br class="">
> ; CHECK-NOT: pushq %r8<br class="">
<br class="">
</span>You can just write "CHECK-NOT: push"<br class="">
<span class=""><br class="">
> ; CHECK: callq bar1<br class="">
> target triple = "x86_64-unknown-unknown"<br class="">
> define void @bar1() {<br class="">
> ret void<br class="">
> }<br class="">
> define preserve_allcc void @foo()#0 {<br class="">
> call void @bar1()<br class="">
> call void @bar2()<br class="">
> ret void<br class="">
> }<br class="">
> define void @bar2() {<br class="">
> ret void<br class="">
> }<br class="">
> attributes #0 = {nounwind}<br class="">
><br class="">
> Is this correct approach to verify spills?<br class="">
<br class="">
</span>Yes.<br class="">
<span class=""><font color="#888888" class=""><br class="">
<br class="">
--<br class="">
Mehdi<br class="">
<br class="">
</font></span></blockquote></div><br class=""></div></div>
</div></blockquote></div></div></div><br class=""></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>