<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 31, 2016, at 4:48 PM, Daniel Dunbar via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi all,<div class=""><br class=""></div><div class="">I have some patches up in:</div><div class=""> <a href="http://reviews.llvm.org/D20721" class="">http://reviews.llvm.org/D20721</a></div><div class="">to make `lit` output more readable when commands fail. I'd like to get a little more feedback on this before landing, since it impacts how test failures appear when using the internal shell script runner (which is not the default so this will currently mostly impact Windows or test frameworks that intentionally set this behavior).</div><div class=""><br class=""></div><div class="">These patches change the output of a script like `true && echo hi && false` to something like:</div></div></div></blockquote><div><br class=""></div><div>What would the output of "echo '$ echo hi ' " be and how do you differentiate from '$ echo hi' ? </div><div><br class=""></div>-- </div><div>Mehdi</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">```</div><div class="">$ true</div><div class="">$ echo hi</div><div class="">hi</div><div class=""> </div><div class="">$ false</div><div class="">note: command had no output on stdout or stderr</div><div class="">error: command failed with exit status 1</div><div class="">```</div><div class=""><br class=""></div><div class="">instead of the old:</div><div class=""><br class=""></div><div class="">```</div><div class="">Command 0: "true"</div><div class="">Command 0 Result: 0</div><div class="">Command 0 Output:</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Command 0 Stderr:</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Command 1: "echo" "hi"</div><div class="">Command 1 Result: 0</div><div class="">Command 1 Output:</div><div class="">hi</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Command 1 Stderr:</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Command 2: "wc" "missing-file"</div><div class="">Command 2 Result: 1</div><div class="">Command 2 Output:</div><div class="">None</div><div class=""><br class=""></div><div class="">Command 2 Stderr:</div><div class="">None</div><div class="">```</div><div class=""><br class=""></div><div class="">which I think is significantly more readable.</div><div class=""><br class=""></div><div class="">One change in the patches is that it will also start including, inline, the output of files which were redirected. This solves a common problem where a command fails when it wasn't expected to, and its output was captured. In such cases the test log just showed the command failure, but since the output was redirected you couldn't tell from the log why the common failed.</div><div class=""><br class=""></div><div class="">Please let me know if you have any objections to the new format.</div><div class=""><br class=""></div><div class=""> - Daniel</div><div class=""><br class=""></div></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></body></html>