<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 16, 2016, at 6:07 PM, Quentin Colombet via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Let me summarize the current status of the discussion to check and propose a path forward.</div><div class=""><br class=""></div><div class="">* Summary *</div><div class=""><br class=""></div><div class="">Basically, the high-level status is:</div><div class="">1. Commits should state when they are fixes.</div><div class="">2. Bugs should be tracked in a PR.</div><div class=""><br class=""></div><div class="">None of these is a hard requirement but instead, best practices that we should remind to the contributors.</div><div class="">For #1, I propose the attached patch for the commit message policy.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">* What Is Next? *</div><div class=""><br class=""></div><div class="">Now, moving forward, we should investigate if it is possible to have:</div><div class="">A. Hooks on commit to automatically update some field in Diffusion/Bugzilla when a fix is committed.</div><div class="">B. PRs automatically created for fixes that do not have a PR.</div><div class=""><br class=""></div><div class="">For A, the idea is to have an automatic way to update the PRs (like resolved and fixed with a revision number) when some keywords are set (like fixes PR#). The idea with Diffusion is to have a field that marks the commit has been a fix and that we could manually set if we forgot to set the keyword at commit time.</div><div class=""><br class=""></div><div class=""><div class="">For B, assuming the PR or Diffusion becomes the way to keep trace of every fixes, it is a matter of making easy to document that we are fixing a bug even if a PR does not exist. Maybe it is possible to have some commit hooks that given a keyword (e.g., fixes PR#New) file a PR with the commit message and marks the PR as fixed (also patch the actual commit message to put the PR number).</div></div><div class=""><br class=""></div><div class=""><div class="">Now, regarding how this information could be used by release managers to track what has been pulled in their release, I believe we would need to build additional tools on top of that information, but having this information is the priority IMHO.</div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">* Feedback Needed *</div><div class=""><br class=""></div><div class="">- Is it possible to have commit hooks to set some fields in Diffusion/Bugzilla?</div><div class="">- Is it possible to have commit hooks to create PRs?</div></div></div></blockquote><div><br class=""></div><div>This is definitely possible, (we already have python script to interact between our internal BT and Bugzilla), but "someone" has to do it though...</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">- What do people think of the attached patch?</div></div></div></blockquote><div><br class=""></div><div>LGTM.</div><div><br class=""></div><div>-- </div><div>Mehdi</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Cheers,</div><div class="">-Quentin</div><div class=""><br class=""></div><div class=""></div></div><span id="cid:05F5D434-55BC-4376-AA99-E2B96DB579FD@apple.com"><commitMessage.patch></span><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 5, 2016, at 11:47 AM, Robinson, Paul <<a href="mailto:paul.robinson@sony.com" class="">paul.robinson@sony.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">Filing a PR for *every* fix is overkill. But filing a PR to express "please merge this to the branch" (if there isn't already a PR) seems reasonable.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">--paulr<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><a name="_MailEndCompose" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></a></div><div style="border-style: none none none solid; border-left-color: blue; border-left-width: 1.5pt; padding: 0in 0in 0in 4pt;" class=""><div class=""><div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><b class=""><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class=""><span class="Apple-converted-space"> </span>llvm-dev [<a href="mailto:llvm-dev-bounces@lists.llvm.org" class="">mailto:llvm-dev-bounces@lists.llvm.org</a>]<span class="Apple-converted-space"> </span><b class="">On Behalf Of<span class="Apple-converted-space"> </span></b>Reid Kleckner via llvm-dev<br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Thursday, May 05, 2016 10:09 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Quentin Colombet<br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span>llvm-dev<br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-dev] [RFC] Helping release management<o:p class=""></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Wed, May 4, 2016 at 5:07 PM, Quentin Colombet via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a>> wrote:<o:p class=""></o:p></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Typically, what I had in mind was things like typos/thinko, that are bugs, that we notice a few minutes after we made the “main” commit. I do not want we have to file a PR that is going to repeat what we are going to say in the commit message.<o:p class=""></o:p></div></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Yeah, I agree, we shouldn't have to file PRs for that kind of stuff. Quick fixes for the build or tests on other platforms obviously fall into this category.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Do release managers have problems keeping track of these kinds of changes in practice, though? You can always cut the branch from some quiescent period on the weekend of night before the cut.</div></div></div></div></div></div></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></body></html>