<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: arial,helvetica,sans-serif; font-size: 10pt; color: #000000'><br><hr id="zwchr"><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Chandler Carruth" <chandlerc@gmail.com><br><b>To: </b>"Quentin Colombet" <qcolombet@apple.com>, "Eric Christopher" <echristo@gmail.com><br><b>Cc: </b>"Pete Cooper" <peter_cooper@apple.com>, "Duncan P. N. Exon Smith" <dexonsmith@apple.com>, "Hal Finkel" <hfinkel@anl.gov>, "Philip Reames" <listmail@philipreames.com>, "Mehdi Amini" <mehdi.amini@apple.com>, "Rafael Espíndola" <rafael.espindola@gmail.com>, "llvm-dev" <llvm-dev@lists.llvm.org><br><b>Sent: </b>Thursday, May 12, 2016 6:11:34 PM<br><b>Subject: </b>Re: [llvm-dev] Deleting function IR after codegen<br><br><div dir="ltr">FWIW, +1 from me as well.<div><br></div><div id="DWT12188">But I don't think you need to make this a module pass or anything else. I think you should leave the husks of the functions around and just nuke the IR out from under them. That way the module surface remains essentially identical. You can also probably nuke all the instructions from BBs with their addresses taken for jump tables, etc.</div></div></blockquote>I agree. We need to be careful about invalidating inter-procedural IR-level analysis results that we make use of using CodeGen (like AA). Consider, for example, the following situation:<br><br> 1. We CodeGen a function foo(), and then remove its IR. During this process, we never used an AA query that reached CFL-AA<br> 2. We CodeGen a function bar(), and bar() calls foo().<br> 3. During (2), we make an AA query on instructions in bar(), which have MMOs with IR Values in bar()<br> 4. CFL-AA is reached and does not have a cached graph for bar(), so it builds one<br> 5. While building the graph for bar(), it reaches the call to foo(), and calls tryInterproceduralAnalysis<br> 6. CFL-AA does not have a cached graph for foo(), so tryInterproceduralAnalysis triggers one to be constructed<br> 7. But foo() is now empty, and so has trivial aliasing properties<br> 8. We return an incorrect AA result when compiling bar()<br><br> -Hal<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><div></div><div><br></div><div>-Chandler<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 8, 2016 at 1:16 PM Quentin Colombet <<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;"><div><blockquote><div>On Mar 8, 2016, at 11:50 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><br>I could attach a patch, but first i’d really like to know if anyone is fundamentally opposed to this.<br>
<br></blockquote><div><br></div><div>Not necessarily. I think that any information that isn't being serialized in MI right now for a function could be as well. Definitely something for GlobalISel to keep in mind.</div></div></div></div></blockquote><div><br></div></div></div><div style="word-wrap: break-word;"><div><div>+1.</div><div>That’s basically where I would like to go with MachineModule/MachineModulePass.</div><div><a href="http://lists.llvm.org/pipermail/llvm-dev/2016-January/094426.html" target="_blank">http://lists.llvm.org/pipermail/llvm-dev/2016-January/094426.html</a></div><div><br></div>Cheers,</div><div>-Quentin</div></div><div style="word-wrap: break-word;"><div><br><blockquote><div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I should note, a couple of issues have come up in the prototype.<br>
- llvm::getDISubprogram was walking the function body to find the subprogram. This is trivial to fix as functions now have !dbg on them.<br></blockquote><div><br></div><div>This is definitely worth it, please go ahead and do this.</div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- The AsmPrinter is calling canBeOmittedFromSymbolTable on GlobalValue’s which then walks all their uses. I think this should be done earlier in codegen as an analysis whose results are available to the AsmPrinter.<br></blockquote><div><br></div><div>I think this makes sense, but I worry about late added GlobalValues during code gen? How would we cope with that? Example: Let's say we start lowering a target specific construct as an MI pass etc and it constructs a global value, when do we run the analysis to make sure that all such things happen? Late as possible I'd assume. Maybe this isn't an issue, but thought I'd bring it up. At any rate, could you provide a bit more detail here?</div><div><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- BB’s whose addresses are taken, i.e. jump tables, can’t be deleted. Those functions will just keep their IR around so no changes there.<br>
<br></blockquote><div><br></div><div>Oh well. Conveniently there aren't a lot of these.</div><div><br></div><div>-eric</div><div><br></div></div></div>
</div></blockquote></div></div></blockquote></div></div></div>
</blockquote><br><br><br>-- <br><div><span name="x"></span>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<span name="x"></span><br></div></div></body></html>