<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 5, 2016, at 10:08 AM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Wed, May 4, 2016 at 5:07 PM, Quentin Colombet via llvm-dev <span dir="ltr" class=""><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">Typically, what I had in mind was things like typos/thinko, that are bugs, that we notice a few minutes after we made the “main” commit. I do not want we have to file a PR that is going to repeat what we are going to say in the commit message.</div></div></blockquote><div class=""><br class=""></div><div class="">Yeah, I agree, we shouldn't have to file PRs for that kind of stuff. Quick fixes for the build or tests on other platforms obviously fall into this category.</div><div class=""><br class=""></div><div class="">Do release managers have problems keeping track of these kinds of changes in practice, though? You can always cut the branch from some quiescent period on the weekend of night before the cut.</div></div></div></div>
</div></blockquote></div><br class=""><div class="">Well, I think the main problem as a release manager is to not miss the follow-up commit.</div><div class=""><br class=""></div><div class="">Say, we branch, then two weeks later a PR comes, it gets fixed and everything is documented into the PR.</div><div class="">The release managers see that and pull that fix into the release.</div><div class=""><br class=""></div><div class="">Then, two days, later we realize we missed a case and do a follow-up commit.</div><div class="">There is a high chance we won’t update the PR and that the release managers will miss it, unless someone/something pings them.</div><div class=""><br class=""></div><div class="">Q.</div></body></html>