<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Note that you already get clickable links in phabricator and when viewing commit messages (depending on the terminal or graphical git client) simply by refering to bugreports with an URL instead of just the number:</div><div class=""><br class=""></div><div class=""><a href="http://llvm.org/PR1234" class="">http://llvm.org/PR1234</a></div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div><blockquote type="cite" class=""><div class="">On May 2, 2016, at 4:05 PM, Reid Kleckner via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">+1 to everything Hans said. We should standardize how we reference bugs from commits, and then get better about tagging the issues in ways that are useful to release managers.<div class=""><div class="gmail_extra"><br class=""></div><div class="gmail_extra">I like the idea of a custom phabricator field, so we can make the references clickable from reviews.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, May 2, 2016 at 3:45 PM, Hans Wennborg via llvm-dev <span dir="ltr" class=""><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, May 2, 2016 at 1:35 PM, Quentin Colombet via llvm-dev<br class="">
<<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class="">
> I am sending this proposal to get feedbacks on how we could make the tagging of bug fixes and regressions more obvious. The idea is to provide easily accessible information to help deciding what to cherry-pick in a release branch.<br class="">
><br class="">
> * Context *<br class="">
><br class="">
> People shipping compilers based on LLVM may not completely align with the official releases of LLVM. Thus, the stabilization of each custom release may happen at different period of time. Because of that, release managers have to come up with their own strategy to decide which commits should be cherry-picked during the stabilization of their release branch.<br class="">
<br class="">
</span>(Unrelated to your proposal, I'm curious how common it is to base<br class="">
releases of LLVM-based tools off the upstream release branches vs.<br class="">
other revisions.)<br class="">
<span class=""><br class="">
> For the official LLVM releases, people (committers, code owners, etc.) notice LLVM release managers that a given commit is worth pulling into the release. I would like to put in place something more systematic and that plays nicely with scripting and such that would extend this mechanism.<br class="">
><br class="">
> * Proposal *<br class="">
><br class="">
> 1. Use [Fix] for commit related to bug fixes.<br class="">
<br class="">
</span>I think we're mostly pretty good at referencing PR's in commit<br class="">
messages already. That's also easy to grep for, so maybe that's good<br class="">
enough?<br class="">
<span class=""><br class="">
> 2. Add a description of the problem in the commit message to help answer the following questions:<br class="">
> - What is fixed?<br class="">
> - Which targets are impacted?<br class="">
> - What is required to trigger the bug? (I.e., how often the end users may encounter it.)<br class="">
> - When was the bug introduced?<br class="">
<br class="">
</span>This sounds like the kind of information that should be in a great<br class="">
commit message anyways.<br class="">
<br class="">
But I'm also thinking that maybe we could be better at using our bug<br class="">
tracker? Whether a bug is a feature request, something that was always<br class="">
broken, or a regression (and from what version), sounds like a perfect<br class="">
fit for a bug tracker. Someone doing a release could then query the<br class="">
Bugzilla to see e.g. what regression bugs were fixed in a certain time<br class="">
span.<br class="">
<span class=""><br class="">
> #1 At the very least, I would like that each bug fix has a tag on the first line of the commit (i.e., what ends up in the subject line of the related email.) Something like [Fix] would do.<br class="">
> Thanks to that tag, it would be possible to easily filter bug fixes in email and other cherry-picking helper tools, I believe.<br class="">
<br class="">
</span>If we really do want to make a guideline about this, I propose we<br class="">
standardize on suffixing the first line of the commit with (PRnnn).<br class="">
<br class="">
Cheers,<br class="">
Hans<br class="">
<div class="HOEnZb"><div class="h5">_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</div></div></blockquote></div><br class=""></div></div></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></body></html>