<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Peter,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> I am afraid I am missing a big picture with debug info cloning.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> Certainly after your patch (and possibly in some cases earlier):<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> Cloning: Reduce complexity of debug info cloning and fix correctness issue.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> Commit r260791 contained an error in that it would introduce a cross-module<o:p></o:p></p><p class=MsoNormal> reference in the old module. It also introduced O(N^2) complexity in the<o:p></o:p></p><p class=MsoNormal> module cloner by requiring the entire module to be visited for each function.<o:p></o:p></p><p class=MsoNormal> Fix both of these problems by avoiding use of the CloneDebugInfoMetadata<o:p></o:p></p><p class=MsoNormal> function (which is only designed to do intra-module cloning) and cloning<o:p></o:p></p><p class=MsoNormal> function-attached metadata in the same way that we clone all other metadata.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> Differential Revision: <a href="http://reviews.llvm.org/D18583">http://reviews.llvm.org/D18583</a><o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>During CloneFunctionInto we seem to create a new DISubprogram which still carries the name of the _<i>original</i>_ function… which creates certain confusion with debugging scope.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Was it designed that way, or am I missing something here… <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Thanks a lot.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Sergei<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>---<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt'>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</span><span style='font-size:10.5pt;font-family:Consolas'><o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>