<div dir="ltr">Hi, Mehdi,<div><br></div><div>I use the following code to generate the IR:</div><div><br></div><div><i> std::vector<Type *> arg_type;</i></div><div><i> std::vector<Value *> margs;</i></div><div><i> margs.push_back(ptr_a);</i></div><div><i> callee = Intrinsic::getDeclaration(mod, Intrinsic::foo5, arg_type);</i></div><div><i> Value *dest_value = Builder.CreateCall(callee, margs);</i></div><div><i> Value *dest_value1 = Builder.CreateCall(callee, margs);</i></div><div><i><br></i></div><div>And even if I add the 'argmemonly' manually, it does not help. The problems come from two places: </div><div>(1) when I use the following code to add the attribute, the attribute is not there in the bit code. Maybe it's because the intrinsic function can only have one attribute?</div><div><br></div><div><div><i> AttributeSet func__Z3fooPi_PAL;</i></div><div><i> {</i></div><div><i> SmallVector<AttributeSet, 4> Attrs;</i></div><div><i> AttributeSet PAS;</i></div><div><i> {</i></div><div><i> AttrBuilder B;</i></div><div><i> B.addAttribute(Attribute::NoUnwind);</i></div><div><i> B.addAttribute(Attribute::ArgMemOnly);</i></div><div><i> PAS = AttributeSet::get(mod->getContext(), ~0U, B);</i></div><div><i> }</i></div><div><i> Attrs.push_back(PAS);</i></div><div><i> func__Z3fooPi_PAL = AttributeSet::get(mod->getContext(), Attrs);</i></div><div><i> }</i></div></div><div><i><br></i></div><div><i><br></i></div><div><i>// this is the new bitcode</i></div><div><div style="font-style:italic">; Function Attrs: nounwind argmemonly</div><div style="font-style:italic">define void @_Z3fooPi(i8* %a) #0 {</div><div style="font-style:italic"> call void @llvm.foo5(i8* %a)</div><div style="font-style:italic"> call void @llvm.foo5(i8* %a)</div><div style="font-style:italic"> ret void</div><div style="font-style:italic">}</div><div style="font-style:italic">; Function Attrs: nounwind</div><div style="font-style:italic">declare void @llvm.foo5(i8*) #1</div><div style="font-style:italic">attributes #0 = { nounwind argmemonly }</div><div style="font-style:italic">attributes #1 = { nounwind }</div><div style="font-style:italic"><br></div><div>(2) when I change the .ll file to add argmemonly'' manually, it does not work either. </div><div><br></div><div>Ane idea?</div><div><br></div><div>Thanks,</div><div><br></div><div>Xiangyang</div><div style="font-style:italic"><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-03-24 13:12 GMT-07:00 Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On Mar 24, 2016, at 12:45 PM, Xiangyang Guo via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> Hi,<br>
><br>
> When I define an intrinsic function with memory write permission, my assumption is that we can either attach [IntrReadWriteArgMem] or [] to the intrinsic function. Based on the comment of the source code , "IntrReadWriteArgMem - This intrinsic reads and writes only from memory that one of its arguments points to, but may access an unspecified amount." "If no property is set, the worst case is assumed (it may read and write any memory it can get access to and it may have other side effects)".<br>
><br>
> But when I define the intrinsic function with different attributes, there is no difference when I dump the IR. For example, two intrinsic functions are<br>
><br>
> def int_foo5 : Intrinsic<[], [llvm_ptr_ty], [IntrReadWriteArgMem]>;<br>
> def int_foo6 : Intrinsic<[], [llvm_ptr_ty], []>;<br>
><br>
> Then I write a very simple module, in each module the intrinsic function is called twice as shown below:<br>
><br>
> /******the intrinsic function foo5 is used******/<br>
> ; Function Attrs: nounwind<br>
> define void @_Z3fooPi(i8* %a) #0 {<br>
> call void @llvm.foo5(i8* %a)<br>
> call void @llvm.foo5(i8* %a)<br>
> ret void<br>
> }<br>
> ; Function Attrs: nounwind<br>
> declare void @llvm.foo5(i8*) #0<br>
> attributes #0 = { nounwind }<br>
<br>
</span>I'd expect foo4 to have the "argmemonly" attribute.<br>
How did you generate this IR?<br>
If you round-trip to bitcode, what happens? I expect the attribute to be added.<br>
<br>
--<br>
Mehdi<br>
<span class=""><br>
<br>
<br>
><br>
><br>
> /****** the intrinsic function foo6 is used******/<br>
> ; Function Attrs: nounwind<br>
> define void @_Z3fooPi(i8* %a) #0 {<br>
> call void @llvm.foo6(i8* %a)<br>
> call void @llvm.foo6(i8* %a)<br>
> ret void<br>
> }<br>
> ; Function Attrs: nounwind<br>
> declare void @llvm.foo6(i8*) #0<br>
> attributes #0 = { nounwind }<br>
><br>
> And my when I apply -O3 optimization level for these two bitcode, I hope the second call can be eliminated. But from the result, it doesn't. For intrinsic functio foo5, I don't understand it. I mean, when I apply [IntrReadWriteArgMem] to this intrinsic function, I hope the LLVM can know the second one is redundant because nothing is changed. Can you tell why LLVM cannot optimize it in this case?<br>
><br>
> Any input is appreciable.<br>
><br>
> Regards,<br>
><br>
> Xiangyang<br>
><br>
><br>
</span>> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
</blockquote></div><br></div>