<div dir="ltr">Could we change the buildbot config to treat warnings-as-errors-that-continue in the build step? (so we get the benefit of further execution tests, while still sending fail-mail, etc for the warning?)</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 22, 2016 at 5:00 PM, David Jones via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Greetings,<div><br></div><div>I would like to propose adding a buildbot which builds with -Werror. The reason for a new buildbot in this configuration is twofold:</div><div><br></div><div>1. It helps users who track and release from ToT, because they (generally) seem to build with -Werror. Speaking from experience :-), new warnings tend to crop up in a large range of commits, and end up blocking one or more of these downstream users. These users also seem to span several organizations, which makes coordination difficult.</div><div><br></div><div>1a. The current buildbots do not build with -Werror so that they will run tests even if warnings are generated. It may or may not be reasonable to enable -Werror by default for buildbots at some point in the future, but I don't think it's quite reasonable to do so yet (judging based on the rate at which new warnings seem to get added, that would leave too many buildbots broken). Adding a buildbot in the -Werror configuration should help to inform any such future changes.</div><div><br></div><div>2. It helps users who develop without -Werror (either by conscious choice or by oversight). Commits which inadvertently add warnings often seem to get reverted; however, if a buildbot can deliver warnings quickly, the committer can submit a small fix right away.</div><div><br></div><div>I have uploaded a diff to Phabricator, however I ask to please keep high-level comments on this thread:</div><div><a href="http://reviews.llvm.org/D18382" target="_blank">http://reviews.llvm.org/D18382</a><br></div><div><br></div><div>This build would be owned and monitored by Google.</div><div><br></div><div>If there are no strong objections in the next few days, I will go ahead with this plan.</div><div><br></div><div>Thanks,</div><div>dlj</div><div><br></div></div>
<br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>