<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
It’s not verified by intrinsic overloading mechanism, but there is an explicit check about masked load and store argument types.
<div class=""><br class="">
</div>
<div class="">Artur<br class="">
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 07 Mar 2016, at 12:42, Demikhovsky, Elena <<a href="mailto:elena.demikhovsky@intel.com" class="">elena.demikhovsky@intel.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<a name="_MailEndCompose" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">I see your point. I’ll try to implement forward reference in intrinsics pattern. Otherwise verifier does not check correlation
between pointer and data types.<span class="Apple-converted-space"> </span><o:p class=""></o:p></span></a></div>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span></div>
<div class="">
<div style="margin: 0cm 0cm 0.0001pt 36pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-indent: -18pt;" class="">
<span style="font-family: Calibri, sans-serif; color: rgb(47, 84, 150);" class=""><span class="">-<span style="font-style: normal; font-variant: normal; font-weight: normal; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';" class=""> <span class="Apple-converted-space"> </span></span></span></span><span dir="LTR" class=""></span><b class=""><i class=""><span style="color: rgb(47, 84, 150);" class=""> Elena<o:p class=""></o:p></span></i></b></div>
</div>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span></div>
<div class="">
<div style="border-style: solid none none; border-top-color: rgb(225, 225, 225); border-top-width: 1pt; padding: 3pt 0cm 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<a name="_____replyseparator" class=""></a><b class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: windowtext;" class="">From:</span></b><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: windowtext;" class=""><span class="Apple-converted-space"> </span>Philip
Reames [<a href="mailto:listmail@philipreames.com" class="">mailto:listmail@philipreames.com</a>]<span class="Apple-converted-space"> </span><br class="">
<b class="">Sent:</b><span class="Apple-converted-space"> </span>Friday, March 04, 2016 21:35<br class="">
<b class="">To:</b><span class="Apple-converted-space"> </span>llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>>; Demikhovsky, Elena <<a href="mailto:elena.demikhovsky@intel.com" class="">elena.demikhovsky@intel.com</a>>;
Artur Pilipenko <<a href="mailto:apilipenko@azulsystems.com" class="">apilipenko@azulsystems.com</a>><br class="">
<b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-dev] Fwd: [PATCH] D17497: Support arbitrary address space for intrinsics<o:p class=""></o:p></span></div>
</div>
</div>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<o:p class=""> </o:p></div>
<p class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 12pt; font-family: 'Times New Roman', serif;">
Per my previous email, I have just signed off on Artur's original patch.<br class="">
<br class="">
Philip<o:p class=""></o:p></p>
<div class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
On 03/02/2016 11:21 AM, Philip Reames via llvm-dev wrote:<o:p class=""></o:p></div>
</div>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class="">
<p class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 12pt; font-family: 'Times New Roman', serif;">
Elena,<br class="">
<br class="">
I'd like to propose that we move forward with<a href="http://reviews.llvm.org/D17270" style="color: purple; text-decoration: underline;" class=""><span class="Apple-converted-space"> </span>Artur's original patch</a><span class="Apple-converted-space"> </span>and
separate the discussion of how we might change our intrinsic naming scheme. Artur's patch is addressing a correctness problem; that has to overrule stylistic concerns. We are seeing failures in our nightly tests due to this issue on an ongoing basis, and
I'd really like to get the correctness issue resolved in the immediate future.<br class="">
<br class="">
I am more than happy to continue the discussion about better naming schemes - in particular, I like you're idea of potentially allowing forward references - but I strongly feel we need to decouple it from a bug fix for a correctness issue.<br class="">
<br class="">
Philip<o:p class=""></o:p></p>
<div class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
On 02/24/2016 09:28 AM, Philip Reames via llvm-dev wrote:<o:p class=""></o:p></div>
</div>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
This probably needs broader discussion. We have an existing naming mechanism for polymorphic intrinsics; Elena is proposing a new one to avoid making the names for various load/store intrinsics particularly ugly. <span class="Apple-converted-space"> </span><br class="">
<br class="">
My personal take:<br class="">
1) I like the cleaner naming scheme.<br class="">
2) I'm not sure the additional complexity is worth it. (Not specific to the particular implementation proposed here.)<br class="">
3) I have no strong preference other than that the @llvm.masked_load (and friends) intrinsics support alternate address spaces in some form in the near future.<br class="">
<br class="">
What do others think?<br class="">
<br class="">
Philip<o:p class=""></o:p></div>
<div class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<br class="">
<br class="">
-------- Forwarded Message --------<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0">
<tbody class="">
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">Subject:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
[PATCH] D17497: Support arbitrary address space for intrinsics<o:p class=""></o:p></div>
</td>
</tr>
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">Date:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
Mon, 22 Feb 2016 08:39:38 +0000<o:p class=""></o:p></div>
</td>
</tr>
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">From:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
Elena Demikhovsky<span class="Apple-converted-space"> </span><a href="mailto:elena.demikhovsky@intel.com" style="color: purple; text-decoration: underline;" class=""><elena.demikhovsky@intel.com></a><o:p class=""></o:p></div>
</td>
</tr>
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">Reply-To:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<a href="mailto:reviews+D17497+public+90f3d1b9468ba8ca@reviews.llvm.org" style="color: purple; text-decoration: underline;" class="">reviews+D17497+public+90f3d1b9468ba8ca@reviews.llvm.org</a><o:p class=""></o:p></div>
</td>
</tr>
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">To:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<a href="mailto:elena.demikhovsky@intel.com" style="color: purple; text-decoration: underline;" class="">elena.demikhovsky@intel.com</a>,<span class="Apple-converted-space"> </span><a href="mailto:apilipenko@azulsystems.com" style="color: purple; text-decoration: underline;" class="">apilipenko@azulsystems.com</a>,<span class="Apple-converted-space"> </span><a href="mailto:listmail@philipreames.com" style="color: purple; text-decoration: underline;" class="">listmail@philipreames.com</a>,<span class="Apple-converted-space"> </span><a href="mailto:ayal.zaks@intel.com" style="color: purple; text-decoration: underline;" class="">ayal.zaks@intel.com</a>,<span class="Apple-converted-space"> </span><a href="mailto:Matthew.Arsenault@amd.com" style="color: purple; text-decoration: underline;" class="">Matthew.Arsenault@amd.com</a>,<span class="Apple-converted-space"> </span><a href="mailto:pjcoup@gmail.com" style="color: purple; text-decoration: underline;" class="">pjcoup@gmail.com</a><o:p class=""></o:p></div>
</td>
</tr>
<tr class="">
<td nowrap="" valign="top" style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; text-align: right;" class="">
<b class="">CC:<span class="Apple-converted-space"> </span><o:p class=""></o:p></b></div>
</td>
<td style="padding: 0cm;" class="">
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<a href="mailto:llvm-commits@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-commits@lists.llvm.org</a><o:p class=""></o:p></div>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 12pt; font-family: 'Times New Roman', serif;">
<o:p class=""> </o:p></p>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">delena created this revision.<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">delena added reviewers: apilipenko, reames, Ayal, arsenm, pjcoup.<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">delena added a subscriber: llvm-commits.<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">delena set the repository for this revision to rL LLVM.<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">This is an alternative proposal for supporting address space in intrinsics. It's applicable for any intrinsic, not only masked-load-store.<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">Related to <a href="http://reviews.llvm.org/D17270" style="color: purple; text-decoration: underline;" class="">http://reviews.llvm.org/D17270</a><o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">I this proposal I add non-zero address space suffix to intrinsic name. The original name looks like<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">@llvm.xxx.xxx<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">The same name with address space 1 :<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">@llvm.xxx.xxx.a_1<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">(I did not update documentation. I'll do this if the proposed change looks reasonable for reviewers ).<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">Repository:<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> rL LLVM<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><a href="http://reviews.llvm.org/D17497" style="color: purple; text-decoration: underline;" class="">http://reviews.llvm.org/D17497</a><o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">Files:<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../include/llvm/IR/IRBuilder.h<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../include/llvm/IR/Intrinsics.h<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../lib/IR/Function.cpp<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../lib/IR/IRBuilder.cpp<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../lib/IR/Verifier.cpp<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""> ../test/Transforms/LoopVectorize/X86/gather_scatter.ll<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><o:p class=""> </o:p></pre>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<o:p class=""> </o:p></div>
</div>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<br class="">
<br class="">
<br class="">
<br class="">
<o:p class=""></o:p></div>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">_______________________________________________<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">LLVM Developers mailing list<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><a href="mailto:llvm-dev@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a><o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="color: purple; text-decoration: underline;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><o:p class=""></o:p></pre>
</blockquote>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<br class="">
<br class="">
<br class="">
<br class="">
<o:p class=""></o:p></div>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">_______________________________________________<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class="">LLVM Developers mailing list<o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><a href="mailto:llvm-dev@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a><o:p class=""></o:p></pre>
<pre style="margin: 0cm 0cm 0.0001pt; font-size: 10pt; font-family: 'Courier New';" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="color: purple; text-decoration: underline;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><o:p class=""></o:p></pre>
</blockquote>
<div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">
<o:p class=""> </o:p></div>
</div>
<p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class="">
---------------------------------------------------------------------<br class="">
Intel Israel (74) Limited</p>
<p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class="">
This e-mail and any attachments may contain confidential material for<br class="">
the sole use of the intended recipient(s). Any review or distribution<br class="">
by others is strictly prohibited. If you are not the intended<br class="">
recipient, please contact the sender and delete all copies.</p>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>