<div dir="ltr">Hi,<div><br></div><div>I will try to prototype your idea to see how SCEV would behave and then get back.</div><div><br></div><div>And sorry for replying very late! Was out on vacation.</div><div><br></div><div>Thank you</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 24, 2016 at 7:48 AM, Adam Nemet <span dir="ltr"><<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Feb 22, 2016, at 6:27 AM, Vikram TV <<a href="mailto:vikram.tarikere@gmail.com" target="_blank">vikram.tarikere@gmail.com</a>> wrote:</div><br><div><br><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">On Fri, Feb 19, 2016 at 10:46 PM, Vikram TV<span> </span><span dir="ltr"><<a href="mailto:vikram.tarikere@gmail.com" target="_blank">vikram.tarikere@gmail.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Thanks for the reply. Few thoughts inlined.</div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Feb 19, 2016 at 8:00 AM, Adam Nemet<span> </span><span dir="ltr"><<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">Hi Vikram,<div><br><div><div><span><blockquote type="cite"><div>On Feb 18, 2016, at 9:21 AM, Vikram TV via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr">Hi all,<div><br></div><div>I have created a patch (up for review at:<span> </span><a href="http://reviews.llvm.org/D17386" target="_blank">http://reviews.llvm.org/D17386</a>) that does Loop Fusion implementation.</div><div><br></div><div>Approach:</div><div>Legality: Currently it can fuse two adjacent loops whose iteration spaces are same and are at same depth. <br></div><div><br></div><div>Dependence legality: Currently, dependence legality cannot be checked across loops. Hence the loops are cloned along a versioned path, unconditionally fused along that path and then the dependence legality is checked on the fused loop keeping the instructions from original loops in context. Fusion is illegal if there is a backward dependence between memory accesses whose source was in first loop and sink was in second loop.</div><div>Currently, LoopAccessAnalysis is used to check dependence legality.</div></div></div></blockquote><div><br></div></span><div>Thanks for writing up the design here.</div><div><br></div><div>I think we have a pretty strong policy against creating temporary instructions and here you actually create an entire loop just to check legality.</div></div></div></div></div></blockquote></span><div>I didn't understand the consequences here. A subsequent DCE pass or explicit removal in this case is taking care of the temporaries. Any pointers in this regard would be helpful.</div></div></div></div></blockquote></div></div></blockquote><div><br></div></span><div>Efficiency? All you need for the legality is the dependences so why not analyze those rather than recreate the entire underlying state from the lowest levels (i.e. instructions) with a bunch of data structures and analyses on top that you will all throw away at the end.</div><div><br></div><div>Here is one pointer: <a href="http://article.gmane.org/gmane.comp.compilers.llvm.cvs/300603" target="_blank">http://article.gmane.org/gmane.comp.compilers.llvm.cvs/300603</a>. You may be able to find more by searching the archives.</div><span class=""><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><div><br></div><div>It would probably be a better design to add the capability of adding two LAI objects together. This would effectively simulate the fusion on the analysis side so you could query the legality from that.</div></div></div></div></div></blockquote></span><div>I am not sure how the underlying analysis like SCEV would behave in this case. As per my understanding, it queries for a particular loop while we have populated accesses from two different loops. But assuming that it works, we would lose the ability to try/test using DependenceAnalysis in future. Currently, it is very easy to replace LoopAccessAnalysis with DependenceAnalysis.</div></div></div></div></blockquote></div></div></blockquote><div><br></div></span><div>Yes, the SCEV part could be problematic. I am wondering if LAA could analyze pointers on the same underlying object without calling SCEV’s getMinusSCEV(). E.g. deciding that the the dependence distance is 1 between {A, +, 1}<L1> and {A+1, +, 1}<L2> assuming we added those two recurrences in the same loop should not be hard.</div><div><br></div><div>I would certainly prefer keeping the heavy lifting for this outside of ScalarEvolution which is already pretty complex. We could of course still refactor parts of SCEV if that it is helpful for LAA to work this out.</div><div><br></div><div>I am not sure I understand your LAA, DA argument. They are already pretty different (e.g. memchecks). I see DA more of a drop-in for MemoryDepChecker inside LAA.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Adam</div></font></span><div><div class="h5"><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><div><br></div><div>Specifically, you could check if you have backward dependences between instructions in L2 to instructions in L1 which would be illegal.</div><div><br></div><div>As a side effect you’d also get the total set of memchecks which you could filter to only include checks where the participating pointers come from different loops. (This is quite similar to LoopDistribution.)</div></div></div></div></div></blockquote></span><div>I am happy to add a routine in a subsequent patch that filter the checks.</div></div></div></div></blockquote><div>Just to clarify, I meant to filter the runtime checks which is currently not done in the patch.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><div><br></div><div>Also I don’t think it should be too hard to teach LVer to be able to version two consecutive loops (or arbitrary CFG?).</div></div></div></div></div></blockquote></span><div>I think yes. Instead of Loop Versioning deciding to version, code can be factored out so that it versions unconditionally "also" as requested by the pass that uses it. </div><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><div><br></div><div>Let me know what you think,</div><div>Adam</div><div><br></div><blockquote type="cite"><div><div><div><div dir="ltr"><div><br></div><div>A basic diagram below tries to explain the approach taken to test dependence legality on two adjacent loops (L1 and L2).</div><div><br></div><div><div> <span> </span>L1PH (PH: Preheader)</div><div> <span> </span>| </div><div> <span> </span>L1 </div><div> <span> </span>| </div><div> <span> </span>CB (L1Exit/L2PH: ConnectingBlock (CB) )</div><div> <span> </span>| </div><div> <span> </span>L2 </div><div> <span> </span>| </div><div> <span> </span>L2Exit</div></div><div><br></div><div>is versioned as:</div><div><br></div><div><div> <span> </span>BooleanBB </div><div> <span> </span>/\ </div><div> L1PH L1PH.clone</div><div> | | </div><div> <span> </span>L1 L1.clone </div><div> | | </div><div> <span> </span>CB CB.clone </div><div> | | </div><div> <span> </span>L2 L2.clone </div><div> <span> </span>\ / </div><div> L2Exit</div></div><div><br></div><div>And fused as:</div><div><div><br></div><div> <span> </span>BooleanBB </div><div> <span> </span>/\</div><div> L1PH FusedPH</div><div> | |</div><div> <span> </span>L1 L1Blocks</div><div> | | \</div><div> CB L2Blocks |</div><div> | | |/</div><div> <span> </span>L2 |</div><div> \ /</div><div> CommonExit</div></div><div><br></div><div>Profitability: Yet to be added.</div><div><br></div><div>Further, based on legality and profitability success, the fused loop is either retained or removed. If runtime checks are necessary, both original and fused loops are retained; otherwise the original loops are removed.</div><div><br></div><div>Currently, I have scheduled the fusion pass after distribution pass. Such a schedule negates the effect of the other pass, but given that the distribution (and fusion) pass is experimental and off by default, I felt it was okay to schedule that way till a global profitability is implemented.</div><div><br></div><div>Please share your feedback about the design and implementation.</div><div><br></div><div>Thank you</div><div>-- <br></div><div><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>Good time...</div><div>Vikram TV</div><div>CompilerTree Technologies</div><div>Mysore, Karnataka, INDIA</div></div></div></div></div></div></div></div></div>_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br></div></blockquote></div><br></div></div></div></blockquote></div></div></div><div><div><br><br clear="all"><div><br></div>--<span> </span><br><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>Good time...</div><div>Vikram TV</div><div>CompilerTree Technologies</div><div>Mysore, Karnataka, INDIA</div></div></div></div></div></div></div></div></div></blockquote></div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br clear="all" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">--<span> </span></span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div dir="ltr"><div><div dir="ltr"><div><br></div><div>Good time...</div><div>Vikram TV</div><div>CompilerTree Technologies</div><div>Mysore, Karnataka, INDIA</div></div></div></div></div></div></blockquote></div></div></div><br></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><br></div><div>Good time...</div><div>Vikram TV</div><div>CompilerTree Technologies</div><div>Mysore, Karnataka, INDIA</div></div></div></div></div>
</div>