<div dir="ltr">I need some help figuring out existing pass problem.  I've submitted a CL on Friday (<a href="http://reviews.llvm.org/rL262103" class="cremed">http://reviews.llvm.org/rL262103</a>) that broke _only_ armv7 & aarch64 bots: "Pass 'SanitizerCoverageModule' is not initialized." (it was rolled back).  <div><div><br></div><div>Today I've obtained access to aarch64 machine today, applied the patch and check-all passes without any issues (terminal capture at the end). <div><br></div><div>Could there be something wrong with these bots? Do you have any idea what to try?</div><div><div><br></div><div><div>=== Build Failure ===</div><div></div></div><div><br></div><div>It was failing with this error (<a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1493/steps/ninja%20check%201/logs/stdio">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1493/steps/ninja%20check%201/logs/stdio</a>):</div><div><br></div><div><div>Pass 'SanitizerCoverageModule' is not initialized.</div><div>Verify if there is a pass dependency cycle.</div><div>Required Passes:</div><div>clang-3.9: /home/renato.golin/buildslave/clang-cmake-aarch64-full/llvm/lib/IR/LegacyPassManager.cpp:668: void llvm::PMTopLevelManager::schedulePass(llvm::Pass*): Assertion `PI && "Expected required passes to be initialized"' failed.</div><div>#0 0x00000000014de8a8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/bin/clang-3.9+0x14de8a8)</div><div>Stack dump:</div><div>0.<span class="Apple-tab-span" style="white-space:pre">  </span>Program arguments: /home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/bin/clang-3.9 -cc1 -triple aarch64-unknown-linux-gnu -emit-obj -mrelax-all -disable-free -main-file-name coverage-caller-callee.cc -mrelocation-model static -mthread-model posix -mdisable-fp-elim -mdisable-tail-calls -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu generic -target-feature +neon -target-abi aapcs -dwarf-column-info -debug-info-kind=line-tables-only -dwarf-version=4 -debugger-tuning=gdb -resource-dir /home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/bin/../lib/clang/3.9.0 -internal-isystem /usr/lib/gcc/aarch64-linux-gnu/4.9/../../../../include/c++/4.9 -internal-isystem /usr/lib/gcc/aarch64-linux-gnu/4.9/../../../../include/aarch64-linux-gnu/c++/4.9 -internal-isystem /usr/lib/gcc/aarch64-linux-gnu/4.9/../../../../include/aarch64-linux-gnu/c++/4.9 -internal-isystem /usr/lib/gcc/aarch64-linux-gnu/4.9/../../../../include/c++/4.9/backward -internal-isystem /usr/local/include -internal-isystem /home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/bin/../lib/clang/3.9.0/include -internal-externc-isystem /usr/include/aarch64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -fdebug-compilation-dir /home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/projects/compiler-rt/test/asan/AARCH64LinuxConfig/TestCases/Posix -ferror-limit 19 -fmessage-length 0 -fsanitize-coverage-type=3 -fsanitize-coverage-indirect-calls -fsanitize=address -fsanitize-blacklist=/home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/bin/../lib/clang/3.9.0/asan_blacklist.txt -fno-assume-sane-operator-new -fallow-half-arguments-and-returns -fno-signed-char -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -o /tmp/coverage-caller-callee-72b4a0.o -x c++ /home/renato.golin/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/test/asan/TestCases/Posix/coverage-caller-callee.cc </div><div>1.<span class="Apple-tab-span" style="white-space:pre">      </span><eof> parser at end of file</div><div>clang-3.9: error: unable to execute command: Aborted</div><div>clang-3.9: error: clang frontend command failed due to signal (use -v to see invocation)</div><div>clang version 3.9.0 (trunk 262106)</div><div>Target: aarch64-unknown-linux-gnu</div><div>Thread model: posix</div><div>InstalledDir: /home/renato.golin/buildslave/clang-cmake-aarch64-full/stage1/./bin</div><div>clang-3.9: note: diagnostic msg: PLEASE submit a bug report to <a href="http://llvm.org/bugs/">http://llvm.org/bugs/</a> and include the crash backtrace, preprocessed source, and associated run script.</div><div>clang-3.9: note: diagnostic msg: </div><div><br></div><div><br></div><div>=== Successful Run ===</div><div><div><br></div><div><div>% uname -a</div><div>Linux <host_name> 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:38:11 UTC 2015 aarch64 aarch64 aarch64 GNU/Linux</div><div><br></div><div>% ninja check-llvm                                       </div><div>[24/24] Running the LLVM regression tests</div><div>Testing Time: 110.50s</div><div>  Expected Passes    : 15324</div><div>  Expected Failures  : 127</div><div>  Unsupported Tests  : 511</div><div>keplerarm1% ninja check-all </div><div>[1/1] Running all regression tests</div><div>Testing Time: 109.94s</div><div>  Expected Passes    : 15324</div><div>  Expected Failures  : 127</div><div>  Unsupported Tests  : 511</div></div><div><div>% git status</div><div>On branch master</div><div>Your branch is up-to-date with 'origin/master'.</div><div><br></div><div>Changes not staged for commit:</div><div>  (use "git add <file>..." to update what will be committed)</div><div>  (use "git checkout -- <file>..." to discard changes in working directory)</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre">    </span>modified:   lib/Transforms/Instrumentation/SanitizerCoverage.cpp</div></div><div><br></div><div><br><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Feb 27, 2016 at 9:00 AM Mike Aizatsky <<a href="mailto:aizatsky@chromium.org" target="_blank" class="cremed">aizatsky@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Renato,<div><br></div><div>I did. And I thought I fixed it in <a href="http://reviews.llvm.org/rL262111" target="_blank" class="cremed">http://reviews.llvm.org/rL262111</a> (as soon as I got breakage notification).</div><div><br></div><div>There's something wrong with those architectures. There are no problems on others. I'll take better look on Monday.</div></div><div dir="ltr"><div><br></div><div class="gmail_quote"><div dir="ltr">On Sat, Feb 27, 2016 at 6:25 AM Renato Golin <<a href="mailto:renato.golin@linaro.org" target="_blank" class="cremed">renato.golin@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 27 February 2016 at 02:10, Mike Aizatsky via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: aizatsky<br>
> Date: Fri Feb 26 20:10:27 2016<br>
> New Revision: 262103<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262103&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=262103&view=rev</a><br>
> Log:<br>
> [sancov] do not instrument nodes that are full pre-dominators<br>
><br>
> Summary:<br>
> Without tree pruning clang has 2,667,552 points.<br>
> Wiht only dominators pruning: 1,515,586.<br>
> With both dominators & predominators pruning: 1,340,534.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D17671" rel="noreferrer" target="_blank" class="cremed">http://reviews.llvm.org/D17671</a><br>
<br>
I've just reverted this patch in r262139, as it broke all ARM and<br>
AArch64 buildbots. Please, pay attention to the bots and contact the<br>
owner or revert on the first sign of trouble.<br>
<br>
cheers,<br>
--renato<br>
</blockquote></div></div></blockquote></div></div></div></div></div></div></div>