<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Ah - I do commit to the test-suite from time to time.<br>
So, could the github-based project be set up so that we can just do
'git push'? Or would we have to go through the pull requests route
on every commit?<br>
I'm afraid I've never committed to any github project before, so I
am a bit confused on how committing would work in practice.<br>
Obviously, I hope for the mechanism to commit to be simple - e.g.
just do a git push from the command line.<br>
<br>
Before making the decision to move the repo, I think this part also
should be sorted out.<br>
<br>
<div class="moz-cite-prefix">On 25/02/2016 09:50, Chandler Carruth
wrote:<br>
</div>
<blockquote
cite="mid:CAAwGriFVKZh8wOMhNW_XT92y91Lq2Yv2acuEmDDu2Qma1mp_Zw@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">Yes, I would hope that for most this boils down to
cloning a different URL. Except for folks pushing patches to the
test suite, I'm moderately confident there would be no other
difference.
<div><br>
</div>
<div>It's the pushing patches side that would need to be sorted
out in more detail.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Feb 25, 2016 at 12:48 AM Kristof Beyls
<<a moz-do-not-send="true"
href="mailto:kristof.beyls@arm.com">kristof.beyls@arm.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> My biggest concerns and
care-abouts are largely what Matthias expressed below.<br>
Most of them have been addressed already further down the
thread.<br>
<br>
I hope that the move to github in practice would mean that
the only difference is that I 'git clone <a
moz-do-not-send="true" href="https://github"
target="_blank"><a class="moz-txt-link-freetext" href="https://github">https://github</a></a>...' instead of 'git
clone <a moz-do-not-send="true"
href="http://llvm.org/git/test-suite.git" target="_blank">http://llvm.org/git/test-suite.git</a>'
?<br>
<br>
Thanks,<br>
<br>
Kristof</div>
<div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<div>On 24/02/2016 22:25, Matthias Braun via llvm-dev wrote:<br>
</div>
<blockquote type="cite">
<div>I don't really care where the repository is located,
but I do have some comments on the future test-suite
directions:</div>
<div><br>
</div>
<div>
<blockquote type="cite">
<div>On Feb 24, 2016, at 12:57 PM, Chandler Carruth
via llvm-dev <<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org"
target="_blank">llvm-dev@lists.llvm.org</a>>
wrote:</div>
<br>
<div>
<div dir="ltr">Subject kinda says it all. Here is my
rationale:
<div><br>
</div>
<div>The test-suite is really weird relative to
the rest of the LLVM project:</div>
<div>1) It contains all manner of crazily licensed
code.<br>
</div>
</div>
</div>
</blockquote>
<div>That's indeed a good reason to move the repository
away.</div>
<div><br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">
<div>2) We don't really care about the history at
all. Any concerns around linear history or
bisection are pretty much irrelevant.</div>
</div>
</div>
</blockquote>
<div>We do care about the history. Sometimes benchmarks
get fixed or tweaked which may change the results, we
should be able to dig into the history to see what
happened when. In any way retaining the history
wouldn't be a problem, would it?</div>
<div><br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">
<div>3) We don't ever plan to have LLVM code move
into or out from the test-suite</div>
</div>
</div>
</blockquote>
<div>I could actually see moving llvm code into the
test-suite (we already use lit code from llvm) but
indeed move code out of the testsuite into llvm I
don't foresee happening.</div>
<br>
<blockquote type="cite">
<div>
<div dir="ltr">
<div>4) Its already big, and really should be much
bigger. We shouldn't have incentives to keep
stuff out of the test suite because of size,
hosting cost, or anything else.</div>
</div>
</div>
</blockquote>
<div>I agree with the goal of having a big test-suite.
However I think there is a point where we should
rather strive to have a stable base system for
building and running tests, etc. and then have the
actual benchmarks/tests being modules on top of that.
We already have that situation today with
External/SPEC* and I think it would be a good idea to
have a mode where you just checkout more benchmarks
into a test-suite subdirectory and they are
automatically recognized and used (in fact that is
something on my TODO list though at a very low
position).</div>
<div><br>
</div>
<div>- Matthias</div>
<div><br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">
<div><br>
</div>
<div>For all of these reasons, and also because
I'd like to see how well (or rather, how poorly)
a service like GitHub actually works for the
project, it seems like splitting the test-suite
out of the current subversion repository and
moving it there is the right call.</div>
<div><br>
</div>
<div>When I chatted with folks on the board, this
made sense to them as well, and I've made sure
we have a reasonable LLVM organization set up on
GitHub and all the board members are on it: <a
moz-do-not-send="true"
href="https://github.com/llvm" target="_blank"><a class="moz-txt-link-freetext" href="https://github.com/llvm">https://github.com/llvm</a></a>
(I think only my membership is public at the
moment).</div>
<div><br>
</div>
<div>There is still plenty to figure out about how
to manage this on github, but before doing
anything else I just wanted to shoot an email
and see if folks like this idea.</div>
<div><br>
</div>
<div>Thanks!</div>
<div>-Chandler</div>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-dev@lists.llvm.org"
target="_blank">llvm-dev@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
LLVM Developers mailing list
<a moz-do-not-send="true" href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>