<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Good catch, Thanks.<div class=""><br class=""></div><div class="">Here’s the updated patch:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">Index: lib/Support/TargetParser.cpp</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">===================================================================</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">--- lib/Support/TargetParser.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 257090)</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+++ lib/Support/TargetParser.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">@@ -400,7 +400,7 @@</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> return StringSwitch<StringRef>(Arch)</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> .Case("v5", "v5t")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> .Case("v5e", "v5te")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">- .Case("v6j", "v6")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+ .Case("v6j", "v6l", "v6")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> .Case("v6hl", "v6k")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> .Cases("v6m", "v6sm", "v6s-m", "v6-m")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> .Cases("v6z", "v6zk", "v6kz")</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">Index: unittests/ADT/TripleTest.cpp</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">===================================================================</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">--- unittests/ADT/TripleTest.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 257090)</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+++ unittests/ADT/TripleTest.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">@@ -851,6 +851,10 @@</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+ llvm::Triple Triple("armv6l-unknown-eabi");</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+ EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+ }</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">+ {</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> llvm::Triple Triple("armv6j-unknown-eabi");</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""> }</div></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 11, 2016, at 1:37 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com" class="">Artyom.Skrobov@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">Hello William – I have a minor comment on your patch:<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v6j", "v6")<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v6l", "v6")<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">may be written more concisely as<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Cases("v6j", "v6l", "v6")<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""><o:p class=""> </o:p></span></div><div class=""><div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0cm 0cm;" class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><b class=""><span lang="EN-US" style="font-size: 10pt; font-family: Tahoma, sans-serif;" class="">From:</span></b><span lang="EN-US" style="font-size: 10pt; font-family: Tahoma, sans-serif;" class=""><span class="Apple-converted-space"> </span>William Dillon [<a href="mailto:william@housedillon.com" class="">mailto:william@housedillon.com</a>]<span class="Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>08 January 2016 18:56<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Bob Wilson<br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span>Eric Christopher; Artyom Skrobov; Renato Golin; Tim Northover; LLVM Dev; nd; Daniel Sanders; Frederic Riss<br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-dev] Diff to add ARMv6L to Target parser<o:p class=""></o:p></span></div></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Thanks for the clarifications, Bob!<o:p class=""></o:p></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">I’ve spent some time with the head of the<span class="Apple-converted-space"> </span><a href="http://llvm.org/" style="color: purple; text-decoration: underline;" class="">llvm.org</a><span class="Apple-converted-space"> </span>repo, and I now understand a lot better what Renato and Tim were talking about re. the architecture aliases. The patch to add v6l, therefore, seems simple enough. I haven’t been able to test it in my usual flow, because that involves the whole swift stack. I’m considering creating a program that links to llvm to test the behavior. <o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">Index: lib/Support/TargetParser.cpp<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">===================================================================<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">--- lib/Support/TargetParser.cpp<span class="apple-tab-span"> <span class="Apple-converted-space"> </span></span>(revision 257090)<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+++ lib/Support/TargetParser.cpp<span class="apple-tab-span"> <span class="Apple-converted-space"> </span></span>(working copy)<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">@@ -401,6 +401,7 @@<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v5", "v5t")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v5e", "v5te")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v6j", "v6")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+ .Case("v6l", "v6")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Case("v6hl", "v6k")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Cases("v6m", "v6sm", "v6s-m", "v6-m")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> .Cases("v6z", "v6zk", "v6kz")<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">Index: unittests/ADT/TripleTest.cpp<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">===================================================================<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">--- unittests/ADT/TripleTest.cpp<span class="apple-tab-span"> <span class="Apple-converted-space"> </span></span>(revision 257090)<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+++ unittests/ADT/TripleTest.cpp<span class="apple-tab-span"> <span class="Apple-converted-space"> </span></span>(working copy)<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">@@ -851,6 +851,10 @@<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> }<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> {<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+ llvm::Triple Triple("armv6l-unknown-eabi");<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+ EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+ }<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class="">+ {<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> llvm::Triple Triple("armv6j-unknown-eabi");<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""> }<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 8.5pt; font-family: Menlo, serif;" class=""><o:p class=""> </o:p></span></div></div></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">I looked into the tests (and unit tests), and found that perhaps the most appropriate test to add is in the determination of the cpu type from the architecture version. I verified that ARM1136 is the base for ARM11, which is all that can be assumed given armv6. That jives with the existing armv6 architecture test. I added another copy of that for armv6l. I assume that this will sufficiently test whether armv6l is aliasing correctly to armv6.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Anyway, thanks again.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">- Will<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Jan 8, 2016, at 10:16 AM, Bob Wilson <<a href="mailto:bob.wilson@apple.com" style="color: purple; text-decoration: underline;" class="">bob.wilson@apple.com</a>> wrote:<o:p class=""></o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Jan 7, 2016, at 2:21 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" style="color: purple; text-decoration: underline;" class="">echristo@gmail.com</a>> wrote:<o:p class=""></o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div class=""><p class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p class=""> </o:p></p><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Thu, Jan 7, 2016 at 2:17 PM William Dillon <<a href="mailto:william@housedillon.com" style="color: purple; text-decoration: underline;" class="">william@housedillon.com</a>> wrote:<o:p class=""></o:p></div></div><blockquote style="border-style: none none none solid; border-left-color: rgb(204, 204, 204); border-left-width: 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Yikes!!<o:p class=""></o:p></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">It looks like things have changed considerably! I’ll need to start this from scratch. A few questions, though:<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">I have a goal for this to be in the Swift 2.2 release, is that feasible?<o:p class=""></o:p></div></div></div></blockquote></div></div></div></blockquote><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Maybe. We’re using an older version of llvm/clang for Swift 2.2 to give us a stable platform to work with, but if you get a change into trunk first, and if it is relatively low-risk, we could consider back-porting it to the release branch for Swift 2.2. We do want to be careful to avoid destabilizing the branch, though, and the criteria for accepting changes will only get more strict over time.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><br class=""><br class=""><o:p class=""></o:p></div><div class=""><div class=""><div class=""><blockquote style="border-style: none none none solid; border-left-color: rgb(204, 204, 204); border-left-width: 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;" class=""><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">If so, will the current LLVM head end up in the branch for 2.2 when that time comes?<o:p class=""></o:p></div></div></div></blockquote></div></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">No. We already created the llvm/clang release branches to be used with Swift 2.2 to give us a longer time to stabilize them. We do not plan to rebranch again from trunk for Swift 2.2.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><br class=""><br class=""><o:p class=""></o:p></div><div class=""><div class=""><div class=""><blockquote style="border-style: none none none solid; border-left-color: rgb(204, 204, 204); border-left-width: 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;" class=""><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Given that the coordination costs to attempt any kind of change in swift that requires a change in LLVM are so high, I’m tempted to keep the logic of stripping the ‘l’s from armv7l and armv6l inside swift itself. It really seems like the wrong approach, but sometimes the wrong answer is the best answer, depending on the circumstances.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div></div></blockquote><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">For all of these questions you should talk to Bob Wilson who is the llvm release manager for the swift project.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">-eric<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""> <o:p class=""></o:p></div></div><blockquote style="border-style: none none none solid; border-left-color: rgb(204, 204, 204); border-left-width: 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;" class=""><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">- Will<o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Jan 7, 2016, at 10:05 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" style="color: purple; text-decoration: underline;" class="">echristo@gmail.com</a>> wrote:<o:p class=""></o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">The swift repository is old and many thousand revisions behind llvm. Please don't use it as a base when submitting to the llvm project.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Thu, Jan 7, 2016, 10:02 AM William Dillon <<a href="mailto:william@housedillon.com" target="_blank" style="color: purple; text-decoration: underline;" class="">william@housedillon.com</a>> wrote:<o:p class=""></o:p></div></div><blockquote style="border-style: none none none solid; border-left-color: rgb(204, 204, 204); border-left-width: 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Oops, I neglected to reply-all….<o:p class=""></o:p></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">The current stable branch at github still has it:<o:p class=""></o:p></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><a href="https://github.com/apple/swift-llvm/blob/stable/include/llvm/Support/ARMTargetParser.def#L106" target="_blank" style="color: purple; text-decoration: underline;" class="">https://github.com/apple/swift-llvm/blob/stable/include/llvm/Support/ARMTargetParser.def#L106</a><o:p class=""></o:p></div></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Should I get the head of the non-swift repository and generate a new diff?<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Also, I suspect that it’s not a good idea to have armv6l map to armv6k, because that seems like quite an assumption to make. Clearly, armv6 sub architectures that aren’t v6k will still be v6l in linux. (provided they’re little-endian).<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">I’ve already made that change, and it would be included in any revised diff that I send out.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">Thanks,<o:p class=""></o:p></div></div><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">- Will<o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Jan 6, 2016, at 10:02 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com" target="_blank" style="color: purple; text-decoration: underline;" class="">Artyom.Skrobov@arm.com</a>> wrote:<o:p class=""></o:p></div></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div class=""><p class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 12pt; font-family: 'Times New Roman', serif;">William, what revision of LLVM is your patch based on?<br class=""><br class="">The trunk hasn't had ARM_ARCH("armv6hl") since r252903 (Nov 12th)<br class=""><br class=""><br class="">-----Original Message-----<br class="">From: William Dillon [<a href="mailto:william@housedillon.com" target="_blank" style="color: purple; text-decoration: underline;" class="">mailto:william@housedillon.com</a>]<span class="Apple-converted-space"> </span><br class="">Sent: 06 January 2016 17:55<br class="">To: Renato Golin<br class="">Cc: Tim Northover; LLVM Dev; nd; Artyom Skrobov; Daniel Sanders; Eric Christopher<br class="">Subject: Re: [llvm-dev] Diff to add ARMv6L to Target parser<br class=""><br class="">Taking the suggestions of the group under consideration, I’ve generated a new diff. The thing to note is that armv6l is now treated identically to armv6hl. I’ve also added a unit test.<br class="">This seems to me to be the least invasive method, and holds to existing conventions as closely as possible.<br class=""><br class="">Thoughts?</p></div></div></blockquote></div></div></div></blockquote></div></div></blockquote></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div></div></div></div></blockquote></div><br class=""></div></body></html>