<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">I don't know much about the autoconf build system but the configure changes are probably unrelated. The search order for this is in llvm::DisplayGraph() in lib/Support/GraphWriter.cpp.<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF225995"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Ryan Taylor [ryta1203@gmail.com]<br>
<b>Sent:</b> 12 August 2015 16:20<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> llvm-dev@lists.llvm.org<br>
<b>Subject:</b> Re: [llvm-dev] Fwd: [LLVMdev] SelectionDAG viewers, filter-view-dags question<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div>Hello,</div>
<div><br>
</div>
<div> It looks like doing a diff on the llvm configure that there were some changes in regards to DOTTY and XDOT and some additions of DOT?</div>
<div><br>
</div>
<div>Thanks.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Aug 11, 2015 at 5:53 AM, Daniel Sanders <span dir="ltr">
<<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div lang="EN-GB">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">Hi,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">It's changed a few times over the last year. I believe xdg-open spawns whichever application your desktop environment would use to open the file so you should be able to
tell it to use dotty.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<div style="border:none; border-left:solid blue 1.5pt; padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none; border-top:solid #b5c4df 1.0pt; padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US"> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Ryan Taylor via llvm-dev<br>
<b>Sent:</b> 11 August 2015 00:30<br>
<b>To:</b> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<b>Subject:</b> [llvm-dev] Fwd: [LLVMdev] SelectionDAG viewers, filter-view-dags question<u></u><u></u></span></p>
</div>
</div>
<div>
<div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">Ok, I'm getting this error now, it won't open in dotty like it used to in 3.4. Did the program preference order change?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">says:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">/usr/bin/xdg-open: line 402: htmlview: command not found<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">console.error<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> [CustomizableUI]<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> Custom widget with id loop-button does not return a valid node<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Has anyone else run into this issue? (again, this problem does not exist if I revert to 3.4 but I'm not sure it's an llvm issue either, I really don't know)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><br>
Thanks.<u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Sat, Aug 1, 2015 at 3:47 PM, Ryan Taylor <<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>> wrote:<u></u><u></u></p>
<p>Ah, I missed that subltety. Thanks. <u></u><u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">On Aug 1, 2015 2:43 PM, "Mehdi Amini" <<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>> wrote:<u></u><u></u></p>
<div>
<p class="MsoNormal">The diff is not only the && and || but also the leading !:<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>
index 58f029fbe9fc..7ee06fc153b2 100644<br>
--- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>
+++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>
@@ -659,7 +659,7 @@ void SelectionDAGISel::CodeGenAndEmitDAG() {<br>
(void)BlockNumber;<br>
bool MatchFilterBB = false; (void)MatchFilterBB;<br>
#ifndef NDEBUG<br>
- MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&<br>
+ MatchFilterBB = (FilterDAGBasicBlockName.empty() ||<br>
FilterDAGBasicBlockName ==<br>
FuncInfo->MBB->getBasicBlock()->getName().str());<br>
#endif<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">— <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Mehdi<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<div>
<p class="MsoNormal">On Aug 1, 2015, at 11:07 AM, Ryan Taylor <<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">Simply replacing the && with || did not fix the issue. This issue still exists after making those changes. There is maybe some other code that needs to be changed also?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Jul 27, 2015 at 12:45 PM, Ryan Taylor <<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Daniel,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"> Ok, thanks. Simple fix. We'll just make correction in local copy for now, one less thing to port later :)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks.<u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Jul 27, 2015 at 12:29 PM, Daniel Sanders <<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">I've just looked at my checkout of 3.6 and it looks like the fix wasn't merged. I don't have the revision number for the fix to hand but in lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp,
this:</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> FilterDAGBasicBlockName ==</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> FuncInfo->MBB->getBasicBlock()->getName().str());</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">Should be:</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> MatchFilterBB = (FilterDAGBasicBlockName.empty() ||</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> FilterDAGBasicBlockName ==</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> FuncInfo->MBB->getBasicBlock()->getName().str());</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">The trunk has the correct code so the option should be ok for LLVM 3.7.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> </span><u></u><u></u></p>
<div style="border:none; border-left:solid windowtext 1.5pt; padding:0cm 0cm 0cm 4.0pt; border-color:currentColor currentColor currentColor blue">
<div>
<div style="border:none; border-top:solid windowtext 1.0pt; padding:3.0pt 0cm 0cm 0cm; border-color:currentColor currentColor">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US"> Ryan Taylor [mailto:<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>]
<br>
<b>Sent:</b> 27 July 2015 17:20<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [LLVMdev] SelectionDAG viewers, filter-view-dags question</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Daniel,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> We are using 3.6. Someone also pointed out that it was mandatory in 3.6.2 but I have not verified that.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Mon, Jul 27, 2015 at 12:10 PM, Daniel Sanders <<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">It's not supposed to be. There was a short period where it was unintentionally mandatory but this was fixed after I pointed it out during post-commit review.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"">Which version/revision are you using?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif""> </span><u></u><u></u></p>
<div style="border:none; border-left:solid windowtext 1.5pt; padding:0cm 0cm 0cm 4.0pt; border-color:currentColor currentColor currentColor blue">
<div>
<div style="border:none; border-top:solid windowtext 1.0pt; padding:3.0pt 0cm 0cm 0cm; border-color:currentColor">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">
<a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Ryan Taylor<br>
<b>Sent:</b> 27 July 2015 16:27<br>
<b>To:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> [LLVMdev] SelectionDAG viewers, filter-view-dags question</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Is this option currently mandatory? If so, why? If not, I'm not sure what's been added that I need to do differently.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">-view-isel-dags opened just fine in dotty in 3.4 and now this does nothing without the filter-view-dags 'option' and now has a different priority program list or something.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I'm just curious why this option should be mandatory?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks.<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>