<div dir="ltr"><div class="gmail_quote"><br><div dir="ltr"><div>Ok, I'm getting this error now, it won't open in dotty like it used to in 3.4. Did the program preference order change?</div><div><br></div><div>says:</div><div><br></div><div>/usr/bin/xdg-open: line 402: htmlview: command not found</div><div>console.error</div><div> [CustomizableUI]</div><div> Custom widget with id loop-button does not return a valid node</div><div><br></div><div>Has anyone else run into this issue? (again, this problem does not exist if I revert to 3.4 but I'm not sure it's an llvm issue either, I really don't know)</div><div><br>Thanks.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 1, 2015 at 3:47 PM, Ryan Taylor <span dir="ltr"><<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Ah, I missed that subltety. Thanks. </p><div><div>
<div class="gmail_quote">On Aug 1, 2015 2:43 PM, "Mehdi Amini" <<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">The diff is not only the && and || but also the leading !:<div><br></div><div><br></div><div>diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>index 58f029fbe9fc..7ee06fc153b2 100644<br>--- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>+++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>@@ -659,7 +659,7 @@ void SelectionDAGISel::CodeGenAndEmitDAG() {<br> (void)BlockNumber;<br> bool MatchFilterBB = false; (void)MatchFilterBB;<br> #ifndef NDEBUG<br>- MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&<br>+ MatchFilterBB = (FilterDAGBasicBlockName.empty() ||<br> FilterDAGBasicBlockName ==<br> FuncInfo->MBB->getBasicBlock()->getName().str());<br> #endif<br><br><div><br></div><div>— </div><div>Mehdi</div><div><br></div><div><br></div><div><br><blockquote type="cite"><div>On Aug 1, 2015, at 11:07 AM, Ryan Taylor <<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><div>Simply replacing the && with || did not fix the issue. This issue still exists after making those changes. There is maybe some other code that needs to be changed also?</div><div><br></div><div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 27, 2015 at 12:45 PM, Ryan Taylor <span dir="ltr"><<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Daniel,</div><div><br></div><div> Ok, thanks. Simple fix. We'll just make correction in local copy for now, one less thing to port later :)</div><div><br></div><div>Thanks.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 27, 2015 at 12:29 PM, Daniel Sanders <span dir="ltr"><<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div lang="EN-GB" link="blue" vlink="purple">
<div><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt">I've just looked at my checkout of 3.6 and it looks like the fix wasn't merged. I don't have the revision number for the fix to hand but in lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp,
this:<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> FilterDAGBasicBlockName ==<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> FuncInfo->MBB->getBasicBlock()->getName().str());<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt">Should be:<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> MatchFilterBB = (FilterDAGBasicBlockName.empty() ||<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> FilterDAGBasicBlockName ==<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> FuncInfo->MBB->getBasicBlock()->getName().str());<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt">The trunk has the correct code so the option should be ok for LLVM 3.7.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"><u></u> <u></u></span></p>
<div style="border-width:medium medium medium 1.5pt;border-style:none none none solid;border-color:currentColor currentColor currentColor blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-width:1pt medium medium;border-style:solid none none;border-color:rgb(181,196,223) currentColor currentColor;padding:3pt 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-family:"Tahoma","sans-serif";font-size:10pt">From:</span></b><span lang="EN-US" style="font-family:"Tahoma","sans-serif";font-size:10pt"> Ryan Taylor [mailto:<a href="mailto:ryta1203@gmail.com" target="_blank">ryta1203@gmail.com</a>]
<br>
<b>Sent:</b> 27 July 2015 17:20<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [LLVMdev] SelectionDAG viewers, filter-view-dags question<u></u><u></u></span></p>
</div>
</div><div><div><p class="MsoNormal"><u></u> <u></u></p>
<div>
<div><p class="MsoNormal">Daniel,<u></u><u></u></p>
</div>
<div><p class="MsoNormal"><u></u> <u></u></p>
</div>
<div><p class="MsoNormal"> We are using 3.6. Someone also pointed out that it was mandatory in 3.6.2 but I have not verified that.<u></u><u></u></p>
</div>
<div><p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<div><p class="MsoNormal"><u></u> <u></u></p>
<div><p class="MsoNormal">On Mon, Jul 27, 2015 at 12:10 PM, Daniel Sanders <<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>> wrote:<u></u><u></u></p>
<div>
<div><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt">It's not supposed to be. There was a short period where it was unintentionally mandatory but this was fixed after
I pointed it out during post-commit review.</span><u></u><u></u></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> </span><u></u><u></u></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt">Which version/revision are you using?</span><u></u><u></u></p><p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";font-size:11pt"> </span><u></u><u></u></p>
<div style="border-width:medium medium medium 1.5pt;border-style:none none none solid;border-color:currentColor currentColor currentColor blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-width:1pt medium medium;border-style:solid none none;border-color:currentColor;padding:3pt 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-family:"Tahoma","sans-serif";font-size:10pt">From:</span></b><span lang="EN-US" style="font-family:"Tahoma","sans-serif";font-size:10pt">
<a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Ryan Taylor<br>
<b>Sent:</b> 27 July 2015 16:27<br>
<b>To:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> [LLVMdev] SelectionDAG viewers, filter-view-dags question</span><u></u><u></u></p>
</div>
</div>
<div>
<div><p class="MsoNormal"> <u></u><u></u></p>
<div>
<div><p class="MsoNormal">Is this option currently mandatory? If so, why? If not, I'm not sure what's been added that I need to do differently.<u></u><u></u></p>
</div>
<div><p class="MsoNormal"> <u></u><u></u></p>
</div>
<div><p class="MsoNormal">-view-isel-dags opened just fine in dotty in 3.4 and now this does nothing without the filter-view-dags 'option' and now has a different priority program list or something.<u></u><u></u></p>
</div>
<div><p class="MsoNormal"> <u></u><u></u></p>
</div>
<div><p class="MsoNormal">I'm just curious why this option should be mandatory?<u></u><u></u></p>
</div>
<div><p class="MsoNormal"> <u></u><u></u></p>
</div>
<div><p class="MsoNormal">Thanks.<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div><p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></div></blockquote></div><br></div></div></blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></div><br></div>